New issue
Advanced search Search tips

Issue 653668 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug
Proj-VR
Proj-XR
Proj-XR-VR



Sign in to add a comment

vr_shell_unittests_apk configuration doesn't compile on the FYI bot

Project Member Reported by avayvod@chromium.org, Oct 6 2016

Issue description

The full log: https://uberchromegw.corp.google.com/i/chromium.fyi/builders/Android%20Builder%20(dbg)/builds/73968/steps/compile/logs/stdio

Example failure:

FAILED: ...
../../chrome/browser/android/vr_shell/ui_scene_unittest.cc:30:30: error: 'vr_shell::Animation::Property' has not been declared
                   Animation::Property property) {
                              ^
../../chrome/browser/android/vr_shell/ui_scene_unittest.cc: In function 'void vr_shell::{anonymous}::addAnimation(vr_shell::UiScene*, int, int, int)':
../../chrome/browser/android/vr_shell/ui_scene_unittest.cc:33:23: error: 'easing' was not declared in this scope
       std::unique_ptr<easing::Easing>(new easing::Linear()),

The gn args:

enable_vr_shell = true
ffmpeg_branding = "Chrome"
is_component_build = false
is_debug = true
proprietary_codecs = true
symbol_level = 1
target_os = "android"
use_goma = true

Build vr_shell_unittests_apk
 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 6 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d2e19f841f97cd64a7f0524fb5b120dc4eb74bab

commit d2e19f841f97cd64a7f0524fb5b120dc4eb74bab
Author: avayvod <avayvod@chromium.org>
Date: Thu Oct 06 20:52:37 2016

Fix compile for vr_shell/ui_scene_unittest.cc

BUG= 653668 
TEST=built the test

Review-Url: https://codereview.chromium.org/2394223003
Cr-Commit-Position: refs/heads/master@{#423668}

[modify] https://crrev.com/d2e19f841f97cd64a7f0524fb5b120dc4eb74bab/chrome/browser/android/vr_shell/ui_scene_unittest.cc

Status: Fixed (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 27 2016

Labels: merge-merged-2840
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d2e19f841f97cd64a7f0524fb5b120dc4eb74bab

commit d2e19f841f97cd64a7f0524fb5b120dc4eb74bab
Author: avayvod <avayvod@chromium.org>
Date: Thu Oct 06 20:52:37 2016

Fix compile for vr_shell/ui_scene_unittest.cc

BUG= 653668 
TEST=built the test

Review-Url: https://codereview.chromium.org/2394223003
Cr-Commit-Position: refs/heads/master@{#423668}

[modify] https://crrev.com/d2e19f841f97cd64a7f0524fb5b120dc4eb74bab/chrome/browser/android/vr_shell/ui_scene_unittest.cc

Comment 4 by dimu@google.com, Nov 4 2016

Labels: -merge-merged-2840
[Automated comment] removing mislabelled merge-merged-2840
Labels: Proj-VR-Shell

Sign in to add a comment