Change the Perf Try Job Workflow. |
|||
Issue descriptionCurrently the perf try job uploads the changes to rietveld before running git cl try. Since Perf Try job is a wrapper around git cl try, we think that performing the upload shouldn't be part of Perf Try job. This wrapper should have the same assumption as "git cl try", the assumption that the developer is working on an existing, already uploaded CL. The tool should just make use of the uploaded CL. Changes to Tool: Display error message if changes are not uploaded. Remove logic to upload changes.
,
Oct 17 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/805fe8562f2b84ab8f9638c82b5ac5d36e6880d7 commit 805fe8562f2b84ab8f9638c82b5ac5d36e6880d7 Author: prasadv <prasadv@google.com> Date: Mon Oct 17 15:57:08 2016 Remove CL upload logic from Perf Try Job workflow. Currently the perf try job uploads the changes to rietveld before running git cl try. Since Perf Try job is a wrapper around git cl try, we think that performing the upload shouldn't be part of Perf Try job. This wrapper should have the same assumption as "git cl try", the assumption that the developer is working on an existing, already uploaded CL. The tool should just make use of the uploaded CL. Changes to Tool: a) Display error message if changes are not uploaded. b) Remove logic to upload changes. c) Update unittests. BUG= 653665 Review-Url: https://codereview.chromium.org/2400003002 Cr-Commit-Position: refs/heads/master@{#425691} [modify] https://crrev.com/805fe8562f2b84ab8f9638c82b5ac5d36e6880d7/tools/perf/core/trybot_command.py [modify] https://crrev.com/805fe8562f2b84ab8f9638c82b5ac5d36e6880d7/tools/perf/core/trybot_command_unittest.py
,
Nov 2 2016
,
Feb 3 2017
|
|||
►
Sign in to add a comment |
|||
Comment 1 by pras...@chromium.org
, Oct 6 2016Status: Started (was: Untriaged)