New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 653661 link

Starred by 1 user
Status: Fixed
Owner:
█ mge...@chromium.org
Last visit > 30 days ago
Closed: Oct 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug

Blocking:
issue 629194



Sign in to add a comment

[Cronet Metrics API] null response start but a non-null response end

Project Member Reported by xunji...@chromium.org, Oct 6 2016 
If a request fails, we populate response end, but response start can be null. It is counter-intuitive to have a null response start with a non-null response end.

Assigning to mgersh@ to triage.

Comment 1 by mge...@chromium.org, Oct 10 2016

Status: Fixed (was: Assigned)
I fixed this by renaming response end to request end, which is a better description of what it is. It's https://codereview.chromium.org/2401933002/, which I forgot to associate with this bug.

Comment 2 by mge...@chromium.org, Oct 10 2016

Labels: Merge-Request-55

Comment 3 by dimu@chromium.org, Oct 11 2016

Labels: -Merge-Request-55 Merge-Approved-55 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M55 (branch: 2883)
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 11 2016

Labels: -merge-approved-55 merge-merged-2883
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aa4bd7168048a3684f5456fb19a50ad5333d1035

commit aa4bd7168048a3684f5456fb19a50ad5333d1035
Author: xunjieli <xunjieli@chromium.org>
Date: Tue Oct 11 17:52:08 2016

Rename RequestFinishedInfo.Metrics.getResponseEnd() to getRequestEnd()

The timestamp is available even when there is no response, so this name
makes more sense.

BUG= 629194 ,  653661 

TBR=mef@chromium.org
NOPRESUBMIT=true
NOTRY=true
Review-Url: https://codereview.chromium.org/2401933002
Cr-Commit-Position: refs/heads/master@{#423872}
(cherry picked from commit 1ad34d61a5dc3b4415c9448885a36e8f442b2c0b)

Review-Url: https://codereview.chromium.org/2410223002
Cr-Commit-Position: refs/branch-heads/2883@{#35}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}

[modify] https://crrev.com/aa4bd7168048a3684f5456fb19a50ad5333d1035/components/cronet/android/api/src/org/chromium/net/RequestFinishedInfo.java
[modify] https://crrev.com/aa4bd7168048a3684f5456fb19a50ad5333d1035/components/cronet/android/java/src/org/chromium/net/impl/CronetBidirectionalStream.java
[modify] https://crrev.com/aa4bd7168048a3684f5456fb19a50ad5333d1035/components/cronet/android/java/src/org/chromium/net/impl/CronetMetrics.java
[modify] https://crrev.com/aa4bd7168048a3684f5456fb19a50ad5333d1035/components/cronet/android/java/src/org/chromium/net/impl/CronetUrlRequest.java
[modify] https://crrev.com/aa4bd7168048a3684f5456fb19a50ad5333d1035/components/cronet/android/test/javatests/src/org/chromium/net/BidirectionalStreamTest.java
[modify] https://crrev.com/aa4bd7168048a3684f5456fb19a50ad5333d1035/components/cronet/android/test/javatests/src/org/chromium/net/MetricsTestUtil.java
[modify] https://crrev.com/aa4bd7168048a3684f5456fb19a50ad5333d1035/components/cronet/android/test/javatests/src/org/chromium/net/RequestFinishedInfoTest.java
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 27 2016

Labels: merge-merged-2840
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aa4bd7168048a3684f5456fb19a50ad5333d1035

commit aa4bd7168048a3684f5456fb19a50ad5333d1035
Author: xunjieli <xunjieli@chromium.org>
Date: Tue Oct 11 17:52:08 2016

Rename RequestFinishedInfo.Metrics.getResponseEnd() to getRequestEnd()

The timestamp is available even when there is no response, so this name
makes more sense.

BUG= 629194 ,  653661 

TBR=mef@chromium.org
NOPRESUBMIT=true
NOTRY=true
Review-Url: https://codereview.chromium.org/2401933002
Cr-Commit-Position: refs/heads/master@{#423872}
(cherry picked from commit 1ad34d61a5dc3b4415c9448885a36e8f442b2c0b)

Review-Url: https://codereview.chromium.org/2410223002
Cr-Commit-Position: refs/branch-heads/2883@{#35}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}

[modify] https://crrev.com/aa4bd7168048a3684f5456fb19a50ad5333d1035/components/cronet/android/api/src/org/chromium/net/RequestFinishedInfo.java
[modify] https://crrev.com/aa4bd7168048a3684f5456fb19a50ad5333d1035/components/cronet/android/java/src/org/chromium/net/impl/CronetBidirectionalStream.java
[modify] https://crrev.com/aa4bd7168048a3684f5456fb19a50ad5333d1035/components/cronet/android/java/src/org/chromium/net/impl/CronetMetrics.java
[modify] https://crrev.com/aa4bd7168048a3684f5456fb19a50ad5333d1035/components/cronet/android/java/src/org/chromium/net/impl/CronetUrlRequest.java
[modify] https://crrev.com/aa4bd7168048a3684f5456fb19a50ad5333d1035/components/cronet/android/test/javatests/src/org/chromium/net/BidirectionalStreamTest.java
[modify] https://crrev.com/aa4bd7168048a3684f5456fb19a50ad5333d1035/components/cronet/android/test/javatests/src/org/chromium/net/MetricsTestUtil.java
[modify] https://crrev.com/aa4bd7168048a3684f5456fb19a50ad5333d1035/components/cronet/android/test/javatests/src/org/chromium/net/RequestFinishedInfoTest.java

Comment 6 by dimu@google.com, Nov 4 2016

Labels: -merge-merged-2840
[Automated comment] removing mislabelled merge-merged-2840
►

Sign in to add a comment