Scroll tests flaky due to floating point comparison
Reported by
huape...@amazon.com,
Oct 6 2016
|
||
Issue descriptionChrome Version : Any What steps will reproduce the problem? 1. Attach Kindle Fire HD 8 device 2. Run run_content_browsertests -f TouchActionBrowserTest.DefaultAuto What is the expected result? The test passes What happens instead? C 137.590s Main ******************************************************************************** C 137.591s Main Detailed Logs C 137.591s Main ******************************************************************************** C 137.591s Main [UNKNOWN] TouchActionBrowserTest.DefaultAuto: C 137.591s Main [ RUN ] TouchActionBrowserTest.DefaultAuto C 137.591s Main [ERROR:devtools_http_handler.cc(221)] Cannot start http server for devtools. Stop devtools. C 137.591s Main [ERROR:shell_android.cc(72)] Not implemented reached in void content::Shell::PlatformSetTitle(const string16&): ready C 137.591s Main C 137.591s Main TouchActionBrowserTest.DefaultAutoUNKNOWN C 137.591s Main OK (0 tests) C 137.591s Main ******************************************************************************** C 137.591s Main Summary C 137.591s Main ******************************************************************************** C 137.591s Main [==========] 1 test ran. C 137.591s Main [ PASSED ] 0 tests. C 137.591s Main [ FAILED ] 1 test, listed below: C 137.591s Main [ FAILED ] TouchActionBrowserTest.DefaultAuto (UNKNOWN) C 137.591s Main C 137.591s Main 1 FAILED TEST C 137.591s Main ********************************************************************************
,
Oct 7 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9b94ba4283bddbe9ee1007aba471d6636fa87c67 commit 9b94ba4283bddbe9ee1007aba471d6636fa87c67 Author: huapengl <huapengl@amazon.com> Date: Fri Oct 07 17:43:29 2016 Fix precision problem in TouchActionBrowserTest. Comparing floating point numbers can lead to unexpected result on different devices. This prevents the test from getting stuck in DoTouchScroll due to minimal floating point deviations. As the test is only verifying that scrolling happened at all or not, just divide the expected value by 2 instead of trying to finesse the problem with epsilons. BUG= 653644 Review-Url: https://codereview.chromium.org/2399153002 Cr-Commit-Position: refs/heads/master@{#423898} [modify] https://crrev.com/9b94ba4283bddbe9ee1007aba471d6636fa87c67/content/browser/renderer_host/input/touch_action_browsertest.cc
,
Oct 11 2016
|
||
►
Sign in to add a comment |
||
Comment 1 by kkaluri@chromium.org
, Oct 7 2016