Remove --disable-timezone-tracking-option |
|||||
Issue descriptionAs far as I can tell, --disable-timezone-tracking-option is no longer needed. It was added when the timezone tracking feature became enabled by default (but still needed user preference or policy setting to actually turn the setting On). Now the feature is on by default, *and* the user setting defaults to On. It can still be disabled in setting or overridden by policy. I suggest remove it, as it complicates already-complex Settings code: https://cs.chromium.org/chromium/src/chrome/browser/ui/webui/options/browser_options_handler.cc?q=kdisabletimezonetrack&sq=package:chromium&dr=C&l=721-729 Time zone geolocation has four possible policies, can be affected by the time zone policy itself, and affects whether or not time zone can be set manually. So anything we can do to simplify this would be great. AFAICT no test makes use of the flag; it can only be enabled on the command line or in about:flags.
,
Oct 13 2016
,
Oct 15 2016
,
Oct 21 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d521ab5a3c8ada9490eba0a0419fc458e0854b3d commit d521ab5a3c8ada9490eba0a0419fc458e0854b3d Author: alemate <alemate@chromium.org> Date: Fri Oct 21 06:50:55 2016 ChromeOS: removed outdated --disable-timezone-tracking-option switch. BUG= 653625 TEST=none CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://chromiumcodereview.appspot.com/2416213004 Cr-Commit-Position: refs/heads/master@{#426740} [modify] https://crrev.com/d521ab5a3c8ada9490eba0a0419fc458e0854b3d/chrome/app/chromeos_strings.grdp [modify] https://crrev.com/d521ab5a3c8ada9490eba0a0419fc458e0854b3d/chrome/browser/about_flags.cc [modify] https://crrev.com/d521ab5a3c8ada9490eba0a0419fc458e0854b3d/chrome/browser/chromeos/login/users/chrome_user_manager_impl.cc [modify] https://crrev.com/d521ab5a3c8ada9490eba0a0419fc458e0854b3d/chrome/browser/chromeos/system/timezone_resolver_manager.cc [modify] https://crrev.com/d521ab5a3c8ada9490eba0a0419fc458e0854b3d/chrome/browser/resources/settings/date_time_page/date_time_page.html [modify] https://crrev.com/d521ab5a3c8ada9490eba0a0419fc458e0854b3d/chrome/browser/resources/settings/date_time_page/date_time_page.js [modify] https://crrev.com/d521ab5a3c8ada9490eba0a0419fc458e0854b3d/chrome/browser/ui/webui/options/browser_options_handler.cc [modify] https://crrev.com/d521ab5a3c8ada9490eba0a0419fc458e0854b3d/chrome/browser/ui/webui/settings/chromeos/date_time_handler.cc [modify] https://crrev.com/d521ab5a3c8ada9490eba0a0419fc458e0854b3d/chromeos/chromeos_switches.cc [modify] https://crrev.com/d521ab5a3c8ada9490eba0a0419fc458e0854b3d/chromeos/chromeos_switches.h
,
Oct 24 2016
,
Nov 1 2016
Closing as verified. |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by weifangsun@chromium.org
, Oct 11 2016Owner: abodenha@chromium.org
Status: Assigned (was: Untriaged)