"ProcessManagerBrowserTest.WebPopupFromExtensionSubframeHasValidOpener" is flaky |
||||||
Issue description"ProcessManagerBrowserTest.WebPopupFromExtensionSubframeHasValidOpener" is flaky. This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label. We have detected 4 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyUAsSBUZsYWtlIkVQcm9jZXNzTWFuYWdlckJyb3dzZXJUZXN0LldlYlBvcHVwRnJvbUV4dGVuc2lvblN1YmZyYW1lSGFzVmFsaWRPcGVuZXIM. Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
,
Oct 6 2016
I'll fix this. This is a test issue on last two lines here:
// Open a new web popup from extension frame. The popup should go into main
// frame's web process.
GURL popup_url(embedded_test_server()->GetURL("/empty.html"));
content::WebContents* popup = OpenPopup(extension_frame, popup_url);
EXPECT_NE(popup, tab);
ASSERT_EQ(2, browser()->tab_strip_model()->count());
EXPECT_EQ(1u, pm->GetRenderFrameHostsForExtension(extension->id()).size());
EXPECT_EQ(1u, pm->GetAllFrames().size());
Looks like the initial RFH in the popup (which is in the extension origin) isn't going away in time for these two checks. These two checks are actually not essential to the test and can just be removed (they are subsumed by the subsequent process checks).
,
Oct 6 2016
,
Oct 7 2016
Detected 4 new flakes for test/step "ProcessManagerBrowserTest.WebPopupFromExtensionSubframeHasValidOpener". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyUAsSBUZsYWtlIkVQcm9jZXNzTWFuYWdlckJyb3dzZXJUZXN0LldlYlBvcHVwRnJvbUV4dGVuc2lvblN1YmZyYW1lSGFzVmFsaWRPcGVuZXIM. This message was posted automatically by the chromium-try-flakes app. Since flakiness is ongoing, the issue was moved back into Sheriff Bug Queue (unless already there).
,
Oct 7 2016
Removing from the sheriff queue, as alexmos@ is looking at resolving this.
,
Oct 7 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/906c43502ebae9b159a2c6353757b1fe83989b42 commit 906c43502ebae9b159a2c6353757b1fe83989b42 Author: alexmos <alexmos@chromium.org> Date: Fri Oct 07 22:19:06 2016 Deflake the WebPopupFromExtension*HasValidOpener tests. This CL removes two problematic checks which could have potentially counted the original extension frame in the popup that was about to be (but not yet) deleted. These checks aren't essential to the test, as the RPH checks on the next line already guarantee that the popup ends up in the correct process. BUG= 653617 TBR=rdevlin.cronin@chromium.org Review-Url: https://codereview.chromium.org/2399183003 Cr-Commit-Position: refs/heads/master@{#423984} [modify] https://crrev.com/906c43502ebae9b159a2c6353757b1fe83989b42/chrome/browser/extensions/process_manager_browsertest.cc
,
Oct 7 2016
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by nasko@chromium.org
, Oct 6 2016Owner: alex...@chromium.org
Status: Assigned (was: Untriaged)