Unable to dep on //third_party/webrtc for target_os = iOS |
||||
Issue descriptionThere is no target defined for iOS with the name "//third_party/webrtc:webrtc" but many parent dependencies assume there will be a target with this name. As a result attempting to build Chrome Remote Desktop for iOS inside of Chromium fails with the following error: ERROR Unresolved dependencies. //third_party/libjingle:libjingle_webrtc_common(//build/toolchain/mac:ios_clang_x64) needs //third_party/webrtc:webrtc(//build/toolchain/mac:ios_clang_x64) //remoting/client:opengl_renderer(//build/toolchain/mac:ios_clang_x64) needs //third_party/webrtc:webrtc(//build/toolchain/mac:ios_clang_x64) //remoting:remoting_unittests_arch_executable(//build/toolchain/mac:ios_clang_x64) needs //third_party/webrtc:webrtc(//build/toolchain/mac:ios_clang_x64) //remoting:remoting_unittests(//build/toolchain/mac:ios_clang_x64) needs //third_party/webrtc:webrtc(//build/toolchain/mac:ios_clang_x64) //remoting:remoting_unittests_arch_executable_sources(//build/toolchain/mac:ios_clang_x64) needs //third_party/webrtc:webrtc(//build/toolchain/mac:ios_clang_x64) //remoting/client:unit_tests(//build/toolchain/mac:ios_clang_x64) needs //third_party/webrtc:webrtc(//build/toolchain/mac:ios_clang_x64)
,
Oct 6 2016
,
Oct 7 2016
,
Oct 25 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1b5df0c36af06d0963a77b7103088d3a63648e02 commit 1b5df0c36af06d0963a77b7103088d3a63648e02 Author: nicholss <nicholss@chromium.org> Date: Tue Oct 25 16:04:49 2016 Removing the dependency on //third_party/webrtc:webrtc and replacing with rtc_base. R=sergeyu@chromium.org BUG= 653612 Review-Url: https://codereview.chromium.org/2437453004 Cr-Commit-Position: refs/heads/master@{#427371} [modify] https://crrev.com/1b5df0c36af06d0963a77b7103088d3a63648e02/remoting/BUILD.gn [modify] https://crrev.com/1b5df0c36af06d0963a77b7103088d3a63648e02/remoting/client/BUILD.gn [modify] https://crrev.com/1b5df0c36af06d0963a77b7103088d3a63648e02/remoting/codec/BUILD.gn [modify] https://crrev.com/1b5df0c36af06d0963a77b7103088d3a63648e02/remoting/protocol/ice_connection_to_client.cc [modify] https://crrev.com/1b5df0c36af06d0963a77b7103088d3a63648e02/remoting/protocol/webrtc_audio_module.cc [modify] https://crrev.com/1b5df0c36af06d0963a77b7103088d3a63648e02/remoting/protocol/webrtc_audio_module.h [modify] https://crrev.com/1b5df0c36af06d0963a77b7103088d3a63648e02/remoting/test/app_remoting_test_driver.cc [modify] https://crrev.com/1b5df0c36af06d0963a77b7103088d3a63648e02/remoting/test/chromoting_test_driver.cc [modify] https://crrev.com/1b5df0c36af06d0963a77b7103088d3a63648e02/third_party/libjingle/BUILD.gn
,
Oct 25 2016
,
Oct 26 2016
Thanks for doing this nicholss@. I've started working on eliminating the whole //third_party/webrtc:webrtc target in its current form but that work is tedious and will take time. Changes like this certainly helps!
,
Oct 26 2016
No problem kjellander@! I have removed all usage of the root :webrtc include for the remoting dependency tree. I think the Chromoting iOS work is unblocked!! Thanks for your work on the webrtc side that enabled this.
,
Nov 15 2016
[bulk-edit : please ignore if not applicable] Could you please set the correct milestone for this issue? |
||||
►
Sign in to add a comment |
||||
Comment 1 by jamiewa...@chromium.org
, Oct 6 2016Owner: pthatcher@chromium.org