New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 653608 link

Starred by 1 user
Status: Fixed
Owner:
█ nicho...@chromium.org
Last visit > 30 days ago
Closed: Oct 2016
Cc:
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Bug

Blocking:
issue 652781
issue 653589



Sign in to add a comment

//ipc/test_support is a required transient dep from //media for target_os = iOS

Project Member Reported by nicho...@chromium.org, Oct 6 2016 
While trying to build Chrome Remote Desktop for iOS, I am running into an error:

ERROR Unresolved dependencies.
//url/ipc:url_ipc_unittests(//build/toolchain/mac:ios_clang_x64)
  needs //ipc:test_support(//build/toolchain/mac:ios_clang_x64)
//url/ipc:url_ipc_unittests_arch_executable_sources(//build/toolchain/mac:ios_clang_x64)
  needs //ipc:test_support(//build/toolchain/mac:ios_clang_x64)
//gpu/ipc/service:gpu_ipc_service_unittests(//build/toolchain/mac:ios_clang_x64)
  needs //ipc:run_all_unittests(//build/toolchain/mac:ios_clang_x64)
//gpu/ipc/service:gpu_ipc_service_unittests(//build/toolchain/mac:ios_clang_x64)
  needs //ipc:test_support(//build/toolchain/mac:ios_clang_x64)
//gpu/ipc/service:gpu_ipc_service_unittests_arch_executable(//build/toolchain/mac:ios_clang_x64)
  needs //ipc:run_all_unittests(//build/toolchain/mac:ios_clang_x64)
//gpu/ipc/service:gpu_ipc_service_unittests_arch_executable(//build/toolchain/mac:ios_clang_x64)
  needs //ipc:test_support(//build/toolchain/mac:ios_clang_x64)
//remoting/client:opengl_renderer(//build/toolchain/mac:ios_clang_x64)
  needs //third_party/webrtc:webrtc(//build/toolchain/mac:ios_clang_x64)
//third_party/libjingle:libjingle_webrtc_common(//build/toolchain/mac:ios_clang_x64)
  needs //third_party/webrtc:webrtc(//build/toolchain/mac:ios_clang_x64)
//gpu/ipc/service:gpu_ipc_service_unittests_arch_executable_sources(//build/toolchain/mac:ios_clang_x64)
  needs //ipc:run_all_unittests(//build/toolchain/mac:ios_clang_x64)
//gpu/ipc/service:gpu_ipc_service_unittests_arch_executable_sources(//build/toolchain/mac:ios_clang_x64)
  needs //ipc:test_support(//build/toolchain/mac:ios_clang_x64)
//remoting:remoting_unittests_arch_executable(//build/toolchain/mac:ios_clang_x64)
  needs //third_party/webrtc:webrtc(//build/toolchain/mac:ios_clang_x64)
//remoting:remoting_unittests_arch_executable_sources(//build/toolchain/mac:ios_clang_x64)
  needs //third_party/webrtc:webrtc(//build/toolchain/mac:ios_clang_x64)
//remoting/client:unit_tests(//build/toolchain/mac:ios_clang_x64)
  needs //third_party/webrtc:webrtc(//build/toolchain/mac:ios_clang_x64)
//remoting:remoting_unittests(//build/toolchain/mac:ios_clang_x64)
  needs //third_party/webrtc:webrtc(//build/toolchain/mac:ios_clang_x64)
//url/ipc:url_ipc_unittests_arch_executable(//build/toolchain/mac:ios_clang_x64)
  needs //ipc:test_support(//build/toolchain/mac:ios_clang_x64)

The issue is that ipc will not and should not be used by iOS and so the targets are inside of ipc are guarded by if (!is_ios) but the parent dependencies do not have the same guards in place.

Here is the dep graph:
//media
  //gpu
    //gpu/ipc/client
      //url/ipc

Comment 1 by jamiewa...@chromium.org, Oct 6 2016

Owner: nicho...@chromium.org
Status: Assigned (was: Untriaged)
media/ is pulled in by audio_encoder_opus.cc, which is not needed on the client. We should be able to exclude this file (and dependent targets, such as the audio unit tests) on iOS.

Comment 2 by jamiewa...@chromium.org, Oct 6 2016

Blocking: 653589

Comment 3 by nicho...@chromium.org, Oct 12 2016

Status: Fixed (was: Assigned)

Comment 4 by nicho...@chromium.org, Oct 12 2016 

Fixed by https://codereview.chromium.org/2402623003/

we no longer depend on //media in iOS.
►

Sign in to add a comment