NOTREACHED / Not implemented in RenderWidgetHostViewBase::SetInsets |
||||
Issue description
Chrome Version : 54.0.2840.43
OS Version: 8743.44.0
URLs (if applicable) :
Other browsers tested:
Add OK or FAIL after other browsers where you have tested this issue:
Safari 5:
Firefox 4.x:
IE 7/8/9:
What steps will reproduce the problem?
1. Flip device to tablet mode
2. (tap on text box to show virtual keyboard)
3.
What is the expected result?
No errors in ui log.
What happens instead of that?
file:///var/log/ui/ui.LATEST
[22074:22074:1007/010234:ERROR:render_widget_host_view_base.cc(355)] Not implemented reached in virtual void content::RenderWidgetHostViewBase::SetInsets(const gfx::Insets&)
[22074:22074:1007/010234:ERROR:render_widget_host_view_child_frame.cc(202)] NOTREACHED() hit.
Assigning to kevers, since he added the NOTIMPLEMENTED (back in 2014!):
https://chromium.googlesource.com/chromium/src/+/bb6378fe4e26c8e85f9fabd0976f3b1628ef4b91
Please provide any additional information below. Attach a screenshot if
possible.
UserAgentString: Mozilla/5.0 (X11; CrOS aarch64 8743.44.0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/54.0.2840.43 Safari/537.36
,
Jun 26 2017
Saw this in a feedback report today, report 66813438749. Unassigning since it looks like kevers@ has moved on.
,
Jun 26 2017
,
Oct 9 2017
Seen again today on M61. https://listnr.corp.google.com/product/208/report/75483346120 [1424:1424:1007/113008.540047:ERROR:render_widget_host_view_base.cc(320)] Not implemented reached in virtual void content<IPv6: 1>RenderWidgetHostViewBas<IPv6: 3>SetInsets(const gfx<IPv6: 1>Insets &)
,
Mar 26 2018
This issue becomes serious log spam after enabling floating VK because every dragging of the VK causes log output. I believe I understand who emits the logs now. Let me try to fix this issue.
,
Mar 28 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b4589464fde15c1dc8b5d5d9fa6fcde2060fd269 commit b4589464fde15c1dc8b5d5d9fa6fcde2060fd269 Author: Yuichiro Hanada <yhanada@chromium.org> Date: Wed Mar 28 04:34:29 2018 Implement RenderWidgetHostViewChildFrame::SetInsets(). A lack of implementation of SetInsets in RenderWidgetHostViewChildFrame causes log spamming when enabling the virtual keyboard. This CL adds implementation of it. Bug: 653601 Change-Id: I56158162d0cbf7fbed024fc6e778b1ef5c728fcc Reviewed-on: https://chromium-review.googlesource.com/979905 Reviewed-by: Ken Buchanan <kenrb@chromium.org> Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/heads/master@{#546404} [modify] https://crrev.com/b4589464fde15c1dc8b5d5d9fa6fcde2060fd269/content/browser/renderer_host/render_widget_host_view_child_frame.cc [modify] https://crrev.com/b4589464fde15c1dc8b5d5d9fa6fcde2060fd269/content/browser/renderer_host/render_widget_host_view_child_frame.h
,
Mar 28 2018
|
||||
►
Sign in to add a comment |
||||
Comment 1 by oka@chromium.org
, Feb 3 2017