Unable to include webRTC from within Chromium while using a target_os = iOS |
|||
Issue description
Chrome Remote Desktop iOS app has a dependency on webrtc. Attempting to depend on webrtc inside of Chromium results in the following error:
ERROR at //third_party/webrtc/sdk/BUILD.gn:309:9: Can't load input file.
"//webrtc/system_wrappers:field_trial_default",
^---------------------------------------------
Unable to load:
/Users/nicholss/chromoting/chromium/src/webrtc/system_wrappers/BUILD.gn
I also checked in the secondary tree for:
/Users/nicholss/chromoting/chromium/src/build/secondary/webrtc/system_wrappers/BUILD.gn
Expected:
I should be able to depend on //third_party/webrtc/media using iOS as the target platform.
,
Oct 6 2016
,
Oct 7 2016
diff --git a/sdk/BUILD.gn b/sdk/BUILD.gn
index 4cceb8e..8415eb6 100644
--- a/sdk/BUILD.gn
+++ b/sdk/BUILD.gn
@@ -250,7 +250,7 @@ if (is_ios || (is_mac && mac_deployment_target == "10.7")) {
"objc/Framework/Headers/WebRTC/UIDevice+RTCDevice.h",
"objc/Framework/Headers/WebRTC/WebRTC.h",
]
- if (is_mac) {
+ if (is_mac && !is_ios) {
mac_framework_bundle("rtc_sdk_framework_objc") {
info_plist = "objc/Framework/Info.plist"
output_name = "WebRTC"
@@ -264,8 +264,8 @@ if (is_ios || (is_mac && mac_deployment_target == "10.7")) {
deps = [
":rtc_sdk_peerconnection_objc",
- "//webrtc/system_wrappers:field_trial_default",
- "//webrtc/system_wrappers:metrics_default",
+ "../system_wrappers:field_trial_default",
+ "../system_wrappers:metrics_default",
]
libs = [
@@ -306,8 +306,8 @@ if (is_ios || (is_mac && mac_deployment_target == "10.7")) {
deps = [
":rtc_sdk_peerconnection_objc",
- "//webrtc/system_wrappers:field_trial_default",
- "//webrtc/system_wrappers:metrics_default",
+ "../system_wrappers:field_trial_default",
+ "../system_wrappers:metrics_default",
]
libs = [
,
Oct 7 2016
,
Oct 12 2016
Fixed by https://codereview.webrtc.org/2393133007/ But the fix needs to be rolled to Chromium to take effect.
,
Nov 15 2016
[bulk-edit : please ignore if not applicable] Could you please set the correct milestone for this issue? |
|||
►
Sign in to add a comment |
|||
Comment 1 by nicho...@chromium.org
, Oct 6 2016