//third_party/mesa is blocking iOS platforms from including //media |
|||||
Issue description
The following dependency graph is preventing iOS platform builds from building in
Chromium:
//remoting/codec
//media
//ui/gl
//third_party/mesa
The error is:
ERROR at //third_party/mesa/BUILD.gn:16:1: Assertion failed.
assert(!is_ios, "mesa is not used on iOS, don't pull it in accidentally")
^-----
mesa is not used on iOS, don't pull it in accidentally
See //ui/gl/BUILD.gn:149:5: which caused the file to be included.
"//third_party/mesa:mesa_headers",
^--------------------------------
Expected: I should be able to depend on //media from a iOS platform build within Chromium.
,
Oct 6 2016
,
Oct 7 2016
,
Oct 7 2016
I think this was incorrectly triaged. Reassigning to nicholss@ who is working on the support for Chromoting on iOS.
,
Oct 7 2016
The current plan is to refactor the remoting code to move the dependency of //media to be host only, and thus will no longer be an issue for iOS clients. This work will not address the overall issue of iOS support on //media though so someone else will run into this if they are working on iOS and happen to get //media included. But perhaps this will not happen.
,
Oct 10 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bf3b59ec67e2904ef3932b9ff625d376c82f21a2 commit bf3b59ec67e2904ef3932b9ff625d376c82f21a2 Author: nicholss <nicholss@chromium.org> Date: Mon Oct 10 20:12:22 2016 Adding encoder and decoder targets inside of //remoting/codec. BUG= 653589 R=sergeyu@chromium.org Review-Url: https://codereview.chromium.org/2402623003 Cr-Commit-Position: refs/heads/master@{#424216} [modify] https://crrev.com/bf3b59ec67e2904ef3932b9ff625d376c82f21a2/remoting/codec/BUILD.gn
,
Oct 12 2016
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by nicho...@chromium.org
, Oct 6 2016