As said, remove all that code that is only working partially.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ba3ab95c91d96790a4d6276225e786d570260410 commit ba3ab95c91d96790a4d6276225e786d570260410 Author: emircan <emircan@chromium.org> Date: Fri Oct 07 22:51:13 2016 Cleanup of video capture into GpuMemoryBuffer This is CL #1 of 2 for cleaning up GpuMemoryBuffer usage for video capture. This project is superseded by capture using mojo. This CL cleans up: - VideoPixelStorage type PIXEL_STORAGE_GPUMEMORYBUFFER - GpuMemoryBufferTracker as a VideoCaptureBufferTracker - GpuMemoryBufferBufferHandle as a VideoCaptureBufferHandle - kUseGpuMemoryBuffersForCapture flag Note that this leads to having enums and factories that only produce shared memory. chfremer@ is going to take over that refactor. BUG=440843, 653579 Review-Url: https://codereview.chromium.org/2398813002 Cr-Commit-Position: refs/heads/master@{#423994} [modify] https://crrev.com/ba3ab95c91d96790a4d6276225e786d570260410/content/browser/BUILD.gn [delete] https://crrev.com/31d0a108f1783a04f2b981d668883a43a30ddc32/content/browser/renderer_host/media/gpu_memory_buffer_handle.cc [delete] https://crrev.com/31d0a108f1783a04f2b981d668883a43a30ddc32/content/browser/renderer_host/media/gpu_memory_buffer_handle.h [delete] https://crrev.com/31d0a108f1783a04f2b981d668883a43a30ddc32/content/browser/renderer_host/media/gpu_memory_buffer_tracker.cc [delete] https://crrev.com/31d0a108f1783a04f2b981d668883a43a30ddc32/content/browser/renderer_host/media/gpu_memory_buffer_tracker.h [modify] https://crrev.com/ba3ab95c91d96790a4d6276225e786d570260410/content/browser/renderer_host/media/shared_memory_buffer_tracker.cc [modify] https://crrev.com/ba3ab95c91d96790a4d6276225e786d570260410/content/browser/renderer_host/media/shared_memory_buffer_tracker.h [modify] https://crrev.com/ba3ab95c91d96790a4d6276225e786d570260410/content/browser/renderer_host/media/video_capture_buffer_pool_unittest.cc [modify] https://crrev.com/ba3ab95c91d96790a4d6276225e786d570260410/content/browser/renderer_host/media/video_capture_buffer_tracker_factory_impl.cc [modify] https://crrev.com/ba3ab95c91d96790a4d6276225e786d570260410/content/browser/renderer_host/media/video_capture_controller.cc [modify] https://crrev.com/ba3ab95c91d96790a4d6276225e786d570260410/media/base/media_switches.cc [modify] https://crrev.com/ba3ab95c91d96790a4d6276225e786d570260410/media/base/media_switches.h [modify] https://crrev.com/ba3ab95c91d96790a4d6276225e786d570260410/media/base/video_capture_types.cc [modify] https://crrev.com/ba3ab95c91d96790a4d6276225e786d570260410/media/base/video_capture_types.h [modify] https://crrev.com/ba3ab95c91d96790a4d6276225e786d570260410/media/capture/video/fake_video_capture_device.cc [modify] https://crrev.com/ba3ab95c91d96790a4d6276225e786d570260410/media/capture/video/fake_video_capture_device_unittest.cc [modify] https://crrev.com/ba3ab95c91d96790a4d6276225e786d570260410/media/capture/video/video_capture_buffer_pool.h [modify] https://crrev.com/ba3ab95c91d96790a4d6276225e786d570260410/media/capture/video/video_capture_buffer_pool_impl.cc [modify] https://crrev.com/ba3ab95c91d96790a4d6276225e786d570260410/media/capture/video/video_capture_buffer_pool_impl.h [modify] https://crrev.com/ba3ab95c91d96790a4d6276225e786d570260410/media/capture/video/video_capture_buffer_tracker.h [modify] https://crrev.com/ba3ab95c91d96790a4d6276225e786d570260410/media/capture/video/video_capture_device_client.cc [modify] https://crrev.com/ba3ab95c91d96790a4d6276225e786d570260410/media/capture/video/video_capture_device_client.h [modify] https://crrev.com/ba3ab95c91d96790a4d6276225e786d570260410/services/video_capture/public/interfaces/video_capture_format_traits.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5471ad2f678cc6e57475ed5e44cc20891917e690 commit 5471ad2f678cc6e57475ed5e44cc20891917e690 Author: emircan <emircan@chromium.org> Date: Sat Oct 08 05:55:28 2016 Cleanup of passing GpuMemoryBuffer backed video frames This is CL #2 of 2 for cleaning up GpuMemoryBuffer usage for video capture. This project is superseded by capture using mojo. This CL cleans up: - VideoFrame::StorageType enum STORAGE_GPU_MEMORY_BUFFERS - IPC messages added for passing GMB backed frames -- From browser to renderer -- From renderer to gpu I opened a bug to remove gpu::SyncToken usage on crbug.com/653994 . That is also dead code but not related to GMBs, so leaving it for a separate CL. BUG=440843, 653579 Review-Url: https://codereview.chromium.org/2395913003 Cr-Commit-Position: refs/heads/master@{#424072} [modify] https://crrev.com/5471ad2f678cc6e57475ed5e44cc20891917e690/content/browser/renderer_host/media/video_capture_controller.cc [modify] https://crrev.com/5471ad2f678cc6e57475ed5e44cc20891917e690/content/browser/renderer_host/media/video_capture_controller_event_handler.h [modify] https://crrev.com/5471ad2f678cc6e57475ed5e44cc20891917e690/content/browser/renderer_host/media/video_capture_controller_unittest.cc [modify] https://crrev.com/5471ad2f678cc6e57475ed5e44cc20891917e690/content/browser/renderer_host/media/video_capture_host.cc [modify] https://crrev.com/5471ad2f678cc6e57475ed5e44cc20891917e690/content/browser/renderer_host/media/video_capture_host.h [modify] https://crrev.com/5471ad2f678cc6e57475ed5e44cc20891917e690/content/browser/renderer_host/media/video_capture_manager_unittest.cc [modify] https://crrev.com/5471ad2f678cc6e57475ed5e44cc20891917e690/content/common/media/video_capture_messages.h [modify] https://crrev.com/5471ad2f678cc6e57475ed5e44cc20891917e690/content/renderer/media/gpu/rtc_video_encoder.cc [modify] https://crrev.com/5471ad2f678cc6e57475ed5e44cc20891917e690/content/renderer/media/video_capture_impl.cc [modify] https://crrev.com/5471ad2f678cc6e57475ed5e44cc20891917e690/content/renderer/media/video_capture_impl.h [modify] https://crrev.com/5471ad2f678cc6e57475ed5e44cc20891917e690/content/renderer/media/video_capture_message_filter.cc [modify] https://crrev.com/5471ad2f678cc6e57475ed5e44cc20891917e690/content/renderer/media/video_capture_message_filter.h [modify] https://crrev.com/5471ad2f678cc6e57475ed5e44cc20891917e690/content/renderer/media/video_capture_message_filter_unittest.cc [modify] https://crrev.com/5471ad2f678cc6e57475ed5e44cc20891917e690/content/renderer/media/video_track_adapter.cc [modify] https://crrev.com/5471ad2f678cc6e57475ed5e44cc20891917e690/content/renderer/media/webrtc/webrtc_video_capturer_adapter.cc [modify] https://crrev.com/5471ad2f678cc6e57475ed5e44cc20891917e690/content/renderer/media/webrtc/webrtc_video_frame_adapter.cc [modify] https://crrev.com/5471ad2f678cc6e57475ed5e44cc20891917e690/media/base/video_frame.cc [modify] https://crrev.com/5471ad2f678cc6e57475ed5e44cc20891917e690/media/base/video_frame.h [modify] https://crrev.com/5471ad2f678cc6e57475ed5e44cc20891917e690/media/gpu/ipc/client/gpu_video_encode_accelerator_host.cc [modify] https://crrev.com/5471ad2f678cc6e57475ed5e44cc20891917e690/media/gpu/ipc/client/gpu_video_encode_accelerator_host.h [modify] https://crrev.com/5471ad2f678cc6e57475ed5e44cc20891917e690/media/gpu/ipc/common/media_messages.h [modify] https://crrev.com/5471ad2f678cc6e57475ed5e44cc20891917e690/media/gpu/ipc/service/gpu_video_encode_accelerator.cc [modify] https://crrev.com/5471ad2f678cc6e57475ed5e44cc20891917e690/media/gpu/ipc/service/gpu_video_encode_accelerator.h
[bulk-edit : please ignore if not applicable] Could you please set the correct milestone for this issue?
Comment 1 by bugdroid1@chromium.org
, Oct 7 2016