Make .gn .isolate files for VS 2015 DLLs easier to use |
||||||||||
Issue descriptionWould it be possible to move the changes made in https://codereview.chromium.org/1783973002 out of src/base (maybe to src/build) in order to make them easier to re-use. This is not a Chromium specific change, so when the files need to be updated, this would cause problems for downstream projects that are unaware of the changes made.
,
Nov 30 2016
Though not really blocking, it'd be nice to have for issue 603131 . For now I will just copy this stuff too.
,
Mar 21 2017
,
Mar 21 2017
,
Mar 21 2017
,
Apr 5 2018
Having a stab at this: https://chromium-review.googlesource.com/c/chromium/src/+/997794
,
Apr 5 2018
Patrik, FYi
,
Apr 6 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5a4f610ded51627273b1f05e83379b1ce8e3c6aa commit 5a4f610ded51627273b1f05e83379b1ce8e3c6aa Author: Michael Achenbach <machenbach@chromium.org> Date: Fri Apr 06 18:53:15 2018 [build] Move windows runtime-libs gn configs to src/build This will allow webrtc and v8 to share the configs. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win-msvc-dbg Bug: 653569 Change-Id: I41a4d9025f47fd3a9d6837f88c2bece108c213a8 Reviewed-on: https://chromium-review.googlesource.com/997794 Reviewed-by: Bruce Dawson <brucedawson@chromium.org> Reviewed-by: Nico Weber <thakis@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#548874} [modify] https://crrev.com/5a4f610ded51627273b1f05e83379b1ce8e3c6aa/base/BUILD.gn [modify] https://crrev.com/5a4f610ded51627273b1f05e83379b1ce8e3c6aa/build/win/BUILD.gn
,
Apr 9 2018
,
Apr 9 2018
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/59a56825899d9ce84668fe07e1e5922f65ead8f6 commit 59a56825899d9ce84668fe07e1e5922f65ead8f6 Author: Michael Achenbach <machenbach@chromium.org> Date: Mon Apr 09 07:31:15 2018 [V8] Share windows runtime dlls with src/build Bug: chromium:653569 Change-Id: I2fa288d3281c75d3e5d483fb94d29efe454c633b Reviewed-on: https://chromium-review.googlesource.com/1000773 Reviewed-by: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#52464} [modify] https://crrev.com/59a56825899d9ce84668fe07e1e5922f65ead8f6/BUILD.gn
,
Apr 9 2018
The following revision refers to this bug: https://webrtc.googlesource.com/src.git/+/220609774adb9bad9178ffd9b819fc07e627989d commit 220609774adb9bad9178ffd9b819fc07e627989d Author: Michael Achenbach <machenbach@chromium.org> Date: Mon Apr 09 10:33:18 2018 [build] Share windows runtime dlls with src/build Bug: chromium:653569 Change-Id: I6ced614819f9fd7f594acf2fd08c491f16d3eed5 Reviewed-on: https://webrtc-review.googlesource.com/68480 Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#22790} [modify] https://crrev.com/220609774adb9bad9178ffd9b819fc07e627989d/rtc_base/BUILD.gn
,
Apr 9 2018
,
Apr 9 2018
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/74543b0016b007fd9e66a53b153701feba7d2b22 commit 74543b0016b007fd9e66a53b153701feba7d2b22 Author: Michael Achenbach <machenbach@chromium.org> Date: Mon Apr 09 18:40:04 2018 Revert "[V8] Share windows runtime dlls with src/build" This reverts commit 59a56825899d9ce84668fe07e1e5922f65ead8f6. Reason for revert: https://build.chromium.org/p/client.v8.fyi/builders/Win%20V8%20FYI%20Release%20%28NVIDIA%29/builds/444 Original change's description: > [V8] Share windows runtime dlls with src/build > > Bug: chromium:653569 > Change-Id: I2fa288d3281c75d3e5d483fb94d29efe454c633b > Reviewed-on: https://chromium-review.googlesource.com/1000773 > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Commit-Queue: Michael Achenbach <machenbach@chromium.org> > Cr-Commit-Position: refs/heads/master@{#52464} TBR=machenbach@chromium.org,yangguo@chromium.org,jgruber@chromium.org Change-Id: Ie2fd502eb76d162678b3b90f14989ca74410b5a3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:653569 Reviewed-on: https://chromium-review.googlesource.com/1003192 Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#52487} [modify] https://crrev.com/74543b0016b007fd9e66a53b153701feba7d2b22/BUILD.gn
,
Apr 9 2018
Needed to revert. Will analyze tomorrow.
,
Apr 9 2018
Need to also figure out why the V8 tree didn't close on the breakage.
,
Apr 10 2018
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/c1c40d398241f955d51b5879306377a80760b947 commit c1c40d398241f955d51b5879306377a80760b947 Author: Michael Achenbach <machenbach@chromium.org> Date: Tue Apr 10 06:56:07 2018 Reland "[build] Share windows runtime dlls with src/build" This is a reland of 59a56825899d9ce84668fe07e1e5922f65ead8f6 Original change's description: > [V8] Share windows runtime dlls with src/build > > Bug: chromium:653569 > Change-Id: I2fa288d3281c75d3e5d483fb94d29efe454c633b > Reviewed-on: https://chromium-review.googlesource.com/1000773 > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Commit-Queue: Michael Achenbach <machenbach@chromium.org> > Cr-Commit-Position: refs/heads/master@{#52464} TBR=jgruber@chromium.org Bug: chromium:653569 Change-Id: I74f67b25205c6505fc90e41c059fbb6f4e20c078 Reviewed-on: https://chromium-review.googlesource.com/1004454 Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#52500} [modify] https://crrev.com/c1c40d398241f955d51b5879306377a80760b947/BUILD.gn
,
Apr 10 2018
,
Apr 10 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build/+/8d57484cf5e0c7ab551366c148c179ae7ed11eb7 commit 8d57484cf5e0c7ab551366c148c179ae7ed11eb7 Author: Michael Achenbach <machenbach@chromium.org> Date: Tue Apr 10 07:12:19 2018 [V8] Close tree on MB errors of V8's Chromium builders The breakage causing https://crrev.com/c/1003192 went by undetected. TBR=sergiyb@chromium.org Bug: 653569 Change-Id: If6d8b7860d09cb94d0776262f5234a5814a628f5 Reviewed-on: https://chromium-review.googlesource.com/1004574 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> [modify] https://crrev.com/8d57484cf5e0c7ab551366c148c179ae7ed11eb7/scripts/slave/v8/gatekeeper_v8_tree_closers.json
,
Apr 11 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4ef762b207fa57159429481519fa4d4a9b16f409 commit 4ef762b207fa57159429481519fa4d4a9b16f409 Author: webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Wed Apr 11 02:51:36 2018 Roll src/third_party/webrtc/ 4da18e89b..3ef3bfc2a (33 commits) https://webrtc.googlesource.com/src.git/+log/4da18e89bdee..3ef3bfc2aafa $ git log 4da18e89b..3ef3bfc2a --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc BUG=chromium:None,chromium:None,chromium:b/77579859,chromium:828350,chromium:831081,chromium:b/77579859,chromium:None,chromium:b/77579859,chromium:653569,chromium:None,chromium:none The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I71719fdca346a7f4d6ee290065e95b89427cba70 Reviewed-on: https://chromium-review.googlesource.com/1005366 Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#549738} [modify] https://crrev.com/4ef762b207fa57159429481519fa4d4a9b16f409/DEPS |
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by dpranke@chromium.org
, Oct 6 2016