Issue metadata
Sign in to add a comment
|
34.7%-81.3% regression in blink_perf.canvas at 422775:422899 |
||||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
Oct 6 2016
Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/8999539141895540720
,
Oct 6 2016
=== Auto-CCing suspected CL author junov@chromium.org === Hi junov@chromium.org, the bisect results pointed to your CL below as possibly causing a regression. Please have a look at this info and see whether your CL be related. ===== BISECT JOB RESULTS ===== Status: completed ===== SUSPECTED CL(s) ===== Subject : Disable GPU acceleration on 2D canvas when readbacks are needed Author : junov Commit description: We are already disabling GPU acceleration to avoid readbacks caused by calls to getImageData. This change applies the same principle to canvas-to-canvas drawImage calls in order to avoid probable future readbacks. BUG= 652126 , 651517 , 650116 , 642539 , 640144 Review-Url: https://codereview.chromium.org/2388293002 Cr-Commit-Position: refs/heads/master@{#422848} Commit : 2b0d65c9311d7e87784e90d60bfc68efb5f03555 Date : Tue Oct 04 17:37:58 2016 ===== TESTED REVISIONS ===== Revision Mean Std Dev N Good? chromium@422823 2423.66 30.5901 5 good chromium@422837 2530.58 153.751 5 good chromium@422844 15071.5 28020.4 5 good chromium@422846 2463.09 165.54 5 good chromium@422847 2354.47 83.0299 5 good chromium@422848 1594.9 19.2319 4 bad <-- chromium@422851 1572.69 34.218 5 bad Bisect job ran on: mac_10_11_perf_bisect Bug ID: 653565 Test Command: src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --also-run-disabled-tests blink_perf.canvas Test Metric: draw-video-to-hw-accelerated-canvas-2d/draw-video-to-hw-accelerated-canvas-2d Relative Change: 35.11% Score: 99.9 Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/mac_10_11_perf_bisect/builds/949 Job details: https://chromeperf.appspot.com/buildbucket_job_status/8999539141895540720 Not what you expected? We'll investigate and get back to you! https://chromeperf.appspot.com/bad_bisect?try_job_id=5817702025789440 | O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq | X | for more information addressing perf regression bugs. For feedback, | / \ | file a bug with component Tests>AutoBisect. Thank you!
,
Oct 6 2016
,
Oct 7 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a9d5a27ad2b3f84d2dfc988a85b0fbd8ef2b94df commit a9d5a27ad2b3f84d2dfc988a85b0fbd8ef2b94df Author: junov <junov@chromium.org> Date: Fri Oct 07 00:47:34 2016 Tweaking the draw-video-to-hw-accelerated-canvas-2d to stay on GPU This performance test that is meant to draw to a GPU accelerated canvas accidentally changed its behavior due to a recently added heuristic that cancels GPU acceleration under certain circumstances. This CL fixes the test to prevent it from triggering the heuristic. BUG= 653565 Review-Url: https://codereview.chromium.org/2399013003 Cr-Commit-Position: refs/heads/master@{#423767} [modify] https://crrev.com/a9d5a27ad2b3f84d2dfc988a85b0fbd8ef2b94df/third_party/WebKit/PerformanceTests/Canvas/draw-video-to-hw-accelerated-canvas-2d.html
,
Oct 7 2016
,
Oct 7 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/421597d921ce08b8929457de7ac1e8eec09f8f29 commit 421597d921ce08b8929457de7ac1e8eec09f8f29 Author: junov <junov@chromium.org> Date: Fri Oct 07 18:05:03 2016 Tweaks to canvas perf tests to make them stay on the GPU This change applies the same fix as https://codereview.chromium.org/2399013003 to additional tests BUG= 653565 TBR=xidachen@chromium.org Review-Url: https://codereview.chromium.org/2400233002 Cr-Commit-Position: refs/heads/master@{#423910} [modify] https://crrev.com/421597d921ce08b8929457de7ac1e8eec09f8f29/third_party/WebKit/PerformanceTests/Canvas/draw-dynamic-canvas-2d-to-hw-accelerated-canvas-2d.html [modify] https://crrev.com/421597d921ce08b8929457de7ac1e8eec09f8f29/third_party/WebKit/PerformanceTests/Canvas/draw-dynamic-webgl-to-hw-accelerated-canvas-2d.html [modify] https://crrev.com/421597d921ce08b8929457de7ac1e8eec09f8f29/third_party/WebKit/PerformanceTests/Canvas/draw-static-canvas-2d-to-hw-accelerated-canvas-2d.html [modify] https://crrev.com/421597d921ce08b8929457de7ac1e8eec09f8f29/third_party/WebKit/PerformanceTests/Canvas/draw-static-webgl-to-hw-accelerated-canvas-2d.html
,
Oct 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a9d5a27ad2b3f84d2dfc988a85b0fbd8ef2b94df commit a9d5a27ad2b3f84d2dfc988a85b0fbd8ef2b94df Author: junov <junov@chromium.org> Date: Fri Oct 07 00:47:34 2016 Tweaking the draw-video-to-hw-accelerated-canvas-2d to stay on GPU This performance test that is meant to draw to a GPU accelerated canvas accidentally changed its behavior due to a recently added heuristic that cancels GPU acceleration under certain circumstances. This CL fixes the test to prevent it from triggering the heuristic. BUG= 653565 Review-Url: https://codereview.chromium.org/2399013003 Cr-Commit-Position: refs/heads/master@{#423767} [modify] https://crrev.com/a9d5a27ad2b3f84d2dfc988a85b0fbd8ef2b94df/third_party/WebKit/PerformanceTests/Canvas/draw-video-to-hw-accelerated-canvas-2d.html
,
Nov 4 2016
[Automated comment] removing mislabelled merge-merged-2840
,
Nov 11 2016
Friendly perf sheriff ping - any updates?
,
Dec 13 2016
Bugs in the test have been fixed a long time ago. We can close this now. |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by majidvp@google.com
, Oct 6 2016