New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 653565 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Dec 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

34.7%-81.3% regression in blink_perf.canvas at 422775:422899

Project Member Reported by majidvp@google.com, Oct 6 2016

Issue description

See the link to graphs below.
 
Cc: junov@chromium.org
Owner: junov@chromium.org

=== Auto-CCing suspected CL author junov@chromium.org ===

Hi junov@chromium.org, the bisect results pointed to your CL below as possibly
causing a regression. Please have a look at this info and see whether
your CL be related.


===== BISECT JOB RESULTS =====
Status: completed


===== SUSPECTED CL(s) =====
Subject : Disable GPU acceleration on 2D canvas when readbacks are needed
Author  : junov
Commit description:
  
We are already disabling GPU acceleration to avoid readbacks caused
by calls to getImageData. This change applies the same principle
to canvas-to-canvas drawImage calls in order to avoid probable
future readbacks.

BUG= 652126 ,  651517 ,  650116 ,  642539 ,  640144 

Review-Url: https://codereview.chromium.org/2388293002
Cr-Commit-Position: refs/heads/master@{#422848}
Commit  : 2b0d65c9311d7e87784e90d60bfc68efb5f03555
Date    : Tue Oct 04 17:37:58 2016


===== TESTED REVISIONS =====
Revision         Mean     Std Dev  N  Good?
chromium@422823  2423.66  30.5901  5  good
chromium@422837  2530.58  153.751  5  good
chromium@422844  15071.5  28020.4  5  good
chromium@422846  2463.09  165.54   5  good
chromium@422847  2354.47  83.0299  5  good
chromium@422848  1594.9   19.2319  4  bad    <--
chromium@422851  1572.69  34.218   5  bad

Bisect job ran on: mac_10_11_perf_bisect
Bug ID: 653565

Test Command: src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --also-run-disabled-tests blink_perf.canvas
Test Metric: draw-video-to-hw-accelerated-canvas-2d/draw-video-to-hw-accelerated-canvas-2d
Relative Change: 35.11%
Score: 99.9

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/mac_10_11_perf_bisect/builds/949
Job details: https://chromeperf.appspot.com/buildbucket_job_status/8999539141895540720


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5817702025789440

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!

Comment 4 by junov@chromium.org, Oct 6 2016

Status: Started (was: Untriaged)
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 7 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a9d5a27ad2b3f84d2dfc988a85b0fbd8ef2b94df

commit a9d5a27ad2b3f84d2dfc988a85b0fbd8ef2b94df
Author: junov <junov@chromium.org>
Date: Fri Oct 07 00:47:34 2016

Tweaking the draw-video-to-hw-accelerated-canvas-2d to stay on GPU

This performance test that is meant to draw to a GPU accelerated
canvas accidentally changed its behavior due to a recently added
heuristic that cancels GPU acceleration under certain
circumstances. This CL fixes the test to prevent it from triggering
the heuristic.

BUG= 653565 

Review-Url: https://codereview.chromium.org/2399013003
Cr-Commit-Position: refs/heads/master@{#423767}

[modify] https://crrev.com/a9d5a27ad2b3f84d2dfc988a85b0fbd8ef2b94df/third_party/WebKit/PerformanceTests/Canvas/draw-video-to-hw-accelerated-canvas-2d.html

Project Member

Comment 6 by sheriffbot@chromium.org, Oct 7 2016

Labels: Hotlist-Google
Project Member

Comment 8 by bugdroid1@chromium.org, Oct 27 2016

Labels: merge-merged-2840
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a9d5a27ad2b3f84d2dfc988a85b0fbd8ef2b94df

commit a9d5a27ad2b3f84d2dfc988a85b0fbd8ef2b94df
Author: junov <junov@chromium.org>
Date: Fri Oct 07 00:47:34 2016

Tweaking the draw-video-to-hw-accelerated-canvas-2d to stay on GPU

This performance test that is meant to draw to a GPU accelerated
canvas accidentally changed its behavior due to a recently added
heuristic that cancels GPU acceleration under certain
circumstances. This CL fixes the test to prevent it from triggering
the heuristic.

BUG= 653565 

Review-Url: https://codereview.chromium.org/2399013003
Cr-Commit-Position: refs/heads/master@{#423767}

[modify] https://crrev.com/a9d5a27ad2b3f84d2dfc988a85b0fbd8ef2b94df/third_party/WebKit/PerformanceTests/Canvas/draw-video-to-hw-accelerated-canvas-2d.html

Comment 9 by dimu@google.com, Nov 4 2016

Labels: -merge-merged-2840
[Automated comment] removing mislabelled merge-merged-2840
Friendly perf sheriff ping - any updates?

Comment 11 by junov@chromium.org, Dec 13 2016

Status: Fixed (was: Started)
Bugs in the test have been fixed a long time ago. We can close this now.

Sign in to add a comment