New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 653539 link

Starred by 1 user
Status: Fixed
Owner:
se...@chromium.org
Closed: Oct 2016
Cc:
█ zkoch@chromium.org
█ amineer@chromium.org
rouslan@chromium.org
█ kerz@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

Implement journey metrics for Payment Request

Project Member Reported by se...@chromium.org, Oct 6 2016 
Add metrics to record the

number of suggestions shown
number of selection adds
number of selection edits
number of selection change

for 

shipping address
contact info
credit cards

depending on

flow completed
flow aborted by user
glow aborted by other reason

Comment 2 by se...@chromium.org, Oct 8 2016

Cc: zkoch@chromium.org
Labels: Merge-Request-54
Would it be possible to merge these metrics to 54? I know it's a long shot but they would be really useful. Thanks.

Comment 3 by dimu@chromium.org, Oct 8 2016

Labels: -Merge-Request-54 Merge-Review-54 Hotlist-Merge-Review
[Automated comment] Less than 2 weeks to go before stable on M54, manual review required.

Comment 4 by zkoch@chromium.org, Oct 9 2016 

These metrics are really, really critical. Typically we would not try to merge something this late, but these are tied to the company okr, and without them we can't effectively measure it. Dimu, if you have more questions, happy to find time to chat more.

Comment 5 by amineer@chromium.org, Oct 11 2016

Cc: amineer@chromium.org kerz@chromium.org
Not a dimu@ issue since this is Android only.

kerz@, this is ~200 LOC the week before M54 stable release, how would you like to handle this?  I'd reject it wholesale except for the rationale provided by zkoch@ in c#4.

Comment 6 by k...@google.com, Oct 11 2016 

We can't do it, sorry Zach. We've had too many respins to take more risk at this point.

Comment 7 by amineer@chromium.org, Oct 11 2016

Labels: -Merge-Review-54 Merge-Rejected-54

Comment 8 by zkoch@chromium.org, Oct 11 2016 

Got it. Thanks for considering.

Comment 9 by se...@chromium.org, Oct 12 2016

Labels: -M-54 M-55 Merge-Request-55

Comment 10 by dimu@chromium.org, Oct 12 2016

Labels: -Merge-Request-55 Merge-Approved-55 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M55 (branch: 2883)
Project Member

Comment 11 by bugdroid1@chromium.org, Oct 12 2016

Labels: -merge-approved-55 merge-merged-2883
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e19768d80bb5424e7662e88ff6b66bbb2b399cb1

commit e19768d80bb5424e7662e88ff6b66bbb2b399cb1
Author: sebsg <sebsg@chromium.org>
Date: Wed Oct 12 18:14:48 2016

[Payments] Add Payment Request journey metrics.

BUG= 653539 

Review-Url: https://codereview.chromium.org/2396643002
Cr-Commit-Position: refs/heads/master@{#424058}
(cherry picked from commit fed26f3f9b85d8b7234e29b6fa07ef66cde905b7)

Review URL: https://codereview.chromium.org/2405383004 .

Cr-Commit-Position: refs/branch-heads/2883@{#66}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}

[modify] https://crrev.com/e19768d80bb5424e7662e88ff6b66bbb2b399cb1/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java
[add] https://crrev.com/e19768d80bb5424e7662e88ff6b66bbb2b399cb1/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestJourneyLogger.java
[modify] https://crrev.com/e19768d80bb5424e7662e88ff6b66bbb2b399cb1/chrome/android/java_sources.gni
[add] https://crrev.com/e19768d80bb5424e7662e88ff6b66bbb2b399cb1/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestJourneyLoggerTest.java
[modify] https://crrev.com/e19768d80bb5424e7662e88ff6b66bbb2b399cb1/chrome/test/data/android/payments/metrics.js
[modify] https://crrev.com/e19768d80bb5424e7662e88ff6b66bbb2b399cb1/tools/metrics/histograms/histograms.xml

Comment 12 by se...@chromium.org, Oct 12 2016

Status: Fixed (was: Started)
Project Member

Comment 13 by bugdroid1@chromium.org, Oct 27 2016

Labels: merge-merged-2840
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e19768d80bb5424e7662e88ff6b66bbb2b399cb1

commit e19768d80bb5424e7662e88ff6b66bbb2b399cb1
Author: sebsg <sebsg@chromium.org>
Date: Wed Oct 12 18:14:48 2016

[Payments] Add Payment Request journey metrics.

BUG= 653539 

Review-Url: https://codereview.chromium.org/2396643002
Cr-Commit-Position: refs/heads/master@{#424058}
(cherry picked from commit fed26f3f9b85d8b7234e29b6fa07ef66cde905b7)

Review URL: https://codereview.chromium.org/2405383004 .

Cr-Commit-Position: refs/branch-heads/2883@{#66}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}

[modify] https://crrev.com/e19768d80bb5424e7662e88ff6b66bbb2b399cb1/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java
[add] https://crrev.com/e19768d80bb5424e7662e88ff6b66bbb2b399cb1/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestJourneyLogger.java
[modify] https://crrev.com/e19768d80bb5424e7662e88ff6b66bbb2b399cb1/chrome/android/java_sources.gni
[add] https://crrev.com/e19768d80bb5424e7662e88ff6b66bbb2b399cb1/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestJourneyLoggerTest.java
[modify] https://crrev.com/e19768d80bb5424e7662e88ff6b66bbb2b399cb1/chrome/test/data/android/payments/metrics.js
[modify] https://crrev.com/e19768d80bb5424e7662e88ff6b66bbb2b399cb1/tools/metrics/histograms/histograms.xml

Comment 14 by dimu@google.com, Nov 4 2016

Labels: -merge-merged-2840
[Automated comment] removing mislabelled merge-merged-2840
►

Sign in to add a comment