netlog tracing categories doesn't work with startup tracing |
||||||
Issue descriptionTo reproduce this bug: Add "netlog" to page_cycler_v2's tracing config (in https://cs.chromium.org/chromium/src/tools/perf/benchmarks/page_cycler_v2.py?rcl=0&l=29) Run the benchmark with "--output-format=json" to get the trace: ./tools/perf/run_benchmark --browser=default page_cycler_v2.tough_layout_cases --story-filter=bookish --output-format=json Open the trace in tools/perf/http___bookish_com0.html Expect: the trace includes netlog events Actual: there is no netlog events recorded in the trace. After debugging for a while, I figure out that this is because we are using startup tracing. If I run multiple stories in the benchmark & disable "tear down state after each story run", we can get netlog traces in later pages. Zhen: can you look into this bug?
,
Oct 6 2016
Ehsan: you know how netlog is instrumented?
,
Oct 7 2016
,
Oct 7 2016
Net stack events are sent to a netlog. Then netlog sends them to all registered netlog observers. Tracing has a netlog observer (DevTools has another one): https://cs.chromium.org/chromium/src/net/log/trace_net_log_observer.cc
,
Oct 12 2016
,
Oct 14 2016
How is netlog triggered? I noticed that TraceNetLogObserver::OnAddEntry() is only called when using chrome://tracing. When chrome://tracing is not open, that function is not even called.
,
Nov 29 2016
,
Nov 29 2016
lizeb, can you take a look at this? Does anyone know the answer to #6?
,
Nov 30 2016
Re-#6: Are you referring to startup tracing? If so, I believe that's because TraceNetLogObserver::OnTraceLogEnabled() is not called. See crbug.com/668195 for details.
,
Dec 2 2016
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by zh...@chromium.org
, Oct 6 2016