Add authpolicyd package to Chrome OS |
||||||||
Issue description
,
Oct 14 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/a6a894b6c9f50e22d114e25b1580f1bf769a16eb commit a6a894b6c9f50e22d114e25b1580f1bf769a16eb Author: Roman Sorokin <rsorokin@chromium.org> Date: Wed Sep 21 13:36:20 2016 authpolicy: Added authpolicyd boilerplate code BUG= chromium:653509 TEST=emerges. Ad hoc test at runtime with future commits. CQ-DEPEND=CL:394589 Change-Id: I432863d5edfdb729e700a39cacd5d9fc7874f26f Reviewed-on: https://chromium-review.googlesource.com/394646 Commit-Ready: Roman Sorokin <rsorokin@chromium.org> Tested-by: Roman Sorokin <rsorokin@chromium.org> Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by: Roman Sorokin <rsorokin@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [add] https://crrev.com/a6a894b6c9f50e22d114e25b1580f1bf769a16eb/authpolicy/authpolicy.gyp [add] https://crrev.com/a6a894b6c9f50e22d114e25b1580f1bf769a16eb/authpolicy/dbus_bindings/org.chromium.authpolicy.Domain.xml [add] https://crrev.com/a6a894b6c9f50e22d114e25b1580f1bf769a16eb/authpolicy/authpolicy.cc [add] https://crrev.com/a6a894b6c9f50e22d114e25b1580f1bf769a16eb/authpolicy/README.md [add] https://crrev.com/a6a894b6c9f50e22d114e25b1580f1bf769a16eb/authpolicy/etc/dbus-1/org.chromium.authpolicy.conf [add] https://crrev.com/a6a894b6c9f50e22d114e25b1580f1bf769a16eb/authpolicy/OWNERS [add] https://crrev.com/a6a894b6c9f50e22d114e25b1580f1bf769a16eb/authpolicy/etc/init/authpolicyd.conf
,
Oct 18 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/c19c60cfe2b1349b1b7f6dd1142934b15146394f commit c19c60cfe2b1349b1b7f6dd1142934b15146394f Author: Roman Sorokin <rsorokin@chromium.org> Date: Fri Oct 07 13:00:30 2016 Add authpolicy ebuild file TEST=emerges on candy BUG= chromium:653509 CQ-DEPEND=CL:394646 Change-Id: I451d819cb9205d7e050ee9d9192dc8d761342910 Reviewed-on: https://chromium-review.googlesource.com/394667 Commit-Ready: Roman Sorokin <rsorokin@chromium.org> Tested-by: Roman Sorokin <rsorokin@chromium.org> Reviewed-by: Roman Sorokin <rsorokin@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [add] https://crrev.com/c19c60cfe2b1349b1b7f6dd1142934b15146394f/chromeos-base/authpolicy/authpolicy-9999.ebuild
,
Oct 19 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/58805fefd61cd9d9ffc294e9fc4138763390fa0f commit 58805fefd61cd9d9ffc294e9fc4138763390fa0f Author: Lutz Justen <ljusten@chromium.org> Date: Fri Oct 14 15:48:38 2016 Update device policy proto to latest revision Authpolicy will have code that touches every policy. The current proto is missing about 5 policies. Pulled 11 new changes from chromeos/policy/proto.git: 1507842 Protobuf changes to support ARC++ kiosk policy. 1b570f4 kiosk: Add status report for os update and running app by xiyuan 89c836f Device policy for LoginApps. aa46dec Allow SAML logins to use the webcam 68350cb ChromeOS: Add SystemTimezoneAutomaticDetection policy 595f355 Enterprise policy to prevent queries to the Quirks Server 60b86d6 Revert "ChromeOS: Add SystemTimezoneAutomaticDetection policy." 0ee6b2b ChromeOS: Add SystemTimezoneAutomaticDetection policy. 3ab5e71 Remove trailing whitespace in chrome_device_policy.proto. be8cfea Added boolean policy to enable deactivation of bluetooth for managed devices BUG= chromium:653509 TEST=build_packages for amd64-generic and chell, tested with local authpolicy code. Change-Id: I2318c0e652e96c4a9258be7c743699b8e7be271e Reviewed-on: https://chromium-review.googlesource.com/398779 Commit-Ready: Roman Sorokin <rsorokin@chromium.org> Tested-by: Lutz Justen <ljusten@chromium.org> Tested-by: Roman Sorokin <rsorokin@chromium.org> Reviewed-by: Lutz Justen <ljusten@chromium.org> Reviewed-by: Thiemo Nagel <tnagel@chromium.org> Reviewed-by: Roman Sorokin <rsorokin@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [rename] https://crrev.com/58805fefd61cd9d9ffc294e9fc4138763390fa0f/chromeos-base/protofiles/protofiles-0.0.1-r26.ebuild
,
Oct 21 2016
,
Oct 24 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/system_api/+/04ffa5a6f8cc773df1d8cbd4cb136164a9163543 commit 04ffa5a6f8cc773df1d8cbd4cb136164a9163543 Author: Lutz Justen <ljusten@chromium.org> Date: Fri Oct 14 14:15:09 2016 Add authpolicy and login_manager constants Authpolicy service constants are required to communicate with the upcoming authpolicy daemon. The login manager constants refer to two methods that have been implemented in https://chromium-review.googlesource.com/c/397318/. BUG= chromium:653509 TEST=not required, just string additions Change-Id: I1c124e4d48a3ca20ee85ba12dd47a41cbc82b3ba Reviewed-on: https://chromium-review.googlesource.com/398799 Commit-Ready: Lutz Justen <ljusten@chromium.org> Tested-by: Lutz Justen <ljusten@chromium.org> Reviewed-by: Lutz Justen <ljusten@chromium.org> Reviewed-by: Thiemo Nagel <tnagel@chromium.org> Reviewed-by: Roman Sorokin <rsorokin@chromium.org> [add] https://crrev.com/04ffa5a6f8cc773df1d8cbd4cb136164a9163543/dbus/authpolicy/dbus-constants.h [modify] https://crrev.com/04ffa5a6f8cc773df1d8cbd4cb136164a9163543/dbus/service_constants.h [modify] https://crrev.com/04ffa5a6f8cc773df1d8cbd4cb136164a9163543/dbus/login_manager/dbus-constants.h
,
Oct 25 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/5154b0b1a35836498da290e78ec878f8e659b3e5 commit 5154b0b1a35836498da290e78ec878f8e659b3e5 Author: Lutz Justen <ljusten@chromium.org> Date: Fri Oct 21 13:46:09 2016 Adjust authpolicy ebuild file to match naming conventions org.chromium.authpolicy.conf -> org.chromium.AuthPolicy.conf TEST=emerges on candy BUG= chromium:653509 CQ-DEPEND=CL:400761 Change-Id: Ib097f80cd63e91eb8b62aadf32db1e200e4b7bf6 Reviewed-on: https://chromium-review.googlesource.com/400819 Commit-Ready: Lutz Justen <ljusten@chromium.org> Commit-Ready: Roman Sorokin <rsorokin@chromium.org> Tested-by: Lutz Justen <ljusten@chromium.org> Tested-by: Roman Sorokin <rsorokin@chromium.org> Reviewed-by: Lutz Justen <ljusten@chromium.org> Reviewed-by: Roman Sorokin <rsorokin@chromium.org> [modify] https://crrev.com/5154b0b1a35836498da290e78ec878f8e659b3e5/chromeos-base/authpolicy/authpolicy-9999.ebuild
,
Oct 25 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/f5c231f5da9513dc628b03eadd62b1edd9cf971b commit f5c231f5da9513dc628b03eadd62b1edd9cf971b Author: Lutz Justen <ljusten@chromium.org> Date: Mon Oct 24 12:47:57 2016 authpolicy: Adjust dbus service names to match naming conventions org.chromium.authpolicy -> org.chromium.AuthPolicy /org/chromium/authpolicy/Domain -> /org/chromium/AuthPolicy Also renamed method and param names to be more descriptive. TEST=emerges on candy BUG= chromium:653509 CQ-DEPEND=CL:400819 Change-Id: Ic44614730b845788ea712c2d262ea117d958bb15 Reviewed-on: https://chromium-review.googlesource.com/400761 Commit-Ready: Lutz Justen <ljusten@chromium.org> Commit-Ready: Roman Sorokin <rsorokin@chromium.org> Tested-by: Lutz Justen <ljusten@chromium.org> Tested-by: Roman Sorokin <rsorokin@chromium.org> Reviewed-by: Lutz Justen <ljusten@chromium.org> Reviewed-by: Roman Sorokin <rsorokin@chromium.org> [modify] https://crrev.com/f5c231f5da9513dc628b03eadd62b1edd9cf971b/authpolicy/authpolicy.gyp [delete] https://crrev.com/69e84edefb0b98633a2c90df811a67475364fcdc/authpolicy/dbus_bindings/org.chromium.authpolicy.Domain.xml [add] https://crrev.com/f5c231f5da9513dc628b03eadd62b1edd9cf971b/authpolicy/dbus_bindings/org.chromium.AuthPolicy.xml [delete] https://crrev.com/69e84edefb0b98633a2c90df811a67475364fcdc/authpolicy/etc/dbus-1/org.chromium.authpolicy.conf [add] https://crrev.com/f5c231f5da9513dc628b03eadd62b1edd9cf971b/authpolicy/dbus_bindings/dbus-service-config.json [modify] https://crrev.com/f5c231f5da9513dc628b03eadd62b1edd9cf971b/authpolicy/authpolicy.cc [add] https://crrev.com/f5c231f5da9513dc628b03eadd62b1edd9cf971b/authpolicy/etc/dbus-1/org.chromium.AuthPolicy.conf
,
Oct 26 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/b104e436047b43d7d88e18cada35dfbdb914abe0 commit b104e436047b43d7d88e18cada35dfbdb914abe0 Author: Lutz Justen <ljusten@chromium.org> Date: Tue Oct 25 08:36:32 2016 authpolicy: Add policy keys for user and device policy This is a snapshot of Chromium's autogenerated code gen/components/policy/policy_constants.* with everything but the policy keys removed. It will be required for authpolicy to map registry keys to protobuf fields. The code will be auto-generated in the future, see chromium:659020. BUG= chromium:653509 TEST=Emerges. Ad hoc test at runtime with test code (not included). Change-Id: I1120a62c119696d382ce6f72cebd9c1efa9721dd Reviewed-on: https://chromium-review.googlesource.com/402928 Commit-Ready: Roman Sorokin <rsorokin@chromium.org> Tested-by: Roman Sorokin <rsorokin@chromium.org> Reviewed-by: Roman Sorokin <rsorokin@chromium.org> [add] https://crrev.com/b104e436047b43d7d88e18cada35dfbdb914abe0/authpolicy/policy/policy_keys.h [add] https://crrev.com/b104e436047b43d7d88e18cada35dfbdb914abe0/authpolicy/policy/policy_keys.cc [modify] https://crrev.com/b104e436047b43d7d88e18cada35dfbdb914abe0/authpolicy/authpolicy.gyp
,
Oct 28 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/system_api/+/6b679748bee1f2593d523dfb690e1f2d9c982f12 commit 6b679748bee1f2593d523dfb690e1f2d9c982f12 Author: Roman Sorokin <rsorokin@chromium.org> Date: Wed Oct 26 16:44:33 2016 Add error codes for authpolicy This will be used by auth_policy_client on the Chrome side BUG= chromium:653509 TEST=compiles Change-Id: I77c9f0efdb67f8863ccfd0ca4976104396206a31 Reviewed-on: https://chromium-review.googlesource.com/403809 Commit-Ready: Roman Sorokin <rsorokin@chromium.org> Tested-by: Roman Sorokin <rsorokin@chromium.org> Reviewed-by: Dan Erat <derat@chromium.org> [modify] https://crrev.com/6b679748bee1f2593d523dfb690e1f2d9c982f12/dbus/authpolicy/dbus-constants.h
,
Oct 28 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/64308069410ab423223e48c8e78fc665c557d612 commit 64308069410ab423223e48c8e78fc665c557d612 Author: Roman Sorokin <rsorokin@chromium.org> Date: Wed Oct 26 10:40:58 2016 authpolicy: Add persistent directory for the service Add /var/lib/authpolicyd directory for the service. krb5_machine.keytab and smb.conf will be there. All the other files will go into /tmp new mounted on each start. BUG= chromium:653509 TEST=emerges on candy Change-Id: I5fe37058e57d55f4a482c115ee4642315f4e0d71 Reviewed-on: https://chromium-review.googlesource.com/403789 Commit-Ready: Roman Sorokin <rsorokin@chromium.org> Tested-by: Roman Sorokin <rsorokin@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/64308069410ab423223e48c8e78fc665c557d612/authpolicy/etc/init/authpolicyd.conf
,
Oct 28 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/20b2b849cbd90cd1fd42e879203f4bf0269c5183 commit 20b2b849cbd90cd1fd42e879203f4bf0269c5183 Author: Lutz Justen <ljusten@chromium.org> Date: Mon Oct 24 20:23:23 2016 authpolicy: Add preg parser and registry dictionary classes Authpolicyd is going to load Registry.pol (preg) policy files and convert that data into policy protobufs. This CL is a first step. Besides some error codes it contains a preg parser and a registry dictionary class (intermediate storage), which are stripped-down and simplified versions of classes in Chromium (see components/policy/core/common). Notable differences besides different error handling: preg_parser.cc does not use base::i18n::ToLower, but instead the ASCII version. This is sufficient in our case as we control registry keys. Using i18n would have pulled in a significant dependency. registry_dict.cc is the same as the Chromium version with ConvertToJSON and some Windows-specific code removed. BUG= chromium:653509 TEST=Compiles, tested with code not included in this CL. Change-Id: If3afd4615b4ac72d5ca198957001b389f37b20ad Reviewed-on: https://chromium-review.googlesource.com/402448 Commit-Ready: Roman Sorokin <rsorokin@chromium.org> Tested-by: Roman Sorokin <rsorokin@chromium.org> Reviewed-by: Roman Sorokin <rsorokin@chromium.org> [add] https://crrev.com/20b2b849cbd90cd1fd42e879203f4bf0269c5183/authpolicy/policy/registry_dict.h [modify] https://crrev.com/20b2b849cbd90cd1fd42e879203f4bf0269c5183/authpolicy/authpolicy.gyp [add] https://crrev.com/20b2b849cbd90cd1fd42e879203f4bf0269c5183/authpolicy/policy/preg_parser.h [add] https://crrev.com/20b2b849cbd90cd1fd42e879203f4bf0269c5183/authpolicy/policy/preg_parser.cc [add] https://crrev.com/20b2b849cbd90cd1fd42e879203f4bf0269c5183/authpolicy/policy/registry_dict.cc [add] https://crrev.com/20b2b849cbd90cd1fd42e879203f4bf0269c5183/authpolicy/errors.h [add] https://crrev.com/20b2b849cbd90cd1fd42e879203f4bf0269c5183/authpolicy/errors.cc
,
Oct 31 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/26aa436d672b5f9b13c4737d9564c51ec1c5052f commit 26aa436d672b5f9b13c4737d9564c51ec1c5052f Author: Lutz Justen <ljusten@chromium.org> Date: Tue Oct 25 10:04:32 2016 authpolicy: Add cloud policy protobuf This CL adds a snapshot of Chromium's autogenerated user policy protobuf gen/components/policy/proto/cloud_policy.proto as well as gyp code to generate and compile the pb.{h,cc} files. Authpolicyd will use this code to convert preg files into user policy protobufs. Code to autogenerate the proto itself from policy_templates.json will be added in a future CL. chromium:659036 tracks this change. BUG= chromium:653509 TEST=Checked that .pb.* show up and compile. Included pb.h and changed a proto field. Change-Id: I6bb511f4a734b05acc25621643ae5f6e5d7d53e9 Reviewed-on: https://chromium-review.googlesource.com/402988 Commit-Ready: Lutz Justen <ljusten@chromium.org> Tested-by: Roman Sorokin <rsorokin@chromium.org> Reviewed-by: Roman Sorokin <rsorokin@chromium.org> [modify] https://crrev.com/26aa436d672b5f9b13c4737d9564c51ec1c5052f/authpolicy/authpolicy.gyp [add] https://crrev.com/26aa436d672b5f9b13c4737d9564c51ec1c5052f/authpolicy/policy/proto/cloud_policy.proto
,
Oct 31 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/99b6b89e38e05382416242c6acdf2afaadfb4dc3 commit 99b6b89e38e05382416242c6acdf2afaadfb4dc3 Author: Lutz Justen <ljusten@chromium.org> Date: Wed Oct 26 12:40:10 2016 authpolicy: Implement preg->protobuf encoder for user policy Adds code to encode all user policy values inside a registry_dict into a policy protobuf. Authpolicy will use this code to convert preg files into protobufs and send them off to SessionManager. The inc file is a snapshot of autogenerated code. In a future CL, this code will be actually autogenerated in Chromium OS, see chromium:659078. Code requires the 3 CLs below to compile. BUG= chromium:653509 TEST=Emerges. Ad hoc test at runtime with test code (not included). CQ-DEPEND=CL:402448 CQ-DEPEND=CL:402928 CQ-DEPEND=CL:402988 Change-Id: I60927d776fe8697263c5e11dcda773b09f50e121 Reviewed-on: https://chromium-review.googlesource.com/402989 Commit-Ready: Roman Sorokin <rsorokin@chromium.org> Tested-by: Lutz Justen <ljusten@chromium.org> Tested-by: Roman Sorokin <rsorokin@chromium.org> Reviewed-by: Lutz Justen <ljusten@chromium.org> Reviewed-by: Roman Sorokin <rsorokin@chromium.org> [add] https://crrev.com/99b6b89e38e05382416242c6acdf2afaadfb4dc3/authpolicy/policy/preg_policy_encoder.cc [modify] https://crrev.com/99b6b89e38e05382416242c6acdf2afaadfb4dc3/authpolicy/authpolicy.gyp [add] https://crrev.com/99b6b89e38e05382416242c6acdf2afaadfb4dc3/authpolicy/policy/policy_encoder_helper.h [add] https://crrev.com/99b6b89e38e05382416242c6acdf2afaadfb4dc3/authpolicy/policy/user_policy_encoder_gen.cc [add] https://crrev.com/99b6b89e38e05382416242c6acdf2afaadfb4dc3/authpolicy/policy/preg_policy_encoder.h [add] https://crrev.com/99b6b89e38e05382416242c6acdf2afaadfb4dc3/authpolicy/policy/user_policy_encoder.cc [add] https://crrev.com/99b6b89e38e05382416242c6acdf2afaadfb4dc3/authpolicy/policy/user_policy_encoder.h [add] https://crrev.com/99b6b89e38e05382416242c6acdf2afaadfb4dc3/authpolicy/policy/policy_encoder_helper.cc
,
Nov 2 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/ef2765bb87b4ab8593e5ffbc25d2632568099e64 commit ef2765bb87b4ab8593e5ffbc25d2632568099e64 Author: Lutz Justen <ljusten@chromium.org> Date: Wed Oct 26 13:27:54 2016 authpolicy: Implement preg->protobuf encoder for device policy Adds code to encode all device policy values inside a registry_dict into a policy protobuf. Authpolicy will use this code to convert preg files into protobufs and send them off to SessionManager. Unlike for user policy (see CL:402989), for device policy there is no 1:1 mapping between protobuf messages and policies, so the code cannot be autogenerated. However, in almost all cases conversion boils down to the 4 basic data types bool, int, string and string list. There are only a few cases with a non-trivial mapping (see kUsbDetachableWhitelist). Since the device policy proto sits in Chromium and only gets propagated to Chromium OS occasionally (see https://chromium.googlesource.com/chromium/src/chrome/browser/chromeos/policy/proto/), the risk of forgetting to add policies to DevicePolicyEncoder has to be fixed. A future unit test will make sure that all policies are added, see chromium:659101. Code requires the 4 CLs below to compile. BUG= chromium:653509 TEST=Emerges. Tested all trivial and non-trivial mapping cases. CQ-DEPEND=CL:402448 CQ-DEPEND=CL:402928 CQ-DEPEND=CL:402988 CQ-DEPEND=CL:402989 Change-Id: I485508edb447dc492cd7edde7fb8678a651d135b Reviewed-on: https://chromium-review.googlesource.com/403068 Commit-Ready: Lutz Justen <ljusten@chromium.org> Commit-Ready: Roman Sorokin <rsorokin@chromium.org> Tested-by: Lutz Justen <ljusten@chromium.org> Tested-by: Roman Sorokin <rsorokin@chromium.org> Reviewed-by: Lutz Justen <ljusten@chromium.org> Reviewed-by: Roman Sorokin <rsorokin@chromium.org> [add] https://crrev.com/ef2765bb87b4ab8593e5ffbc25d2632568099e64/authpolicy/policy/device_policy_encoder.cc [add] https://crrev.com/ef2765bb87b4ab8593e5ffbc25d2632568099e64/authpolicy/policy/device_policy_encoder.h [modify] https://crrev.com/ef2765bb87b4ab8593e5ffbc25d2632568099e64/authpolicy/policy/preg_policy_encoder.cc [modify] https://crrev.com/ef2765bb87b4ab8593e5ffbc25d2632568099e64/authpolicy/authpolicy.gyp [modify] https://crrev.com/ef2765bb87b4ab8593e5ffbc25d2632568099e64/authpolicy/policy/preg_policy_encoder.h
,
Nov 3 2016
,
Nov 3 2016
,
Nov 8 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/b0f1d2f974675b78f8645e9dac5ad4e91f24810e commit b0f1d2f974675b78f8645e9dac5ad4e91f24810e Author: Lutz Justen <ljusten@chromium.org> Date: Wed Nov 02 08:10:26 2016 authpolicy: Implement daemon and D-Bus interface with Samba stub Provides complete D-Bus interface with two new methods to refresh user and device policy. Separates main/daemon from D-Bus interface implementation and adds Samba interface stub to be implemented in a subsequent CL. The D-Bus methods will be called by Chrome to authenticate, join a device to a AD domain and fetch policy. Code requires the CL below to compile. BUG= chromium:653509 TEST=Emerges. Daemon runs, but just stub code so far. CQ-DEPEND=CL:403068 Change-Id: Ic5eb4621f1c21fccc26e7e3f656b6751fdceba96 Reviewed-on: https://chromium-review.googlesource.com/403872 Commit-Ready: Lutz Justen <ljusten@chromium.org> Tested-by: Lutz Justen <ljusten@chromium.org> Tested-by: Roman Sorokin <rsorokin@chromium.org> Reviewed-by: Lutz Justen <ljusten@chromium.org> Reviewed-by: Roman Sorokin <rsorokin@chromium.org> [modify] https://crrev.com/b0f1d2f974675b78f8645e9dac5ad4e91f24810e/authpolicy/policy/preg_policy_encoder.cc [modify] https://crrev.com/b0f1d2f974675b78f8645e9dac5ad4e91f24810e/authpolicy/authpolicy.gyp [modify] https://crrev.com/b0f1d2f974675b78f8645e9dac5ad4e91f24810e/authpolicy/policy/policy_encoder_helper.h [add] https://crrev.com/b0f1d2f974675b78f8645e9dac5ad4e91f24810e/authpolicy/authpolicy.h [modify] https://crrev.com/b0f1d2f974675b78f8645e9dac5ad4e91f24810e/authpolicy/dbus_bindings/org.chromium.AuthPolicy.xml [modify] https://crrev.com/b0f1d2f974675b78f8645e9dac5ad4e91f24810e/authpolicy/etc/dbus-1/org.chromium.AuthPolicy.conf [modify] https://crrev.com/b0f1d2f974675b78f8645e9dac5ad4e91f24810e/authpolicy/policy/preg_parser.cc [add] https://crrev.com/b0f1d2f974675b78f8645e9dac5ad4e91f24810e/authpolicy/samba_interface.h [modify] https://crrev.com/b0f1d2f974675b78f8645e9dac5ad4e91f24810e/authpolicy/policy/preg_policy_encoder.h [modify] https://crrev.com/b0f1d2f974675b78f8645e9dac5ad4e91f24810e/authpolicy/authpolicy.cc [modify] https://crrev.com/b0f1d2f974675b78f8645e9dac5ad4e91f24810e/authpolicy/errors.h [modify] https://crrev.com/b0f1d2f974675b78f8645e9dac5ad4e91f24810e/authpolicy/policy/policy_encoder_helper.cc [add] https://crrev.com/b0f1d2f974675b78f8645e9dac5ad4e91f24810e/authpolicy/authpolicy_main.cc [modify] https://crrev.com/b0f1d2f974675b78f8645e9dac5ad4e91f24810e/authpolicy/errors.cc [modify] https://crrev.com/b0f1d2f974675b78f8645e9dac5ad4e91f24810e/authpolicy/policy/preg_parser.h
,
Nov 21 2016
I guess this has been done. Can we close the bug?
,
Nov 21 2016
Not yet, samba interface CL is not landed yet
,
Nov 21 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/bc43b28c2c7765140a6a364ab656daa0ddf3ed12 commit bc43b28c2c7765140a6a364ab656daa0ddf3ed12 Author: Lutz Justen <ljusten@chromium.org> Date: Tue Nov 08 16:16:54 2016 authpolicy: Implement samba interface Last missing link for the authpolicy daemon. Implements a couple of samba calls for AD domain joining, user authentication and user/ device policy fetching. The methods are called by the authpolicy dbus interface. The samba interface assumes that certain samba command line tools are installed and accessible. BUG= chromium:653509 TEST=Emerges. Tested daemon with custom test code, works as intended. Change-Id: I37383518dbbbba88552ceac38ff9ea0e150a1355 Reviewed-on: https://chromium-review.googlesource.com/405427 Commit-Ready: Roman Sorokin <rsorokin@chromium.org> Tested-by: Roman Sorokin <rsorokin@chromium.org> Reviewed-by: Roman Sorokin <rsorokin@chromium.org> [modify] https://crrev.com/bc43b28c2c7765140a6a364ab656daa0ddf3ed12/authpolicy/authpolicy.gyp [modify] https://crrev.com/bc43b28c2c7765140a6a364ab656daa0ddf3ed12/authpolicy/authpolicy.h [add] https://crrev.com/bc43b28c2c7765140a6a364ab656daa0ddf3ed12/authpolicy/samba_interface.cc [modify] https://crrev.com/bc43b28c2c7765140a6a364ab656daa0ddf3ed12/authpolicy/samba_interface.h [modify] https://crrev.com/bc43b28c2c7765140a6a364ab656daa0ddf3ed12/authpolicy/authpolicy.cc [modify] https://crrev.com/bc43b28c2c7765140a6a364ab656daa0ddf3ed12/authpolicy/errors.h [modify] https://crrev.com/bc43b28c2c7765140a6a364ab656daa0ddf3ed12/authpolicy/errors.cc
,
Nov 21 2016
Last piece of the puzzle has landed!
,
May 30 2017
,
Jul 6 2017
bulk Verify of older or not-user-facing Chromad bugs |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by bugdroid1@chromium.org
, Oct 11 2016