Unnecessary 'Enable Guest browsing' button is seen in chrome://md-settings, even when option is disabled in chrome://settings.
Reported by
vvishwak...@etouch.net,
Oct 6 2016
|
|||||||||
Issue descriptionVersion: 55.0.2882.0 (Official Build) 03e86d027151639ad79c2074199f4e75beab0674-refs/heads/master@{#423378} (32/64-bit) OS: Windows (7,8,10), Mac (10.10.5, 10.11.4), Linux (14.04 LTS) What steps will reproduce the problem? 1) Launch chrome, go to chrome://settings, in ‘People’ section uncheck ‘Enable Guest browsing’ option. 2) Go to chrome://md-settings, observe bottom of ‘People’ section. ‘Enable guest browsing’ option link is seen even if option is disabled in chrome://settings. ‘Enable guest browsing’ option link should not be seen if option is disabled in chrome://settings. This is a Non-Regression issue seen from M-55 series (Chrome version: 55.0.2876.0) Note: Above option is introduced in chrome://md-settings from #55.0.2876.0
,
Nov 17 2016
,
Nov 17 2016
@tommycli: This is related to issue 665081 which was closed as a duplicate. Even if we don't add the checkbox, the string "Enable guest browsing" is misleading.
,
Nov 17 2016
agree that this is confusing
,
Nov 17 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f657b97e7d7bebd7e37d615c827806fa692b4579 commit f657b97e7d7bebd7e37d615c827806fa692b4579 Author: dbeam <dbeam@chromium.org> Date: Thu Nov 17 19:35:25 2016 MD Settings: drop confusing "Enable guest browsing" secondary text R=tommycli@chromium.org BUG= 653501 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2510953003 Cr-Commit-Position: refs/heads/master@{#432932} [modify] https://crrev.com/f657b97e7d7bebd7e37d615c827806fa692b4579/chrome/app/settings_strings.grdp [modify] https://crrev.com/f657b97e7d7bebd7e37d615c827806fa692b4579/chrome/browser/resources/settings/people_page/people_page.html [modify] https://crrev.com/f657b97e7d7bebd7e37d615c827806fa692b4579/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
,
Nov 17 2016
|
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by tkonch...@chromium.org
, Oct 6 2016