Shouldn't remove Android cache while disk free space > 512MiB after removing other cache |
|||||||||||
Issue descriptionChrome OS Version: ToT This is a follow-up of the change to the disk cleanup threshold: https://bugs.chromium.org/p/chromium/issues/detail?id=533750 https://chromium-review.googlesource.com/#/c/382894/10/cryptohome/homedirs.cc > This makes Android cache to be deleted when < 2GB free space is remaining as opposed to < 1GB before. > Android cache is a bit more precious for the user and on systems with 16GB SSD we're going to hit this condition pretty often. Steps To Reproduce: (1) Make sure the device has any Android Cache. (e.g. use some app which stores visible information to cache but not the storage) (2) Fill the local disk until free space becomes about 1.2GiB. (3) Pin files in Drive whose total size is about 512MiB and unpin them. Confirm free disk space is between 1GiB and 512MiB by "df /home -h" shell command. (4) Reboot and login as another user. Expected Result: The pinned file (gcache) are removed, but Android cache is not removed. The free disk space will be about 1.2GiB. Actual Result: Android cache is also removed. How frequently does this problem reproduce? (Always, sometimes, hard to reproduce?) Always What is the impact to the user, and is there a workaround? If so, what is it? Some Android app may save precious information to the cache. Systems with 16GB SSD will hit this condition pretty often.
,
Oct 6 2016
Actually the original design was meant to be 512MB and the bug is that it was implemented as 1GB, the problem becomes worse with 2GB now https://docs.google.com/document/d/1qiKocLuHOpUEPsKS3ZGvc39ZH5C_tNPUrAVVcbyxabU/edit
,
Oct 6 2016
,
Oct 7 2016
,
Oct 7 2016
We will fix this by treating Android cache in the same way as other users' profiles. (start cleanup at 512MB, after deleting the other caches which are less precious) https://chromium-review.googlesource.com/#/c/394467/
,
Oct 20 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/3b76f73ee92d769a7be4b43a87291179af50e3d3 commit 3b76f73ee92d769a7be4b43a87291179af50e3d3 Author: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Date: Thu Oct 06 08:16:06 2016 cryptohome: Do not delete Android cache while the disk space is > 512MiB. BUG= chromium:653492 ,b:31980295 TEST=unittest for cryptohome. Manual test as described in chromium:653492 . Change-Id: I2a71b47e0548b03c7f8d5ccb9e763e23e39d38b3 Reviewed-on: https://chromium-review.googlesource.com/394608 Commit-Ready: Dan Shi <dshi@google.com> Tested-by: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Reviewed-by: Keigo Oka <oka@chromium.org> Reviewed-by: Junichi Uekawa <uekawa@chromium.org> Reviewed-by: Darren Krahn <dkrahn@chromium.org> [modify] https://crrev.com/3b76f73ee92d769a7be4b43a87291179af50e3d3/cryptohome/homedirs_unittest.cc [modify] https://crrev.com/3b76f73ee92d769a7be4b43a87291179af50e3d3/cryptohome/homedirs.cc
,
Oct 20 2016
,
Oct 21 2016
Your change meets the bar and is auto-approved for M55 (branch: 2883)
,
Oct 24 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/980bf8b4a869ddb1d469aafb9e66a72d8b90ff7c commit 980bf8b4a869ddb1d469aafb9e66a72d8b90ff7c Author: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Date: Thu Oct 06 08:16:06 2016 cryptohome: Do not delete Android cache while the disk space is > 512MiB. BUG= chromium:653492 ,b:31980295 TEST=unittest for cryptohome. Manual test as described in chromium:653492 . Change-Id: I2a71b47e0548b03c7f8d5ccb9e763e23e39d38b3 Reviewed-on: https://chromium-review.googlesource.com/394608 Commit-Ready: Dan Shi <dshi@google.com> Tested-by: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Reviewed-by: Keigo Oka <oka@chromium.org> Reviewed-by: Junichi Uekawa <uekawa@chromium.org> Reviewed-by: Darren Krahn <dkrahn@chromium.org> (cherry picked from commit 3b76f73ee92d769a7be4b43a87291179af50e3d3) Reviewed-on: https://chromium-review.googlesource.com/401249 Reviewed-by: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> [modify] https://crrev.com/980bf8b4a869ddb1d469aafb9e66a72d8b90ff7c/cryptohome/homedirs_unittest.cc [modify] https://crrev.com/980bf8b4a869ddb1d469aafb9e66a72d8b90ff7c/cryptohome/homedirs.cc
,
Oct 24 2016
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 24 2016
The patch 394608 has been merged to branch "release-R55-8872.B" by: https://chromium-review.googlesource.com/#/c/401249/ Removing the Merge-Approved label from this issue per Comment 10.
,
Oct 28 2016
I confirmed the issue reproduced with 55.0.2882.0 / 8872.0.0 and fixed in 8872.25.0 (release branch after the patch applied).
,
Dec 9 2016
ChromeOs 8872.70.0/55.0.2883.87 |
|||||||||||
►
Sign in to add a comment |
|||||||||||
Comment 1 by yamaguchi@chromium.org
, Oct 6 2016