Consider making most accelerators not repeat on OS X to match other platforms |
|||||||
Issue descriptionVersion: 55.0.2881.5 OS: Windows 10, Linux Ubuntu 14.04. What steps will reproduce the problem? (1) Launch chrome and keep the Ctrl++ pressed and observe. What is the expected output? > Page gets zoomed to maximum zoom level(500%), when the Ctrl++ key is pressed. What do you see instead? > Page doesn't get zoom and user has to release the key everytime and zoom to next level. Please use labels and text to provide additional information. > This is working fine on the latest canary(55.0.2882.0) on Mac OS 10.11.6. Regressed in M-55. Last good build: 55.0.2853.0 First bad build: 55.0.2854.2 Changelog: https://chromium.googlesource.com/chromium/src/+log/ee7a59389604bc254617c71ef53aaf0eaf9c7237..42d287c9658c6bfa1202275597f28399409e8603 derat@: Could you please take a look at this issue. Thank you!
,
Oct 12 2016
This still zooms continuously on Mac OS 10.11.6 using the Cmd++. Nothing specific I can think of where I relied on this but shall we have consistency of this across all OS?
,
Oct 12 2016
Yeah, it'd probably make sense to have the same behavior on all platforms (if possible; I don't know anything about how accelerators are implemented on Mac). My change was Views-only. Alex, what do you think?
,
Oct 12 2016
,
Oct 12 2016
,
Nov 17 2016
Able to reproduce this issue on mac 10.11.6 with latest beta 55.0.2883.52. derat@ Could you please look into this issue..
,
Nov 17 2016
There's no need to continue testing this. The behavior on Mac isn't going to change unless someone modifies the code. I've pinged Alex over IM to get his thoughts about whether this is something we should do. Mike, do you have any opinions here? I have no idea how hard this would be to do or if it makes sense.
,
Nov 17 2016
The rest of the Mac platform behaves the way Mac Chrome behaves (in that keeping a modifier key depressed applies to subsequent key presses). We should not be changing this platform behavior simply to align with other platforms. +shrike@ for his opinion and to mark WONTFIX if he agrees.
,
Nov 17 2016
Correct - our menus (where the accelerators live) should continue to work as expected on the Mac, which means key repeat. |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by derat@chromium.org
, Oct 6 2016