Issue 653473 link

Starred by 2 users

Issue metadata

Status:	Fixed
Owner:	█ zqzh...@chromium.org Android MediaRouter only (left Chro...
Closed:	Nov 2016
Cc:	mlamouri@chromium.org ojan@chromium.org
Components:	Blink>Media
EstimatedDays:	----
NextAction:	----
OS:	All
Pri:	2
Type:	Bug
M-57

Avoid using unload listener in AutoplayUmaHelper

Project Member Reported by zqzh...@chromium.org, Oct 6 2016

Issue description

As Ojan pointed, we should avoid using unload listener in AutoplayUmaHelper, because:

1) It slows down navigating away.
2) It is unreliable

Project Member

Comment 1 by bugdroid1@chromium.org, Nov 23 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a93cc968201804405f261ece6fee30b660255ec2

commit a93cc968201804405f261ece6fee30b660255ec2
Author: zqzhang <zqzhang@chromium.org>
Date: Wed Nov 23 22:52:55 2016

Let AutoplayUmaHelper listen to visibilitychange instead of unload

Using window unload listeners is both unreliable and slowing natigating
away. This CL switches the AutoplayUmaHelper to use the page visibility
API instead of listening to window unload event.

BUG= 653473 

Review-Url: https://codereview.chromium.org/2463113002
Cr-Commit-Position: refs/heads/master@{#434272}

[modify] https://crrev.com/a93cc968201804405f261ece6fee30b660255ec2/third_party/WebKit/Source/core/BUILD.gn
[modify] https://crrev.com/a93cc968201804405f261ece6fee30b660255ec2/third_party/WebKit/Source/core/html/AutoplayUmaHelper.cpp
[modify] https://crrev.com/a93cc968201804405f261ece6fee30b660255ec2/third_party/WebKit/Source/core/html/AutoplayUmaHelper.h
[add] https://crrev.com/a93cc968201804405f261ece6fee30b660255ec2/third_party/WebKit/Source/core/html/AutoplayUmaHelperTest.cpp
[modify] https://crrev.com/a93cc968201804405f261ece6fee30b660255ec2/third_party/WebKit/Source/core/html/HTMLMediaElement.h
[modify] https://crrev.com/a93cc968201804405f261ece6fee30b660255ec2/third_party/WebKit/Source/core/html/OWNERS

Comment 2 by zqzh...@chromium.org, Nov 25 2016

Status: Fixed (was: Assigned)

Comment 3 by zqzh...@chromium.org, Nov 25 2016

Labels: -M-56 M-57

►

Issue 653473 link

Issue metadata

Avoid using unload listener in AutoplayUmaHelper

Issue description

Comment 1 by bugdroid1@chromium.org, Nov 23 2016

Comment 1 Deleted

Comment 2 by zqzh...@chromium.org, Nov 25 2016

Comment 2 Deleted

Comment 3 by zqzh...@chromium.org, Nov 25 2016

Comment 3 Deleted

Sign in to add a comment