New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 653454 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Oct 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Crash in getRight

Project Member Reported by ClusterFuzz, Oct 6 2016

Issue description

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=4632576000262144

Fuzzer: libfuzzer_angle_translator_fuzzer
Job Type: libfuzzer_chrome_asan
Platform Id: linux

Crash Type: UNKNOWN READ
Crash Address: 0x000000000088
Crash State:
  getRight
  TLoopIndexInfo::fillInfo
  TLoopInfo
  
Regressed: https://cluster-fuzz.appspot.com/revisions?job=libfuzzer_chrome_asan&range=420334:420440

Minimized Testcase (0.38 Kb): https://cluster-fuzz.appspot.com/download/AMIfv973uQXYLWrvyszYtjip1ryEigS9MWSWb_hMm444MeWOen6xXkvAIftOCl4ECU8hyTvn1-mXgnpeqOO617RHF_q5RSoi75IPpAvA_8OCrSq22F0Kh6b67hCzQ08cXdhvOV7GpZx3FMQ5bUwEgSXjYz99sYyHzQ?testcase_id=4632576000262144

Issue manually filed by: ranjitkan

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reproducing.md for more information.
 
Cc: ranjitkan@chromium.org
Components: Internals>GPU>ANGLE Tools>Test>FindIt>CorrectResult
Labels: -Type-Bug Findit-for-crash M-55 Te-Logged Type-Bug-Regression
Owner: zmo@chromium.org
Status: Assigned (was: Untriaged)
Author: Zhenyao Mo
Project: chromium-angle
Changelist: https://chromium.googlesource.com/angle/angle.git/+/550c600b99d7ee2463e5878d0a9f66ea24c1414a
Time: Wed Feb 26 23:40:48 2014
The CL last changed line 113 of file LoopInfo.cpp, which is stack frame 1.

Author: Zhenyao Mo
Project: chromium-angle
Changelist: https://chromium.googlesource.com/angle/angle.git/+/550c600b99d7ee2463e5878d0a9f66ea24c1414a
Time: Wed Feb 26 23:40:48 2014
The CL last changed line 149 of file LoopInfo.cpp, which is stack frame 2.

Author: Zhenyao Mo
Project: chromium-angle
Changelist: https://chromium.googlesource.com/angle/angle.git/+/550c600b99d7ee2463e5878d0a9f66ea24c1414a
Time: Wed Feb 26 23:40:48 2014
The CL last changed line 203 of file LoopInfo.cpp, which is stack frame 3.

@zmo: Assigning to you, Could you please take a look into it. Please help us to reassign the issue to a right owner if not with respect to your change.

Thanks.!
Cc: zmo@chromium.org jmad...@chromium.org
Owner: cwallez@chromium.org
Corentin, want a look?
Sure
Project Member

Comment 4 by ClusterFuzz, Oct 7 2016

ClusterFuzz has detected this issue as fixed in range 423381:423433.

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=4632576000262144

Fuzzer: libfuzzer_angle_translator_fuzzer
Job Type: libfuzzer_chrome_asan
Platform Id: linux

Crash Type: UNKNOWN READ
Crash Address: 0x000000000088
Crash State:
  getRight
  TLoopIndexInfo::fillInfo
  TLoopInfo
  
Regressed: https://cluster-fuzz.appspot.com/revisions?job=libfuzzer_chrome_asan&range=420334:420440
Fixed: https://cluster-fuzz.appspot.com/revisions?job=libfuzzer_chrome_asan&range=423381:423433

Minimized Testcase (0.38 Kb): https://cluster-fuzz.appspot.com/download/AMIfv973uQXYLWrvyszYtjip1ryEigS9MWSWb_hMm444MeWOen6xXkvAIftOCl4ECU8hyTvn1-mXgnpeqOO617RHF_q5RSoi75IPpAvA_8OCrSq22F0Kh6b67hCzQ08cXdhvOV7GpZx3FMQ5bUwEgSXjYz99sYyHzQ?testcase_id=4632576000262144

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reproducing.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 5 by ClusterFuzz, Oct 7 2016

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase is verified as fixed, closing issue.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 6 by bugdroid1@chromium.org, Oct 19 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/angle/angle/+/b2792db1c73f39e6016e7ee08594471a4f8f0a8a

commit b2792db1c73f39e6016e7ee08594471a4f8f0a8a
Author: Corentin Wallez <cwallez@chromium.org>
Date: Fri Oct 07 15:21:09 2016

translator: Reject invalid combination of compile flags

ADD_AND_TRUE_TO_LOOP_CONDITION breaks loop unrolling because LoopInfo
expects the loop condition to have been validated to be "symbol < constant"
and stayed that way.

BUG= chromium:653454 
BUG= chromium:653694 

Change-Id: I2057fde3a308623bd2dd7571ee878dd42b1fdac3
Reviewed-on: https://chromium-review.googlesource.com/395306
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>

[modify] https://crrev.com/b2792db1c73f39e6016e7ee08594471a4f8f0a8a/src/compiler/translator/Compiler.cpp

Project Member

Comment 7 by bugdroid1@chromium.org, Oct 19 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/angle/angle/+/b2792db1c73f39e6016e7ee08594471a4f8f0a8a

commit b2792db1c73f39e6016e7ee08594471a4f8f0a8a
Author: Corentin Wallez <cwallez@chromium.org>
Date: Fri Oct 07 15:21:09 2016

translator: Reject invalid combination of compile flags

ADD_AND_TRUE_TO_LOOP_CONDITION breaks loop unrolling because LoopInfo
expects the loop condition to have been validated to be "symbol < constant"
and stayed that way.

BUG= chromium:653454 
BUG= chromium:653694 

Change-Id: I2057fde3a308623bd2dd7571ee878dd42b1fdac3
Reviewed-on: https://chromium-review.googlesource.com/395306
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>

[modify] https://crrev.com/b2792db1c73f39e6016e7ee08594471a4f8f0a8a/src/compiler/translator/Compiler.cpp

Project Member

Comment 8 by bugdroid1@chromium.org, Oct 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3cb4b0f4121967b4bb8a244d92d825d4a2b14a60

commit 3cb4b0f4121967b4bb8a244d92d825d4a2b14a60
Author: zmo <zmo@chromium.org>
Date: Sat Oct 22 04:11:33 2016

Roll ANGLE 336b147..f017315

https://chromium.googlesource.com/angle/angle.git/+log/336b147..f017315

BUG= chromium:657859 , chromium:653454 , chromium:653694 , chromium:656485 
TEST=bots
TBR=kbr@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://chromiumcodereview.appspot.com/2442143002
Cr-Commit-Position: refs/heads/master@{#426968}

[modify] https://crrev.com/3cb4b0f4121967b4bb8a244d92d825d4a2b14a60/DEPS
[modify] https://crrev.com/3cb4b0f4121967b4bb8a244d92d825d4a2b14a60/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py

Project Member

Comment 9 by sheriffbot@chromium.org, Nov 22 2016

Labels: -Restrict-View-EditIssue
Removing EditIssue view restrictions from ClusterFuzz filed bugs. If you believe that this issue should still be restricted, please reapply the label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment