New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 653448 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Undefined-shift in WebRtcSpl_FilterAR

Project Member Reported by ClusterFuzz, Oct 6 2016

Issue description

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=4711374741831680

Fuzzer: libfuzzer_neteq_rtp_fuzzer
Job Type: libfuzzer_chrome_ubsan
Platform Id: linux

Crash Type: Undefined-shift
Crash Address: 
Crash State:
  WebRtcSpl_FilterAR
  webrtc::ComfortNoiseDecoder::Generate
  webrtc::ComfortNoise::Generate
  
Regressed: https://cluster-fuzz.appspot.com/revisions?job=libfuzzer_chrome_ubsan&range=423119:423133

Minimized Testcase (0.01 Kb): https://cluster-fuzz.appspot.com/download/AMIfv94aio4GSxo6SBcqUBiwhwd20Gx8x-p66I9ruZZC7KIyspcN99SwmTsXfwv2qdum_HS5A47qwqiyVubKdFh4fh7n7rccHllxAT1qQMg_AqiOXJcTy0mcUxztlaWlK7cSW1p_vmEwmt51WINUd23-8tgQjBsekA?testcase_id=4711374741831680

Issue manually filed by: ranjitkan

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reproducing.md for more information.
 
Cc: ranjitkan@chromium.org
Components: Blink>WebRTC Tools>Test>FindIt>CorrectResult
Labels: -Type-Bug Findit-for-crash M-55 Te-Logged Type-Bug-Regression
Owner: kwiberg@chromium.org
Status: Assigned (was: Untriaged)
Author: kwiberg
Project: chromium-webrtc
Changelist: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+/b9a5d2a304565d81be4a562deabd8397cc9a818a
Time: Tue Oct 04 16:33:27 2016
File neteq_impl.cc is changed in this cl (and is part of stack frame #3, "webrtc::NetEqImpl::DoRfc3389Cng"; frame #4, "webrtc::NetEqImpl::GetAudioInternal"; frame #5, "webrtc::NetEqImpl::GetAudio")
Minimum distance from crash line to modified line: 72. (file: neteq_impl.cc, crashed on: 210, modified: 282).

@kwiberg: Assigning to you, request you to please take a look into it. Please help us to reassign if not with respect to your change.

Thanks.!
I'm not at all sure that that CL is at fault, but I'm a good target for this sort of bug regardless. Thanks.
Cc: hlundin@chromium.org
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 7 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/external/webrtc.git/+/05f3ec1356aa2dc924d8366bd94a0eef0666c30f

commit 05f3ec1356aa2dc924d8366bd94a0eef0666c30f
Author: kwiberg <kwiberg@webrtc.org>
Date: Fri Oct 07 14:38:48 2016

Fix "left shift of negative value" bug

The values in question are supposed to be able to be negative.

BUG= chromium:653448 

Review-Url: https://codereview.webrtc.org/2387333005
Cr-Commit-Position: refs/heads/master@{#14573}

[modify] https://crrev.com/05f3ec1356aa2dc924d8366bd94a0eef0666c30f/webrtc/common_audio/signal_processing/filter_ar.c

Status: Fixed (was: Assigned)
The CL in comment #4 fixes the bug according to my local testing.
Project Member

Comment 6 by ClusterFuzz, Oct 13 2016

ClusterFuzz has detected this issue as fixed in range 424632:424679.

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=4711374741831680

Fuzzer: libfuzzer_neteq_rtp_fuzzer
Job Type: libfuzzer_chrome_ubsan
Platform Id: linux

Crash Type: Undefined-shift
Crash Address: 
Crash State:
  WebRtcSpl_FilterAR
  webrtc::ComfortNoiseDecoder::Generate
  webrtc::ComfortNoise::Generate
  
Regressed: https://cluster-fuzz.appspot.com/revisions?job=libfuzzer_chrome_ubsan&range=423119:423133
Fixed: https://cluster-fuzz.appspot.com/revisions?job=libfuzzer_chrome_ubsan&range=424632:424679

Minimized Testcase (0.01 Kb): https://cluster-fuzz.appspot.com/download/AMIfv94aio4GSxo6SBcqUBiwhwd20Gx8x-p66I9ruZZC7KIyspcN99SwmTsXfwv2qdum_HS5A47qwqiyVubKdFh4fh7n7rccHllxAT1qQMg_AqiOXJcTy0mcUxztlaWlK7cSW1p_vmEwmt51WINUd23-8tgQjBsekA?testcase_id=4711374741831680

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reproducing.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 7 by sheriffbot@chromium.org, Nov 22 2016

Labels: -Restrict-View-EditIssue
Removing EditIssue view restrictions from ClusterFuzz filed bugs. If you believe that this issue should still be restricted, please reapply the label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment