display_low_battery_warning script relying on killall, which is not necessarily installed |
|||
Issue descriptionhttps://chromium-review.googlesource.com/#/c/335584/ introduced this line: killall -9 frecon Unfortunately, killall is only available in dev and test images, but not in release images, so this line isn't effective at all. Note that this can easily be reproduced even on a test/dev image by going through a powerwash: echo "fast keepimg" > /mnt/stateful_partition/factory_install_reset reboot Then: root@localhost ~ # display_low_battery_alert /sbin/display_low_battery_alert: 42: killall: not found frecon still starts as the failing killall invocation is ignored. I suggest adding "set -e" at the beginning of the script to switch the shell to complaining loudly to prevent problems like this going unnoticed.
,
Oct 10 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/13f8c8e5a6bc8d9717fbdb38c2cd4aafd2739329 commit 13f8c8e5a6bc8d9717fbdb38c2cd4aafd2739329 Author: Mattias Nissler <mnissler@chromium.org> Date: Thu Oct 06 11:26:29 2016 init: replace killall with pkill in display_low_battery_alert BUG= chromium:653439 TEST=display_low_battery_alert successfully displays animation Change-Id: I3d8b0f3907b0c35dbd82f85ffd1afbebdcd64cfa Reviewed-on: https://chromium-review.googlesource.com/394547 Commit-Ready: Mattias Nissler <mnissler@chromium.org> Tested-by: Mattias Nissler <mnissler@chromium.org> Reviewed-by: Dominik Behr <dbehr@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/13f8c8e5a6bc8d9717fbdb38c2cd4aafd2739329/init/display_low_battery_alert
,
Oct 26 2016
,
Jan 13 2017
|
|||
►
Sign in to add a comment |
|||
Comment 1 by mnissler@chromium.org
, Oct 6 2016Owner: mnissler@chromium.org
Status: Started (was: Untriaged)