New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 653425 link

Starred by 1 user
Status: Verified
Owner:
steve...@chromium.org
Closed: Jan 2017
Cc:
ajha@chromium.org
█ kavvaru@chromium.org
aashuto...@chromium.org
alemate@chromium.org
█ tienchang@chromium.org
steve...@chromium.org
█ durga.behera@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression

Blocked on:
issue 682344


Sign in to add a comment

Regression: "Connecting message" is not seen while network setup in OOBE screen

Project Member Reported by sandeepkumars@chromium.org, Oct 6 2016 
Version: 55.0.2880.0/8867.0.0 (Official Build) dev-channel gnawty
OS: Chrome

What steps will reproduce the problem?
(1) Recover OS via USB>> go to network setup overlay>> try to connect to the Wifi router which we are using>> give password>> and observe

Expected: After entering password it should show "connecting" while it's getting connected to network
Actual: Now nothing is sowing and connecting to network

This is a Regression issue as it is showing connecting while network setup in M53: 53.0.2785.123/8530.87.0 (Official Build) stable-channel Daisy

@stevenjb: Please confirm the issue

Issue is not applicable to Linux and Windows

Comment 1 by tienchang@chromium.org, Oct 6 2016

Cc: aashuto...@chromium.org tienchang@chromium.org

Comment 2 by zalcorn@chromium.org, Oct 7 2016

Cc: alemate@chromium.org

Comment 3 by steve...@chromium.org, Nov 11 2016 

OOBE issue -> alemate@

Running on desktop in ToT with the MD UI, I see a connection icon, but no connecting text, which is expected in the network list (and seems fine to me).

If we want to show more information about the connected or connecting network, we need to show a separate cr-network-list-item (e.g. above the list) with the is-list-item attribute unset. This will show a more detailed entry, with messages for "connecting", etc.

Comment 4 by steve...@chromium.org, Nov 11 2016

Cc: steve...@chromium.org
Owner: alemate@chromium.org

Comment 5 by bhthompson@google.com, Nov 28 2016 

Any progress on this? We are nearing 55 stable and this is marked as a blocker, if we can get a fix in the next two days we can make the targeted RC, if not we may have to punt or delay.

Comment 6 by alemate@chromium.org, Nov 29 2016 

Is this issue about Material Design OOBE? It is not shipped in M55.
Please, remove RBS and target the issue to M57.

Comment 7 by bhthompson@google.com, Dec 1 2016

Labels: -M-55 -ReleaseBlock-Stable M-57
That would make sense, SGTM.

Comment 8 by steve...@chromium.org, Jan 18 2017

Owner: steve...@chromium.org
Status: Started (was: Assigned)

Comment 9 by steve...@chromium.org, Jan 19 2017 

Issue 682826 has been merged into this issue.
Project Member

Comment 10 by bugdroid1@chromium.org, Jan 21 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ac3b36a8e91405bedccaa90e221b784c26cbadb5

commit ac3b36a8e91405bedccaa90e221b784c26cbadb5
Author: stevenjb <stevenjb@chromium.org>
Date: Sat Jan 21 19:14:34 2017

cr-network-icon: Animate connecting using .svg

BUG= 653425 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2648843002
Cr-Commit-Position: refs/heads/master@{#445291}

[add] https://crrev.com/ac3b36a8e91405bedccaa90e221b784c26cbadb5/ui/webui/resources/cr_elements/network/cellular_0.svg
[add] https://crrev.com/ac3b36a8e91405bedccaa90e221b784c26cbadb5/ui/webui/resources/cr_elements/network/cellular_1.svg
[add] https://crrev.com/ac3b36a8e91405bedccaa90e221b784c26cbadb5/ui/webui/resources/cr_elements/network/cellular_2.svg
[add] https://crrev.com/ac3b36a8e91405bedccaa90e221b784c26cbadb5/ui/webui/resources/cr_elements/network/cellular_3.svg
[add] https://crrev.com/ac3b36a8e91405bedccaa90e221b784c26cbadb5/ui/webui/resources/cr_elements/network/cellular_4.svg
[modify] https://crrev.com/ac3b36a8e91405bedccaa90e221b784c26cbadb5/ui/webui/resources/cr_elements/network/cr_network_icon.html
[modify] https://crrev.com/ac3b36a8e91405bedccaa90e221b784c26cbadb5/ui/webui/resources/cr_elements/network/cr_network_icon.js
[add] https://crrev.com/ac3b36a8e91405bedccaa90e221b784c26cbadb5/ui/webui/resources/cr_elements/network/ethernet.svg
[modify] https://crrev.com/ac3b36a8e91405bedccaa90e221b784c26cbadb5/ui/webui/resources/cr_elements/network/network_icons.html
[add] https://crrev.com/ac3b36a8e91405bedccaa90e221b784c26cbadb5/ui/webui/resources/cr_elements/network/vpn.svg
[add] https://crrev.com/ac3b36a8e91405bedccaa90e221b784c26cbadb5/ui/webui/resources/cr_elements/network/wifi_0.svg
[add] https://crrev.com/ac3b36a8e91405bedccaa90e221b784c26cbadb5/ui/webui/resources/cr_elements/network/wifi_1.svg
[add] https://crrev.com/ac3b36a8e91405bedccaa90e221b784c26cbadb5/ui/webui/resources/cr_elements/network/wifi_2.svg
[add] https://crrev.com/ac3b36a8e91405bedccaa90e221b784c26cbadb5/ui/webui/resources/cr_elements/network/wifi_3.svg
[add] https://crrev.com/ac3b36a8e91405bedccaa90e221b784c26cbadb5/ui/webui/resources/cr_elements/network/wifi_4.svg
[add] https://crrev.com/ac3b36a8e91405bedccaa90e221b784c26cbadb5/ui/webui/resources/cr_elements/network/wifi_off.svg
[add] https://crrev.com/ac3b36a8e91405bedccaa90e221b784c26cbadb5/ui/webui/resources/cr_elements_images.grdp
[modify] https://crrev.com/ac3b36a8e91405bedccaa90e221b784c26cbadb5/ui/webui/resources/webui_resources.grd

Comment 11 by steve...@chromium.org, Jan 23 2017

Labels: Merge-Request-57
Status: Fixed (was: Started)
We should merge this to 57 if we plan to ship MD OOBE in 57.
Project Member

Comment 12 by sheriffbot@chromium.org, Jan 23 2017

Labels: -Merge-Request-57 Hotlist-Merge-Approved Merge-Approved-57
Your change meets the bar and is auto-approved for M57. Please go ahead and merge the CL to branch 2987 manually. Please contact milestone owner if you have questions.
Owners: amineer@(clank), cmasso@(bling), ketakid@(cros), govind@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 13 by steve...@chromium.org, Jan 23 2017

Blockedon: 682344

Comment 14 by steve...@chromium.org, Jan 23 2017 

This actually affects existing Settings UI, so it needs to be merged regardless.
Project Member

Comment 15 by bugdroid1@chromium.org, Jan 23 2017

Labels: -merge-approved-57 merge-merged-2987
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/350420137a8acfcedbffef11149e17221e73d5b9

commit 350420137a8acfcedbffef11149e17221e73d5b9
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Mon Jan 23 19:00:17 2017

cr-network-icon: Animate connecting using .svg

BUG= 653425 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2648843002
Cr-Commit-Position: refs/heads/master@{#445291}
(cherry picked from commit ac3b36a8e91405bedccaa90e221b784c26cbadb5)

Review-Url: https://codereview.chromium.org/2647413002 .
Cr-Commit-Position: refs/branch-heads/2987@{#31}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}

[add] https://crrev.com/350420137a8acfcedbffef11149e17221e73d5b9/ui/webui/resources/cr_elements/network/cellular_0.svg
[add] https://crrev.com/350420137a8acfcedbffef11149e17221e73d5b9/ui/webui/resources/cr_elements/network/cellular_1.svg
[add] https://crrev.com/350420137a8acfcedbffef11149e17221e73d5b9/ui/webui/resources/cr_elements/network/cellular_2.svg
[add] https://crrev.com/350420137a8acfcedbffef11149e17221e73d5b9/ui/webui/resources/cr_elements/network/cellular_3.svg
[add] https://crrev.com/350420137a8acfcedbffef11149e17221e73d5b9/ui/webui/resources/cr_elements/network/cellular_4.svg
[modify] https://crrev.com/350420137a8acfcedbffef11149e17221e73d5b9/ui/webui/resources/cr_elements/network/cr_network_icon.html
[modify] https://crrev.com/350420137a8acfcedbffef11149e17221e73d5b9/ui/webui/resources/cr_elements/network/cr_network_icon.js
[add] https://crrev.com/350420137a8acfcedbffef11149e17221e73d5b9/ui/webui/resources/cr_elements/network/ethernet.svg
[modify] https://crrev.com/350420137a8acfcedbffef11149e17221e73d5b9/ui/webui/resources/cr_elements/network/network_icons.html
[add] https://crrev.com/350420137a8acfcedbffef11149e17221e73d5b9/ui/webui/resources/cr_elements/network/vpn.svg
[add] https://crrev.com/350420137a8acfcedbffef11149e17221e73d5b9/ui/webui/resources/cr_elements/network/wifi_0.svg
[add] https://crrev.com/350420137a8acfcedbffef11149e17221e73d5b9/ui/webui/resources/cr_elements/network/wifi_1.svg
[add] https://crrev.com/350420137a8acfcedbffef11149e17221e73d5b9/ui/webui/resources/cr_elements/network/wifi_2.svg
[add] https://crrev.com/350420137a8acfcedbffef11149e17221e73d5b9/ui/webui/resources/cr_elements/network/wifi_3.svg
[add] https://crrev.com/350420137a8acfcedbffef11149e17221e73d5b9/ui/webui/resources/cr_elements/network/wifi_4.svg
[add] https://crrev.com/350420137a8acfcedbffef11149e17221e73d5b9/ui/webui/resources/cr_elements/network/wifi_off.svg
[add] https://crrev.com/350420137a8acfcedbffef11149e17221e73d5b9/ui/webui/resources/cr_elements_images.grdp
[modify] https://crrev.com/350420137a8acfcedbffef11149e17221e73d5b9/ui/webui/resources/webui_resources.grd

Comment 16 by rookrishna@chromium.org, Mar 1 2017

Status: Verified (was: Fixed)
►

Sign in to add a comment