New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 653423 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: Nov 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

get sysmon to use the chromite virtualenv, in the normal manner

Project Member Reported by akes...@chromium.org, Oct 6 2016

Issue description

sysmon rolled its own virtualenv bootstrapping code. Let's reuse the normal chromite code for this.
 
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 6 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/b7c117b43e3369a770039e8e38f0d5c29d4a53af

commit b7c117b43e3369a770039e8e38f0d5c29d4a53af
Author: Aviv Keshet <akeshet@chromium.org>
Date: Thu Oct 06 08:22:50 2016

venv: add sysmon's requirements

CQ-DEPEND=CL:394269
BUG= chromium:653423 
TEST=create_env.sh

Change-Id: Icac3c3b2b107c041e9656001d9cc7fe646201f81
Reviewed-on: https://chromium-review.googlesource.com/394251
Tested-by: Aviv Keshet <akeshet@chromium.org>
Trybot-Ready: Aviv Keshet <akeshet@chromium.org>
Reviewed-by: Allen Li <ayatane@chromium.org>

[modify] https://crrev.com/b7c117b43e3369a770039e8e38f0d5c29d4a53af/venv/requirements.txt

Project Member

Comment 4 by bugdroid1@chromium.org, Oct 6 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/b4d1887d4f84bd601fc4ac63e321a29821b41597

commit b4d1887d4f84bd601fc4ac63e321a29821b41597
Author: Aviv Keshet <akeshet@chromium.org>
Date: Thu Oct 06 08:43:38 2016

sysmon: use the chromite virtualenv

BUG= chromium:653423 
TEST=None

Change-Id: I2618602b67ee9b52835714820efc52f559cc765d
Reviewed-on: https://chromium-review.googlesource.com/394252
Tested-by: Aviv Keshet <akeshet@chromium.org>
Trybot-Ready: Aviv Keshet <akeshet@chromium.org>
Reviewed-by: Allen Li <ayatane@chromium.org>

[modify] https://crrev.com/b4d1887d4f84bd601fc4ac63e321a29821b41597/bin/sysmon

Project Member

Comment 5 by bugdroid1@chromium.org, Oct 7 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/b68c5590b1a24fe16fa76a21071eb7e24150f301

commit b68c5590b1a24fe16fa76a21071eb7e24150f301
Author: Allen Li <ayatane@chromium.org>
Date: Thu Oct 06 22:48:58 2016

Remove sysmon's venv wrapper

BUG= chromium:653423 ,chromium:621741
TEST=Run sysmon on test drone

Change-Id: Ib9fb1f2c472b36424e87d54dbbae720b0cbec951
Reviewed-on: https://chromium-review.googlesource.com/394946
Commit-Ready: Aviv Keshet <akeshet@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Aviv Keshet <akeshet@chromium.org>

[delete] https://crrev.com/8e389b691751f6650d1350ab5dbd977409bd2e35/bin/run_sysmon.sh
[modify] https://crrev.com/b68c5590b1a24fe16fa76a21071eb7e24150f301/venv/create_env.sh

Project Member

Comment 6 by bugdroid1@chromium.org, Oct 7 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/chromeos-admin/+/66104e664b293d11dcec50a8b4ad95bdf4bcc9f4

commit 66104e664b293d11dcec50a8b4ad95bdf4bcc9f4
Author: Allen Li <ayatane@chromium.org>
Date: Thu Oct 06 22:33:44 2016

Comment 7 by autumn@chromium.org, Oct 11 2016

Labels: -current-issue
Owner: ayatane@chromium.org
Status: Fixed (was: Untriaged)
Fixed as far as I know.

Comment 9 by dchan@google.com, Jan 21 2017

Labels: VerifyIn-57

Comment 10 by dchan@google.com, Mar 4 2017

Labels: VerifyIn-58

Comment 11 by dchan@google.com, Apr 17 2017

Labels: VerifyIn-59

Comment 12 by dchan@google.com, May 30 2017

Labels: VerifyIn-60
Labels: VerifyIn-61

Comment 14 by dchan@chromium.org, Oct 14 2017

Status: Archived (was: Fixed)

Sign in to add a comment