Regression : In 'Add search engine' overlay, default focus is not seen on first text field for emulated page.
Reported by
yfulgaon...@etouch.net,
Oct 6 2016
|
||||||||||||
Issue descriptionChrome Version : 55.0.2882.0 (Official Build) 03e86d027151639ad79c2074199f4e75beab0674-refs/heads/master@{#423378} (32/64-bit) OS: Mac(10.10.5)(10.11.5), Windows(7,8,8.1,10), Linux(14.04 LTS) What steps will reproduce the problem? 1. Launch chrome, navigate to chrome://md-settings page, scroll down the page and click on ‘Manage Search Engines’. 2. Open devtools, click on ‘Toggle device toolbar’ button and resize the emulated page towards RHS (please refer an attached screen cast) 3. Now click on ‘Add search engine’ button and observe the blue focus highlight in ‘Add search engine’ overlay. Actual : After step 3, default focus is not seen on ’Search engine’ text field. (Instead, the default focus shifts to the next ‘text field’ in an overlay) Expected : After step 3, default focus should stay on ’Search engine’ text field and should not shift to another text field. This is a regression issue broken in ‘M-55’, below is the Manual Regression and will soon update bisect info. Good build : 55.0.2846.0 Bad build : 55.0.2847.0
,
Oct 18 2016
Updating the latest behavior of the bug, Issue is still repro on chrome latest Dev M56-56.0.2894.0. pilgrim@ Could you please let us know is there any latest update on this bug ? Please feel free to reassign to the concerned Dev person if it's not related your change. Thanks!
,
Oct 18 2016
Seems unrelated; my CL was a small refactor with no functional changes.
,
Oct 25 2016
,
Nov 2 2016
As per comment #3 performed re bisect and got a different change log as a suspect. You are probably looking for a change made after 416116 (known good), but no later than 416117 (first known bad). CHANGELOG URL: ----------------- https://chromium.googlesource.com/chromium/src/+log/8ad01a3783fd1655ef91b93a62fb854951ba5e16..05b5db68bf23918ab865837f1720525e11f3c72f From the CL above, assigning the issue to the concern owner @dschuyler - Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. Thanks!
,
Nov 2 2016
Hector, I only lightly read this bug and it seemed related to focus/highlight and I thought of you. If this is not something you are looking into, feel free to send it back to me.
,
Nov 17 2016
,
Dec 2 2016
With response to comment #7 Able to reproduce issue on latest Mac, Windows 57.0.2939.0 canary build. @jmukthavaram : In step 2, click on ‘Toggle device toolbar’ button so that page gets emulated and follow the rest of the steps. In your video, the page is not emulated hence you couldn't reproduce the original issue. Please review an attached screen cast for the reference. Thank you!
,
Dec 2 2016
Issue is caused because end of the tap event will focus what is underneath it, even if focus changes during the event handling. Calling |preventDefault| should fix this. See: https://github.com/Polymer/polymer/issues/4185
,
Dec 5 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ddbf37a7628ba691536fd980951f84d7a3a86864 commit ddbf37a7628ba691536fd980951f84d7a3a86864 Author: hcarmona <hcarmona@chromium.org> Date: Mon Dec 05 17:51:11 2016 Prevent default on tap when showing the credit card or address dialog. The on-tap event will focus whatever is underneath the tap event when it finishes. Calling |preventDefault| on the event prevents this default action. See https://github.com/Polymer/polymer/issues/4185 for details. BUG= 653415 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2534313007 Cr-Commit-Position: refs/heads/master@{#436341} [modify] https://crrev.com/ddbf37a7628ba691536fd980951f84d7a3a86864/chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.js
,
Dec 5 2016
From code review: This can happen in multiple places in the code. A quick search found 31 dialogs within settings: https://cs.chromium.org/search/?q=is%3D%5C%22cr-dialog%5C%22+file:settings&sq=package:chromium&type=cs These dialogs are affected by the same issue if they are shown in an 'on-tap' event. The above CL has fixed addresses and credit cards, but does not fix every other dialog that is shown.
,
Dec 8 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6083648a5b1e07dbda893e897d574e28292aff6d commit 6083648a5b1e07dbda893e897d574e28292aff6d Author: hcarmona <hcarmona@chromium.org> Date: Thu Dec 08 22:42:07 2016 Call preventDefault in all on-tap events that show a dialog. BUG= 653415 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2557073003 Cr-Commit-Position: refs/heads/master@{#437374} [modify] https://crrev.com/6083648a5b1e07dbda893e897d574e28292aff6d/chrome/browser/resources/settings/about_page/detailed_build_info.js [modify] https://crrev.com/6083648a5b1e07dbda893e897d574e28292aff6d/chrome/browser/resources/settings/bluetooth_page/bluetooth_page.js [modify] https://crrev.com/6083648a5b1e07dbda893e897d574e28292aff6d/chrome/browser/resources/settings/device_page/display.js [modify] https://crrev.com/6083648a5b1e07dbda893e897d574e28292aff6d/chrome/browser/resources/settings/device_page/storage.js [modify] https://crrev.com/6083648a5b1e07dbda893e897d574e28292aff6d/chrome/browser/resources/settings/internet_page/network_siminfo.js [modify] https://crrev.com/6083648a5b1e07dbda893e897d574e28292aff6d/chrome/browser/resources/settings/languages_page/languages_page.js [modify] https://crrev.com/6083648a5b1e07dbda893e897d574e28292aff6d/chrome/browser/resources/settings/on_startup_page/startup_url_entry.js [modify] https://crrev.com/6083648a5b1e07dbda893e897d574e28292aff6d/chrome/browser/resources/settings/on_startup_page/startup_urls_page.js [modify] https://crrev.com/6083648a5b1e07dbda893e897d574e28292aff6d/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.js [modify] https://crrev.com/6083648a5b1e07dbda893e897d574e28292aff6d/chrome/browser/resources/settings/people_page/easy_unlock_turn_off_dialog.js [modify] https://crrev.com/6083648a5b1e07dbda893e897d574e28292aff6d/chrome/browser/resources/settings/people_page/lock_screen.js [modify] https://crrev.com/6083648a5b1e07dbda893e897d574e28292aff6d/chrome/browser/resources/settings/people_page/people_page.js [modify] https://crrev.com/6083648a5b1e07dbda893e897d574e28292aff6d/chrome/browser/resources/settings/people_page/users_page.js [modify] https://crrev.com/6083648a5b1e07dbda893e897d574e28292aff6d/chrome/browser/resources/settings/reset_page/reset_page.js [modify] https://crrev.com/6083648a5b1e07dbda893e897d574e28292aff6d/chrome/browser/resources/settings/reset_page/reset_profile_banner.js [modify] https://crrev.com/6083648a5b1e07dbda893e897d574e28292aff6d/chrome/browser/resources/settings/search_engines_page/search_engine_entry.js [modify] https://crrev.com/6083648a5b1e07dbda893e897d574e28292aff6d/chrome/browser/resources/settings/search_engines_page/search_engines_page.js [modify] https://crrev.com/6083648a5b1e07dbda893e897d574e28292aff6d/chrome/browser/resources/settings/site_settings/site_data.js [modify] https://crrev.com/6083648a5b1e07dbda893e897d574e28292aff6d/chrome/browser/resources/settings/site_settings/site_details.js [modify] https://crrev.com/6083648a5b1e07dbda893e897d574e28292aff6d/chrome/browser/resources/settings/site_settings/site_list.js
,
Dec 9 2016
This should be fixed in all dialogs that are shown after a tap event. |
||||||||||||
►
Sign in to add a comment |
||||||||||||
Comment 1 by brajkumar@chromium.org
, Oct 6 2016Owner: pilgrim@chromium.org
Status: Assigned (was: Unconfirmed)