New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 653414 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Oct 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Regression : Unnecessary language paper menu closes on check/uncheck 'Offer to translate pages in this language' option in chrome://md-settings page.

Reported by mni...@etouch.net, Oct 6 2016

Issue description

Version: 55.0.2882.0 03e86d027151639ad79c2074199f4e75beab0674-refs/heads/master@{#423378} (32/64-bit)
OS: Windows (7,8,8.1,10),Linux (14.04 LTS),Mac OS X(10.10.5, 10.11.4)

What steps will reproduce the problem?
1. Launch chrome and navigate to chrome://md-settings/languages
2. Now add any language and click on its iron icon.
3. Now click on check/uncheck 'Offer to translate pages in this language' and observe

Actual: Unnecessary language paper menu closes on check/uncheck 'Offer to translate pages in this language' option
Expected: Language paper menu should not close on check/uncheck 'Offer to translate pages in this language' option

This is regression issue, broken in ‘M 55’ and below is manual regression and will soon update other info
Good build : 55.0.2873.0
Bad build : 55.0.2875.0

 
Actual_video.mov
1.6 MB Download
Expected_video.mov
1.8 MB Download
Cc: brajkumar@chromium.org
Labels: hasbisect-per-revision
Owner: michae...@chromium.org
Status: Assigned (was: Unconfirmed)
Using the per-revision bisect providing the bisect results,
Good build:55.0.2873.0(Revision: 421052).
Bad build: 55.0.2875.0 (Revision:421703).

You are probably looking for a change made after 421694 (known good), but no later than 421695 (first known bad).

CHANGELOG URL:
-----------------   https://chromium.googlesource.com/chromium/src/+log/ff30596cef625e4438c6875f7273d5f323367389..e11da429912fdbd07dfda4ebafec78fcc2163c58

From the CL above, assigning the issue to the concern owner 

@michaelpg - Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Review-Url: https://codereview.chromium.org/2359353002

Thanks!
Cc: michae...@chromium.org
Labels: OS-Chrome
Owner: bettes@chromium.org
bettes: Is this WAI?

The Language overflow menus have regular menu items (Remove, Move to top, etc.) and checkbox items. When you tap a regular menu item, it takes the action and closes the menu. When you tap a checkbox item, it's the same: the checkbox becomes checked or unchecked and the menu animates closed immediately.

Should we keep the menu open after tapping a checkbox item? So the user would have to tap outside of the menu, or type Escape, to close it?

Comment 3 by bettes@chromium.org, Oct 10 2016

This is WAI. Having extra clicks between setting your OS language and restarting should be minimal. 
Status: WontFix (was: Assigned)
closing as its WAI.

Sign in to add a comment