New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 653398 link

Starred by 1 user
Status: Fixed
Owner:
calamity@chromium.org
Closed: Jan 2017
Cc:
nyerramilli@chromium.org
█ tkonch...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: [MD History] Unable to keep focus on link using 'Tab' key under 'Tabs from other devices' section.

Reported by dchau...@etouch.net, Oct 6 2016 
Chrome Version: 55.0.2882.0 (Official Build) 03e86d027151639ad79c2074199f4e75beab0674-refs/heads/master@{#423378} 32/64/bit.
OS: Windows(7,8,10), Mac(10.10.5, 10.11.4), Linux(14.04 LTS).

What steps will reproduce the problem?
1. Launch chrome and sign in to chrome with such accounts in which browsing history from other devices are synced.
2. Navigate to chrome://history page and go to 'Tabs from other devices' section.
3. Now, multiple times press 'Tab' from keyboard and observe the focus.

On pressing the 'Tab' key, Focus doesn't navigate through link.
On pressing the 'Tab' key, Focus should navigate through link.

This is a regression issue, broken in M-55 series, will soon update other info.

Comment 1 by dchau...@etouch.net, Oct 6 2016

Owner: calamity@chromium.org
Status: Assigned (was: Unconfirmed)
Note: On pressing 'Tab' key, at-least focus should complete the one cycle as the history list i.e. focus should traverse through URL also.

Manual regression range.

Good build: 55.0.2880.0
Bad build: 55.0.2882.0

Unable to sign in to chromium build, hence unable to narrow down it. hence providing change log URL.
Change Log URL:
https://chromium.googlesource.com/chromium/src/+log/55.0.2880.0..55.0.2882.0?pretty=fuller&n=10000

Suspecting: r423090

Kindly review the attached screen-cast for reference.
Actual behavior.mp4
815 KB View Download
Expected behavior.mp4
576 KB View Download

Comment 2 by dchau...@etouch.net, Oct 6 2016

Labels: hasbisect

Comment 3 by tsergeant@chromium.org, Oct 6 2016

Labels: Proj-MaterialDesign-WebUI
This is currently working as intended -- R423090 replaces tab navigation through the list with keyboard arrow navigation.

I understand that this is kinda confusing that tab doesn't let you reach any of the links (unlike the main page), but I don't think it needs to block our launch in M55.
Project Member

Comment 4 by bugdroid1@chromium.org, Jan 6 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a4ecd5b7dee7b4ea7444dee445f9757a34d43564

commit a4ecd5b7dee7b4ea7444dee445f9757a34d43564
Author: calamity <calamity@chromium.org>
Date: Fri Jan 06 05:52:44 2017

[MD History] Make first URL on Synced Device page instead of menu button.

BUG= 653398 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2618633002
Cr-Commit-Position: refs/heads/master@{#441884}

[modify] https://crrev.com/a4ecd5b7dee7b4ea7444dee445f9757a34d43564/chrome/browser/resources/md_history/lazy_load.crisper.js
[modify] https://crrev.com/a4ecd5b7dee7b4ea7444dee445f9757a34d43564/chrome/browser/resources/md_history/synced_device_manager.js
[modify] https://crrev.com/a4ecd5b7dee7b4ea7444dee445f9757a34d43564/ui/webui/resources/js/cr/ui/focus_grid.js

Comment 5 by calamity@chromium.org, Jan 9 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment