Find in page keeps matching invisible things |
||||
Issue description1. Install Rietveld Usability Toolkit: https://chrome.google.com/webstore/detail/rietveld-usability-toolki/nmljjlfbnbekmadhbpfpkcminoejelga 2. Navigate to https://codereview.chromium.org/2397963002/ 3. Click "All 4" on Patchset 5. This opens the diffs between PS4 and PS5. 4. Search for the string "can't outdent". There are two results. 5. Click "All 2" on Patchset 5. This opens the diffs between PS2 and PS5. Expected: Find-in-page should report 4 matches after step 5. Actual: Find-in-page reports 6 matches. In addition, when going through the results, match 1 and match 2 are nowhere to be seen: they're matches from the original frame that's how hidden.
,
Oct 6 2016
This is probably from https://codereview.chromium.org/2384483004
,
Oct 6 2016
I can repro the same result in stable 53, so I don't think this is due to https://codereview.chromium.org/2384483004. I'll look into this.
,
Oct 6 2016
Tried the same thing as far back as Chrome 43 with the same result. Looks like this has always been the behavior of find-in-page (or at least for a long time). If the extension actually removed the frame, then the results would be automatically subtracted from the find bar (new behavior as of my recent patch), but since the frame remains but its content is simply hidden, the matches remain on the page and continue to be counted in the find bar (same behavior as always).
,
Oct 17 2017
,
Sep 13
Archiving old bugs that haven't been actively assigned in over 180 days. If you feel this issue should still be addressed, feel free to reopen it or to file a new issue. Thanks! |
||||
►
Sign in to add a comment |
||||
Comment 1 by dcheng@chromium.org
, Oct 6 2016