New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 653373 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Feature



Sign in to add a comment

Migrate instant search to Mojo

Project Member Reported by tibell@chromium.org, Oct 6 2016

Issue description

As part of migrating everything to Mojo we need to migrate the instant search messages.

 

Comment 1 by treib@chromium.org, Oct 6 2016

Cc: treib@chromium.org
Components: UI>Browser>NewTabPage Internals>Mojo UI>Browser>Instant
Labels: OS-Chrome OS-Linux OS-Mac OS-Windows
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e3df8cd8ac45539711b1f0b6a00420f87d09d279

commit e3df8cd8ac45539711b1f0b6a00420f87d09d279
Author: tibell <tibell@chromium.org>
Date: Mon Jan 16 03:21:15 2017

Convert instant search messages to Mojo

Instead of mirroring browser state into a RenderViewObserver we use a RenderFrameObserver on the main frame. This is because Mojo, by design, doesn't communicate with RenderViews. Also, the data is eventually used from the main frame.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
BUG= 653373 

Review-Url: https://codereview.chromium.org/2086223002
Cr-Commit-Position: refs/heads/master@{#443838}

[modify] https://crrev.com/e3df8cd8ac45539711b1f0b6a00420f87d09d279/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/e3df8cd8ac45539711b1f0b6a00420f87d09d279/chrome/browser/ui/search/instant_search_prerenderer_unittest.cc
[modify] https://crrev.com/e3df8cd8ac45539711b1f0b6a00420f87d09d279/chrome/browser/ui/search/instant_tab_unittest.cc
[modify] https://crrev.com/e3df8cd8ac45539711b1f0b6a00420f87d09d279/chrome/browser/ui/search/search_ipc_router.cc
[modify] https://crrev.com/e3df8cd8ac45539711b1f0b6a00420f87d09d279/chrome/browser/ui/search/search_ipc_router.h
[modify] https://crrev.com/e3df8cd8ac45539711b1f0b6a00420f87d09d279/chrome/browser/ui/search/search_ipc_router_policy_unittest.cc
[modify] https://crrev.com/e3df8cd8ac45539711b1f0b6a00420f87d09d279/chrome/browser/ui/search/search_ipc_router_unittest.cc
[modify] https://crrev.com/e3df8cd8ac45539711b1f0b6a00420f87d09d279/chrome/browser/ui/search/search_tab_helper.h
[modify] https://crrev.com/e3df8cd8ac45539711b1f0b6a00420f87d09d279/chrome/browser/ui/search/search_tab_helper_unittest.cc
[modify] https://crrev.com/e3df8cd8ac45539711b1f0b6a00420f87d09d279/chrome/common/BUILD.gn
[add] https://crrev.com/e3df8cd8ac45539711b1f0b6a00420f87d09d279/chrome/common/instant.mojom
[add] https://crrev.com/e3df8cd8ac45539711b1f0b6a00420f87d09d279/chrome/common/instant.typemap
[add] https://crrev.com/e3df8cd8ac45539711b1f0b6a00420f87d09d279/chrome/common/instant_type_traits.h
[modify] https://crrev.com/e3df8cd8ac45539711b1f0b6a00420f87d09d279/chrome/common/render_messages.h
[add] https://crrev.com/e3df8cd8ac45539711b1f0b6a00420f87d09d279/chrome/common/search/mock_searchbox.cc
[add] https://crrev.com/e3df8cd8ac45539711b1f0b6a00420f87d09d279/chrome/common/search/mock_searchbox.h
[modify] https://crrev.com/e3df8cd8ac45539711b1f0b6a00420f87d09d279/chrome/renderer/BUILD.gn
[modify] https://crrev.com/e3df8cd8ac45539711b1f0b6a00420f87d09d279/chrome/renderer/chrome_content_renderer_client.cc
[modify] https://crrev.com/e3df8cd8ac45539711b1f0b6a00420f87d09d279/chrome/renderer/searchbox/searchbox.cc
[modify] https://crrev.com/e3df8cd8ac45539711b1f0b6a00420f87d09d279/chrome/renderer/searchbox/searchbox.h
[modify] https://crrev.com/e3df8cd8ac45539711b1f0b6a00420f87d09d279/chrome/renderer/searchbox/searchbox_extension.cc
[modify] https://crrev.com/e3df8cd8ac45539711b1f0b6a00420f87d09d279/chrome/test/BUILD.gn
[add] https://crrev.com/e3df8cd8ac45539711b1f0b6a00420f87d09d279/chrome/typemaps.gni
[modify] https://crrev.com/e3df8cd8ac45539711b1f0b6a00420f87d09d279/content/browser/frame_host/render_frame_host_impl.cc
[modify] https://crrev.com/e3df8cd8ac45539711b1f0b6a00420f87d09d279/content/public/test/mock_render_process_host.cc
[modify] https://crrev.com/e3df8cd8ac45539711b1f0b6a00420f87d09d279/content/renderer/screen_orientation/screen_orientation_dispatcher_browsertest.cc
[modify] https://crrev.com/e3df8cd8ac45539711b1f0b6a00420f87d09d279/mojo/public/cpp/bindings/associated_interface_ptr.h
[modify] https://crrev.com/e3df8cd8ac45539711b1f0b6a00420f87d09d279/mojo/public/tools/bindings/chromium_bindings_configuration.gni

Project Member

Comment 4 by bugdroid1@chromium.org, Feb 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2e6a9ebbc75837e1f7986ecc7f16e5d59d70299a

commit 2e6a9ebbc75837e1f7986ecc7f16e5d59d70299a
Author: tibell <tibell@chromium.org>
Date: Fri Feb 24 00:12:16 2017

NTP: simplify mojo connection setup

Both the browser (SearchIPCRouter) and the frame (SearchBox) needs to be able to
be able to send messages to the other side (i.e. using mojo methods with replies
is not enough). Previously this was achieved by having each side separate
creating a connection to the other. Now only the frame initiates the connection,
passing an interface to the browser which the browser can use to talk back to
the frame. This removes complicated frame connection logic on the browser side.

BUG= 653373 

Review-Url: https://codereview.chromium.org/2688453002
Cr-Commit-Position: refs/heads/master@{#452684}

[modify] https://crrev.com/2e6a9ebbc75837e1f7986ecc7f16e5d59d70299a/chrome/browser/ui/search/search_ipc_router.cc
[modify] https://crrev.com/2e6a9ebbc75837e1f7986ecc7f16e5d59d70299a/chrome/browser/ui/search/search_ipc_router.h
[modify] https://crrev.com/2e6a9ebbc75837e1f7986ecc7f16e5d59d70299a/chrome/browser/ui/search/search_ipc_router_unittest.cc
[modify] https://crrev.com/2e6a9ebbc75837e1f7986ecc7f16e5d59d70299a/chrome/common/instant.mojom
[modify] https://crrev.com/2e6a9ebbc75837e1f7986ecc7f16e5d59d70299a/chrome/renderer/searchbox/searchbox.cc

Comment 5 by tibell@chromium.org, Feb 24 2017

Status: Fixed (was: Started)

Sign in to add a comment