We should be able to run LayerTreeTests with the cc/blimp glue code that forms the transition layer between the two.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/de2a7ec4f13720cdd0854f18adc4634d5d660e65 commit de2a7ec4f13720cdd0854f18adc4634d5d660e65 Author: khushalsagar <khushalsagar@chromium.org> Date: Thu Oct 06 18:48:21 2016 cc/blimp: Remove remenants of the old setup from LayerTreeTests Remove the old setup code for LayerTreeTests. None of the tests use them so a trivial change. BUG= 653371 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Review-Url: https://codereview.chromium.org/2398933002 Cr-Commit-Position: refs/heads/master@{#423606} [modify] https://crrev.com/de2a7ec4f13720cdd0854f18adc4634d5d660e65/cc/test/layer_tree_test.cc [modify] https://crrev.com/de2a7ec4f13720cdd0854f18adc4634d5d660e65/cc/test/layer_tree_test.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/20d374bbeeefaf135d66038d43ceacbfaef9c9e4 commit 20d374bbeeefaf135d66038d43ceacbfaef9c9e4 Author: khushalsagar <khushalsagar@chromium.org> Date: Thu Oct 06 23:20:11 2016 cc: Restructure access to LayerTreeHost in LayerTreeTests. Move tests to depends on the LayerTreeHost, instead of the InProcess subclass, in preparation of setting up the framework to have tests run in remote mode. There is still an accessor for LayerTreeHostInProcess, only it DCHECKS that the test is running in threaded or single-threaded mode. BUG= 653371 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Review-Url: https://codereview.chromium.org/2400733002 Cr-Commit-Position: refs/heads/master@{#423727} [modify] https://crrev.com/20d374bbeeefaf135d66038d43ceacbfaef9c9e4/cc/test/layer_tree_test.cc [modify] https://crrev.com/20d374bbeeefaf135d66038d43ceacbfaef9c9e4/cc/test/layer_tree_test.h [modify] https://crrev.com/20d374bbeeefaf135d66038d43ceacbfaef9c9e4/cc/trees/layer_tree_host_unittest.cc [modify] https://crrev.com/20d374bbeeefaf135d66038d43ceacbfaef9c9e4/cc/trees/layer_tree_host_unittest_animation.cc
Issue 577937 has been merged into this issue.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/04b10facfd83a405009f155cb58b7d7732d52f43 commit 04b10facfd83a405009f155cb58b7d7732d52f43 Author: khushalsagar <khushalsagar@chromium.org> Date: Tue Oct 11 00:19:44 2016 cc/blimp: Set up the framework for LayerTreeTests in remote mode. This sets up the LayerTreeHostRemoteForTesting class which can be used to mock out the external transport between the RemoteCompositorBridge on the engine and LayerTreeHostInProcess on the client. The class implements a simple binding layer that passes through state updates between these 2. BUG= 653371 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Review-Url: https://codereview.chromium.org/2401703002 Cr-Commit-Position: refs/heads/master@{#424299} [modify] https://crrev.com/04b10facfd83a405009f155cb58b7d7732d52f43/cc/BUILD.gn [modify] https://crrev.com/04b10facfd83a405009f155cb58b7d7732d52f43/cc/blimp/layer_tree_host_remote.cc [modify] https://crrev.com/04b10facfd83a405009f155cb58b7d7732d52f43/cc/blimp/layer_tree_host_remote.h [add] https://crrev.com/04b10facfd83a405009f155cb58b7d7732d52f43/cc/test/layer_tree_host_remote_for_testing.cc [add] https://crrev.com/04b10facfd83a405009f155cb58b7d7732d52f43/cc/test/layer_tree_host_remote_for_testing.h [modify] https://crrev.com/04b10facfd83a405009f155cb58b7d7732d52f43/cc/test/layer_tree_test.cc [modify] https://crrev.com/04b10facfd83a405009f155cb58b7d7732d52f43/cc/test/layer_tree_test.h [modify] https://crrev.com/04b10facfd83a405009f155cb58b7d7732d52f43/cc/trees/layer_tree_host_unittest.cc [modify] https://crrev.com/04b10facfd83a405009f155cb58b7d7732d52f43/cc/trees/layer_tree_host_unittest_proxy.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1f3826f1afa9948747c198f8da4444956677f0f2 commit 1f3826f1afa9948747c198f8da4444956677f0f2 Author: khushalsagar <khushalsagar@chromium.org> Date: Thu Oct 13 21:38:26 2016 cc/blimp: Set up hooks for scroll/scale sync. Sets up a hook on the RemoteCompositorBridgeClient to pipe scroll/scale updates from the client and apply to the LayerTreeHostClient. Also sets up proxying of these through the LayerTreeHostRemoteForTesting for LayerTreeTests. BUG= 653371 , 648442 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Review-Url: https://codereview.chromium.org/2404953002 Cr-Commit-Position: refs/heads/master@{#425172} [modify] https://crrev.com/1f3826f1afa9948747c198f8da4444956677f0f2/cc/blimp/layer_tree_host_remote.cc [modify] https://crrev.com/1f3826f1afa9948747c198f8da4444956677f0f2/cc/blimp/layer_tree_host_remote.h [modify] https://crrev.com/1f3826f1afa9948747c198f8da4444956677f0f2/cc/blimp/layer_tree_host_remote_unittest.cc [modify] https://crrev.com/1f3826f1afa9948747c198f8da4444956677f0f2/cc/blimp/remote_compositor_bridge_client.h [modify] https://crrev.com/1f3826f1afa9948747c198f8da4444956677f0f2/cc/test/fake_remote_compositor_bridge.h [modify] https://crrev.com/1f3826f1afa9948747c198f8da4444956677f0f2/cc/test/layer_tree_host_remote_for_testing.cc [modify] https://crrev.com/1f3826f1afa9948747c198f8da4444956677f0f2/cc/test/layer_tree_host_remote_for_testing.h [modify] https://crrev.com/1f3826f1afa9948747c198f8da4444956677f0f2/cc/test/layer_tree_test.h [modify] https://crrev.com/1f3826f1afa9948747c198f8da4444956677f0f2/cc/trees/layer_tree_host_unittest_scroll.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0f6110c8db6415566429f9c99c9e3544e8be82e7 commit 0f6110c8db6415566429f9c99c9e3544e8be82e7 Author: xingliu <xingliu@chromium.org> Date: Tue Oct 18 21:15:58 2016 Enable some remote LTH tests in layer_tree_host_unittests. For Blimp we added LayerTreeHostRemote on the engine side, and setup the test structure to reuse the cc unittests for LTH remote. This CL went through around 20 tests in layer_tree_host_unittests. BUG= 653371 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Review-Url: https://codereview.chromium.org/2416273002 Cr-Commit-Position: refs/heads/master@{#426046} [modify] https://crrev.com/0f6110c8db6415566429f9c99c9e3544e8be82e7/cc/test/layer_tree_host_remote_for_testing.cc [modify] https://crrev.com/0f6110c8db6415566429f9c99c9e3544e8be82e7/cc/test/layer_tree_host_remote_for_testing.h [modify] https://crrev.com/0f6110c8db6415566429f9c99c9e3544e8be82e7/cc/trees/layer_tree_host_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3c9b4cc4fe631cec765af7dca9ce4c4c2b7e064d commit 3c9b4cc4fe631cec765af7dca9ce4c4c2b7e064d Author: xingliu <xingliu@chromium.org> Date: Wed Nov 02 20:52:55 2016 Enable more cc unit tests for LayerTreeHostRemote test. We have added test classes for LayerTreeHostRemote for Blimp and would like to reuse cc unit tests to test the following flow: Engine cc ==> Client cc main thread ==> Client cc impl thread. This CL goes through about 50 unit test cases in layer_tree_host_unittest.cc. BUG= 653371 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Review-Url: https://codereview.chromium.org/2456093003 Cr-Commit-Position: refs/heads/master@{#429396} [modify] https://crrev.com/3c9b4cc4fe631cec765af7dca9ce4c4c2b7e064d/cc/BUILD.gn [modify] https://crrev.com/3c9b4cc4fe631cec765af7dca9ce4c4c2b7e064d/cc/blimp/compositor_state_deserializer.cc [modify] https://crrev.com/3c9b4cc4fe631cec765af7dca9ce4c4c2b7e064d/cc/blimp/layer_factory.h [modify] https://crrev.com/3c9b4cc4fe631cec765af7dca9ce4c4c2b7e064d/cc/blimp/layer_tree_host_remote.cc [modify] https://crrev.com/3c9b4cc4fe631cec765af7dca9ce4c4c2b7e064d/cc/blimp/layer_tree_host_remote_unittest.cc [modify] https://crrev.com/3c9b4cc4fe631cec765af7dca9ce4c4c2b7e064d/cc/layers/layer.h [modify] https://crrev.com/3c9b4cc4fe631cec765af7dca9ce4c4c2b7e064d/cc/layers/layer_proto_converter.cc [modify] https://crrev.com/3c9b4cc4fe631cec765af7dca9ce4c4c2b7e064d/cc/proto/layer.proto [add] https://crrev.com/3c9b4cc4fe631cec765af7dca9ce4c4c2b7e064d/cc/test/push_properties_counting_layer.cc [add] https://crrev.com/3c9b4cc4fe631cec765af7dca9ce4c4c2b7e064d/cc/test/push_properties_counting_layer.h [add] https://crrev.com/3c9b4cc4fe631cec765af7dca9ce4c4c2b7e064d/cc/test/push_properties_counting_layer_impl.cc [add] https://crrev.com/3c9b4cc4fe631cec765af7dca9ce4c4c2b7e064d/cc/test/push_properties_counting_layer_impl.h [modify] https://crrev.com/3c9b4cc4fe631cec765af7dca9ce4c4c2b7e064d/cc/test/remote_client_layer_factory.cc [modify] https://crrev.com/3c9b4cc4fe631cec765af7dca9ce4c4c2b7e064d/cc/test/remote_client_layer_factory.h [modify] https://crrev.com/3c9b4cc4fe631cec765af7dca9ce4c4c2b7e064d/cc/trees/layer_tree_host_unittest.cc
Comment 1 by bugdroid1@chromium.org
, Oct 6 2016