New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 653368 link

Starred by 0 users

Issue metadata

Status: Archived
Owner:
Closed: Dec 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug

Blocking:
issue 652169



Sign in to add a comment

touch /var/tmp/provision_failed should be the first action in provision flow

Project Member Reported by akes...@chromium.org, Oct 6 2016

Issue description

We have some forms of provision failure that are not triggering appropriate repair actions, because the failure occurs before touching the /var/tmp/provision_failed file.

(for instance, looking at the log, it seems like we copy stateful payload and try to run the devserver on DUT before we touch this file; failures in those steps due to bad state on the DUT will not get properly repaired)

We should move this to be the vert first action performed in the autoupdate.
 
Labels: -Pri-2 Pri-1
The relevant code seems to be in src/platform/dev/cros_update.py:184
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 7 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/dev-util/+/fdfd1e37ae81f0283ecfaabcb738a54c5d5b0c68

commit fdfd1e37ae81f0283ecfaabcb738a54c5d5b0c68
Author: xixuan <xixuan@chromium.org>
Date: Thu Oct 06 21:55:17 2016

Devserver: make touch provision_failed as the first action in provision

This CL make 'touch /var/tmp/provision_failed' as the first action in CrOS
Auto-Update flow.

BUG= chromium:653368 
TEST=Run repair in local autotest.

Change-Id: I29a47ac4735ad559f1fff5133d1efabe9aa5e435
Reviewed-on: https://chromium-review.googlesource.com/394888
Commit-Ready: Aviv Keshet <akeshet@chromium.org>
Tested-by: Aviv Keshet <akeshet@chromium.org>
Reviewed-by: Aviv Keshet <akeshet@chromium.org>

[modify] https://crrev.com/fdfd1e37ae81f0283ecfaabcb738a54c5d5b0c68/cros_update.py

Comment 4 by autumn@chromium.org, Oct 11 2016

Labels: -current-issue
Status: Fixed (was: Untriaged)

Comment 6 by dchan@google.com, Mar 4 2017

Labels: VerifyIn-58

Comment 7 by dchan@google.com, Apr 17 2017

Labels: VerifyIn-59

Comment 8 by dchan@google.com, May 30 2017

Labels: VerifyIn-60

Comment 9 by dchan@chromium.org, Aug 1 2017

Labels: VerifyIn-61

Comment 10 by dchan@chromium.org, Oct 14 2017

Status: Archived (was: Fixed)

Sign in to add a comment