Shows only one credential in account chooser when id is duplicate |
|||||||||
Issue descriptionVersion: Chrome Version 55.0.2881.0 canary (64-bit) OS: Mac OS X What steps will reproduce the problem? (1) Go to https://credential-management-sample.appspot.com/ (2) Sign up using Google Sign-In (3) Sign up using *the same gmail address as above* with password (4) Click on "Sign In" button and see what will show up What is the expected output? 2 accounts What do you see instead? only 1 account Please use labels and text to provide additional information.
,
Oct 6 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/641e5161d080e498899a4758608febdeba45e64c commit 641e5161d080e498899a4758608febdeba45e64c Author: vasilii <vasilii@chromium.org> Date: Thu Oct 06 18:07:11 2016 Don't filter the federated credentials in the account chooser. The filtering was introduced in https://codereview.chromium.org/2277793002 BUG= 653364 Review-Url: https://codereview.chromium.org/2398863003 Cr-Commit-Position: refs/heads/master@{#423588} [modify] https://crrev.com/641e5161d080e498899a4758608febdeba45e64c/components/password_manager/content/browser/credential_manager_impl_unittest.cc [modify] https://crrev.com/641e5161d080e498899a4758608febdeba45e64c/components/password_manager/core/browser/credential_manager_pending_request_task.cc
,
Oct 7 2016
,
Oct 10 2016
Tried a verification of this as per the test steps mentioned in C#0 on Mac OS 10.11.6, chrome version:55.0.2883.6, enabling credential management API flag. Still showing only one account in Account chooser dialog as per the test followed from the attached screen-cast. vasilii@: Could you please review the attached screen-cast and confirm if anything being missed there in the repro steps.
,
Oct 10 2016
You don't need to enable the API. It's enabled by default. You didn't save the second credential. You need to click "Sign in with Google" and use the same email. When you have two credentials in chrome://settings/passwords then you can check the account chooser.
,
Oct 10 2016
Confirmed it works when I save with 1. Google Sign-In 2. id/password both using the same gmail address. But also confirmed that opposite order won't work. 1. id/password 2. Google Sign-In
,
Oct 10 2016
What doesn't work? Do you have both credentials saved?
,
Oct 10 2016
1. Google Sign-In 2. id/password Will show both credentials in the user mediation bubble, but 1. id/password 2. Google Sign-In Will only show 1 and 2 is not shown despite I've confirmed to store it.
,
Oct 10 2016
I reproduced it but the case is that the second credential isn't saved. Can you check on chrome://settings/passwords?
,
Oct 11 2016
The bug is in PasswordFormManager::CreatePendingCredentials. FindBestSavedMatch returns the existing credential and the password manager tries to update it.
,
Oct 13 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f0afbfdae3929aa90e5ef611f02cd2f81e6ebdff commit f0afbfdae3929aa90e5ef611f02cd2f81e6ebdff Author: vasilii <vasilii@chromium.org> Date: Thu Oct 13 14:04:56 2016 CM API: disallow a federated credential to update a password credential. BUG= 653364 Review-Url: https://codereview.chromium.org/2416783002 Cr-Commit-Position: refs/heads/master@{#425017} [modify] https://crrev.com/f0afbfdae3929aa90e5ef611f02cd2f81e6ebdff/components/password_manager/content/browser/credential_manager_impl_unittest.cc [modify] https://crrev.com/f0afbfdae3929aa90e5ef611f02cd2f81e6ebdff/components/password_manager/core/browser/password_form_manager.cc
,
Oct 18 2016
,
Oct 18 2016
Your change meets the bar and is auto-approved for M55 (branch: 2883)
,
Oct 19 2016
Isn't it merged in https://codereview.chromium.org/2425243002/ ?
,
Oct 19 2016
,
Oct 24 2016
,
Oct 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/641e5161d080e498899a4758608febdeba45e64c commit 641e5161d080e498899a4758608febdeba45e64c Author: vasilii <vasilii@chromium.org> Date: Thu Oct 06 18:07:11 2016 Don't filter the federated credentials in the account chooser. The filtering was introduced in https://codereview.chromium.org/2277793002 BUG= 653364 Review-Url: https://codereview.chromium.org/2398863003 Cr-Commit-Position: refs/heads/master@{#423588} [modify] https://crrev.com/641e5161d080e498899a4758608febdeba45e64c/components/password_manager/content/browser/credential_manager_impl_unittest.cc [modify] https://crrev.com/641e5161d080e498899a4758608febdeba45e64c/components/password_manager/core/browser/credential_manager_pending_request_task.cc
,
Oct 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4e78201c38098209d4a2c9b559cbdc0704e625b2 commit 4e78201c38098209d4a2c9b559cbdc0704e625b2 Author: Vasilii Sukhanov <vasilii@chromium.org> Date: Tue Oct 18 13:09:04 2016 CM API: disallow a federated credential to update a password credential. BUG= 653364 Review-Url: https://codereview.chromium.org/2416783002 Cr-Commit-Position: refs/heads/master@{#425017} (cherry picked from commit f0afbfdae3929aa90e5ef611f02cd2f81e6ebdff) Review URL: https://codereview.chromium.org/2425243002 . Cr-Commit-Position: refs/branch-heads/2883@{#173} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} [modify] https://crrev.com/4e78201c38098209d4a2c9b559cbdc0704e625b2/components/password_manager/content/browser/credential_manager_impl_unittest.cc [modify] https://crrev.com/4e78201c38098209d4a2c9b559cbdc0704e625b2/components/password_manager/core/browser/password_form_manager.cc
,
Nov 4 2016
[Automated comment] removing mislabelled merge-merged-2840 |
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by vasi...@chromium.org
, Oct 6 2016Status: Started (was: Untriaged)