New issue
Advanced search Search tips

Issue 653354 link

Starred by 1 user

Issue metadata

Status: Started
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

Remove |was_fetched_via_proxy| from HttpResponseInfo object

Project Member Reported by tbansal@chromium.org, Oct 6 2016

Issue description

Remove |was_fetched_via_proxy| from HttpResponseInfo object.

Currently, HttpResponseInfo stores ProxyServer as a net::HostPortPair object. That makes it necessary to include a separate boolean |was_fetched_via_proxy| to distinguish between the case where the resource was fetched through a DIRECT proxy vs. an invalid proxy.

Once https://bugs.chromium.org/p/chromium/issues/detail?id=646197 is fixed, HttpResponseInfo will store ProxyServer as a net::ProxyServer object. That will make it unnecessary to include the boolean variable |was_fetched_via_proxy|, and so it should be removed.

 
Components: Internals>Network>Proxy
Owner: ----
Status: Available (was: Started)
Cc: mmenke@chromium.org
Owner: tfarina@chromium.org
Status: Assigned (was: Available)
I think I can do this.
Status: Started (was: Assigned)
I have uploaded my try on https://chromium-review.googlesource.com/c/517942/.

Sign in to add a comment