New issue
Advanced search Search tips

Issue 653339 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2016
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Allow the number of days between ignoring/dismissing banners to be controlled

Project Member Reported by dominickn@chromium.org, Oct 6 2016

Issue description

This should be controllable via variations.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 6 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9c6743858ca3e02015f13239045f4d80c47e33aa

commit 9c6743858ca3e02015f13239045f4d80c47e33aa
Author: dominickn <dominickn@chromium.org>
Date: Thu Oct 06 20:51:36 2016

Allow variations controls for the time banners are suppressed after ignore/dismiss.

This CL implements variations querying and control for the number of
days after an app banner is dismissed or ignored that the banner will
not be shown for that site.

BUG= 653339 

Review-Url: https://codereview.chromium.org/2397043002
Cr-Commit-Position: refs/heads/master@{#423667}

[modify] https://crrev.com/9c6743858ca3e02015f13239045f4d80c47e33aa/chrome/browser/banners/app_banner_settings_helper.cc
[modify] https://crrev.com/9c6743858ca3e02015f13239045f4d80c47e33aa/chrome/browser/banners/app_banner_settings_helper.h
[modify] https://crrev.com/9c6743858ca3e02015f13239045f4d80c47e33aa/chrome/browser/banners/app_banner_settings_helper_unittest.cc

Status: Fixed (was: Started)
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 27 2016

Labels: merge-merged-2840
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9c6743858ca3e02015f13239045f4d80c47e33aa

commit 9c6743858ca3e02015f13239045f4d80c47e33aa
Author: dominickn <dominickn@chromium.org>
Date: Thu Oct 06 20:51:36 2016

Allow variations controls for the time banners are suppressed after ignore/dismiss.

This CL implements variations querying and control for the number of
days after an app banner is dismissed or ignored that the banner will
not be shown for that site.

BUG= 653339 

Review-Url: https://codereview.chromium.org/2397043002
Cr-Commit-Position: refs/heads/master@{#423667}

[modify] https://crrev.com/9c6743858ca3e02015f13239045f4d80c47e33aa/chrome/browser/banners/app_banner_settings_helper.cc
[modify] https://crrev.com/9c6743858ca3e02015f13239045f4d80c47e33aa/chrome/browser/banners/app_banner_settings_helper.h
[modify] https://crrev.com/9c6743858ca3e02015f13239045f4d80c47e33aa/chrome/browser/banners/app_banner_settings_helper_unittest.cc

Comment 4 by dimu@google.com, Nov 4 2016

Labels: -merge-merged-2840
[Automated comment] removing mislabelled merge-merged-2840

Sign in to add a comment