I don't think I agree with this; it would be unexpected to have high contrast non-toggleable while inside of Google Docs and also, to have it fail unexpectedly on some pages that happen to listen for ctrl alt h. Let's just pick another shortcut.

This is marked as a beta blocker for R55 and we are coming up on beta, has work begun on this?

Should this still be a beta blocker?

It looks like the preferred fix won't be easy to merge, so I will most likely revert the patch and merge the revert to M-55 before beta.

I'll try to get a final decision by the end of the day.

Cool thanks, we are planning to build our beta RC Monday evening, so if we can get this in place by Monday afternoon that would be perfect.

Any update on using the revert here?

 Issue 652119  has been merged into this issue.

No consensus yet so I'm reverting now and will try to aim for M56 instead.

https://codereview.chromium.org/2443303002/

Could I have merge approval for the revert?

https://codereview.chromium.org/2448663002/

Can you merge this into 55?

This was already merged to M55, not sure why the bug didn't get updated.


Committed patchset #1 (id:1) manually as
e951a87b4b5f7f553e1f1dfb678bddce6665be12.

Description:
Merge to M55: Revert of Add Ctrl+Alt+H as global shortcut to toggle high
contrast mode. (patchset #2 id:20001 of
https://codereview.chromium.org/2352213002/ )

Reason for revert:
 http://crbug.com/653330  This shortcut
conflicts with some web pages, and there's
no consensus on the proper fix (let web pages
override, or switch to another key).

Original issue's description:
> Add Ctrl+Alt+H as global shortcut to toggle high contrast mode.
>
> BUG= 644758 
>
> Committed: https://crrev.com/6750eab17b2f45449fab74543ff2fdbcdc122a4e
> Cr-Commit-Position: refs/heads/master@{#419884}

TBR=jamescook@chromium.org,mpearson@chromium.org,suppasitaung6@gmail.com
BUG= 644758 

Review-Url: https://codereview.chromium.org/2448663002
Cr-Commit-Position: refs/heads/master@{#427293}
(cherry picked from commit bebe8961758cd40f8abeead4d96ab0d0a9f1628b)

Committed:
https://chromium.googlesource.com/chromium/src/+/e951a87b4b5f7f553e1f1dfb678bddce6665be12