New issue
Advanced search Search tips

Issue 653317 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2016
Components:
EstimatedDays: ----
NextAction: 2016-11-21
OS: ----
Pri: 2
Type: Feature

Blocking:
issue 419413



Sign in to add a comment

bluetooth: web: Remove BluetoothDevice.uuids attribute.

Project Member Reported by scheib@chromium.org, Oct 5 2016

Issue description

Specification has removed uuids attribute:
https://github.com/WebBluetoothCG/web-bluetooth/pull/292

The BluetoothDevice.uuids attribute is deprecated now and user will get a deprecation message when using it. The remaining work is to completely remove this attribute after the M56 branch.
 
Owner: juncai@chromium.org
Status: Started (was: Available)

Comment 3 by juncai@chromium.org, Oct 12 2016

Status: Fixed (was: Started)
Blocking: -436283 419413
Labels: M-57
NextAction: 2016-11-21
Status: Assigned (was: Fixed)
This issue still needs more work, but not until after the M56 branch.
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6da1894febdd92cc6308fd75af89c336b244e2da

commit 6da1894febdd92cc6308fd75af89c336b244e2da
Author: juncai <juncai@chromium.org>
Date: Thu Oct 13 22:07:56 2016

Add BluetoothDevice.uuids attribute removal date in the deprecation string

This CL adds the removal date in the deprecation string for the
BluetoothDevice.uuids attribute.

BUG= 653317 

Review-Url: https://codereview.chromium.org/2412753003
Cr-Commit-Position: refs/heads/master@{#425181}

[modify] https://crrev.com/6da1894febdd92cc6308fd75af89c336b244e2da/third_party/WebKit/Source/core/frame/Deprecation.cpp

Comment 6 by scheib@chromium.org, Oct 15 2016

juncai, please update the issue description (see "Edit description") describing the remaining work.

Comment 7 by juncai@chromium.org, Oct 17 2016

Description: Show this description

Comment 8 by juncai@chromium.org, Oct 17 2016

Description updated. Thanks!
Project Member

Comment 9 by bugdroid1@chromium.org, Oct 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/45d0b0cfd7fe1493719a5c9e757d620b19bbf52d

commit 45d0b0cfd7fe1493719a5c9e757d620b19bbf52d
Author: juncai <juncai@chromium.org>
Date: Thu Oct 27 03:44:54 2016

Remove BluetoothDevice.uuids attribute from WebBluetooth

The BluetoothDevice.uuids attribute is removed from the WebBluetooth
spec, this CL removes the BluetoothDevice.uuids attribute and updates
related test code.

It was marked Deprecated for a brief time, but because
Web Bluetooth is moving out of experimental / origin trial
and shipping we will make the clean break without
maintaining the deprecated API in the shipped state.

BUG= 653317 

Review-Url: https://codereview.chromium.org/2456613002
Cr-Commit-Position: refs/heads/master@{#427929}

[modify] https://crrev.com/45d0b0cfd7fe1493719a5c9e757d620b19bbf52d/content/browser/bluetooth/web_bluetooth_service_impl.cc
[modify] https://crrev.com/45d0b0cfd7fe1493719a5c9e757d620b19bbf52d/content/renderer/bluetooth/web_bluetooth_impl.cc
[modify] https://crrev.com/45d0b0cfd7fe1493719a5c9e757d620b19bbf52d/third_party/WebKit/LayoutTests/bluetooth/idl-BluetoothDevice.html
[delete] https://crrev.com/540e3bee8f50ff0a41c7dbece39890fbf1a661c7/third_party/WebKit/LayoutTests/bluetooth/requestDevice/correct-uuids.html
[modify] https://crrev.com/45d0b0cfd7fe1493719a5c9e757d620b19bbf52d/third_party/WebKit/LayoutTests/bluetooth/requestDevice/filter-matches.html
[modify] https://crrev.com/45d0b0cfd7fe1493719a5c9e757d620b19bbf52d/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/45d0b0cfd7fe1493719a5c9e757d620b19bbf52d/third_party/WebKit/Source/core/frame/Deprecation.cpp
[modify] https://crrev.com/45d0b0cfd7fe1493719a5c9e757d620b19bbf52d/third_party/WebKit/Source/core/frame/UseCounter.h
[modify] https://crrev.com/45d0b0cfd7fe1493719a5c9e757d620b19bbf52d/third_party/WebKit/Source/modules/bluetooth/BluetoothDevice.cpp
[modify] https://crrev.com/45d0b0cfd7fe1493719a5c9e757d620b19bbf52d/third_party/WebKit/Source/modules/bluetooth/BluetoothDevice.h
[modify] https://crrev.com/45d0b0cfd7fe1493719a5c9e757d620b19bbf52d/third_party/WebKit/Source/modules/bluetooth/BluetoothDevice.idl
[modify] https://crrev.com/45d0b0cfd7fe1493719a5c9e757d620b19bbf52d/third_party/WebKit/public/platform/modules/bluetooth/WebBluetoothDeviceInit.h
[modify] https://crrev.com/45d0b0cfd7fe1493719a5c9e757d620b19bbf52d/third_party/WebKit/public/platform/modules/bluetooth/web_bluetooth.mojom

Status: Fixed (was: Assigned)

Sign in to add a comment