New issue
Advanced search Search tips

Issue 653313 link

Starred by 0 users

Issue metadata

Status: Archived
Owner:
Closed: Nov 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Cast icon not displayed in CrOS system menu

Project Member Reported by jdufault@chromium.org, Oct 5 2016

Issue description

Labels: M-56
Cc: sko...@chromium.org mfo...@chromium.org dbbrooks@chromium.org
Components: Internals>Cast>UI
Adding some description:

The active cast session not shown in CrOS system tray first time after login.

Repro steps:
1. sign out and sign back in to the machine
2. Cast entire desktop using cast icon in toolbar.
3. wait 30 seconds.

Actual: no cast icon is displayed in the toolbar and menu shows device list without a stop button
Expected: Cast icon displayed in toolbar immediately after session starts and menu shows active session with stop button 

3. open and close taskbar menu

Now the cast icon is displayed and when the taskbar menu is re-opened, a stop casting button appears.

*Repros every time

Summary: Cast icon not displayed in CrOS system menu (was: Cast icon not displayed properly)
Labels: OS-Chrome
Status: Started (was: Assigned)
This will be fixed once https://codereview.chromium.org/2424183002/ lands.
It looks like that patch just landed :)
The patch in comment 6 ended up getting split up; the code that fixes this bug is now inside of this patch: https://codereview.chromium.org/2466043002/.
Project Member

Comment 9 by bugdroid1@chromium.org, Nov 16 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e8ea94d6917ade3afc5f7c3164369ef15c3e76c9

commit e8ea94d6917ade3afc5f7c3164369ef15c3e76c9
Author: jdufault <jdufault@chromium.org>
Date: Wed Nov 16 19:57:24 2016

Cleanup TrayCast with media-router only support in mind.

This allows the TrayCast instance to immediately connect to the CastConfigDelegate, which allows TrayCast to fetch cast data before the tray pops up the first time.

This also allows TrayCast to properly support DIAL casts. A DIAL cast is when the Chromecast / sink stream directly from another source, ie, YouTube.

BUG= 653313 

Review-Url: https://codereview.chromium.org/2466043002
Cr-Commit-Position: refs/heads/master@{#432603}

[modify] https://crrev.com/e8ea94d6917ade3afc5f7c3164369ef15c3e76c9/ash/common/cast_config_delegate.h
[modify] https://crrev.com/e8ea94d6917ade3afc5f7c3164369ef15c3e76c9/ash/common/system/chromeos/cast/tray_cast.cc
[modify] https://crrev.com/e8ea94d6917ade3afc5f7c3164369ef15c3e76c9/ash/common/system/chromeos/cast/tray_cast.h
[modify] https://crrev.com/e8ea94d6917ade3afc5f7c3164369ef15c3e76c9/ash/test/tray_cast_test_api.cc
[modify] https://crrev.com/e8ea94d6917ade3afc5f7c3164369ef15c3e76c9/chrome/browser/ui/ash/cast_config_delegate_media_router.cc
[modify] https://crrev.com/e8ea94d6917ade3afc5f7c3164369ef15c3e76c9/chrome/browser/ui/ash/cast_config_delegate_media_router.h

Status: Fixed (was: Started)

Comment 11 by dchan@google.com, May 30 2017

Labels: VerifyIn-60
Labels: VerifyIn-61

Comment 13 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment