Probably my fault when I made StrongBinding's ctor private and introduced
MakeStrongBinding. >.>

(Tentatively tagging this as a security bug to be safe)

#1 I think this was never safe, but it's really easy to miss by accident (even more so in the past, because it used to less obvious that the object was owned unless you looked in the .h)

+tguilbert as well, who was the one who actually noticed this.

tguilbert, did you just find this with a manual search? I'm curious if there are other instances we should be fixing.

I found it (thinking it was the proper way to close a strong binding :P) using this search query:
https://cs.chromium.org/search/?q=%22delete+this%22+mojo&sq=package:chromium&type=cs

There might be a better query however.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4d2bc44e0a5c25025fbad9126003ac9e347bc723

commit 4d2bc44e0a5c25025fbad9126003ac9e347bc723
Author: dcheng <dcheng@chromium.org>
Date: Thu Oct 06 15:17:19 2016

Fix double-delete in BatteryMonitor.

BatterMonitorImpl is uniquely owned by its StrongBinding, so deleting it
directly results in a double-delete.

BUG= 653298 

Review-Url: https://codereview.chromium.org/2398833003
Cr-Commit-Position: refs/heads/master@{#423536}

[modify] https://crrev.com/4d2bc44e0a5c25025fbad9126003ac9e347bc723/device/battery/battery_monitor_impl.cc
[modify] https://crrev.com/4d2bc44e0a5c25025fbad9126003ac9e347bc723/device/battery/battery_monitor_impl.h

I think we probably want to merge this to M54

[Automated comment] Less than 2 weeks to go before stable on M54, manual review required.

This change meets the bar and is approved for merging into M54

Talked with rockot@, this doesn't need to be merged. The old StrongBinding definition is safe against this (since it didn't have a std::unique_ptr internally).

Updating labels to reflect this.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4d2bc44e0a5c25025fbad9126003ac9e347bc723

commit 4d2bc44e0a5c25025fbad9126003ac9e347bc723
Author: dcheng <dcheng@chromium.org>
Date: Thu Oct 06 15:17:19 2016

Fix double-delete in BatteryMonitor.

BatterMonitorImpl is uniquely owned by its StrongBinding, so deleting it
directly results in a double-delete.

BUG= 653298 

Review-Url: https://codereview.chromium.org/2398833003
Cr-Commit-Position: refs/heads/master@{#423536}

[modify] https://crrev.com/4d2bc44e0a5c25025fbad9126003ac9e347bc723/device/battery/battery_monitor_impl.cc
[modify] https://crrev.com/4d2bc44e0a5c25025fbad9126003ac9e347bc723/device/battery/battery_monitor_impl.h

[Automated comment] removing mislabelled merge-merged-2840

This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot