New issue
Advanced search Search tips

Issue 653294 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2016
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug



Sign in to add a comment

ContentSerializedNavigationBuilderTest.ToNavigationEntry is flaky

Project Member Reported by brettw@chromium.org, Oct 5 2016

Issue description

Flainess dashboard:
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=components_unittests&tests=ContentSerializedNavigationBuilderTest.ToNavigationEntry


This test is flaking locally for me with log messages like:

[44162:44162:1005/153254:7794983243112:FATAL:content_serialized_navigation_driver.cc(155)] Check failed: !extended_info_handler_map_.count(key). 
#0 0x7f2915028b1e base::debug::StackTrace::StackTrace()
#1 0x7f291509695f logging::LogMessage::~LogMessage()
#2 0x7f291059eea7 sessions::ContentSerializedNavigationDriver::RegisterExtendedInfoHandler()
#3 0x00000162d0fe sessions::(anonymous namespace)::SetExtendedInfoForTest()
#4 0x00000162d262 sessions::ContentSerializedNavigationBuilderTest_ToNavigationEntry_Test::TestBody()

This assertion as added by jianli in https://codereview.chromium.org/2310363002
 
Owner: jianli@chromium.org
Status: Assigned (was: Unconfirmed)
Summary: ContentSerializedNavigationBuilderTest.ToNavigationEntry is flaky (was: ContentSerializedNavigationBuilderTest)
Description: Show this description
Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3cf12be57931ebc2a8a25af27059e799ecd10b0c

commit 3cf12be57931ebc2a8a25af27059e799ecd10b0c
Author: jianli <jianli@chromium.org>
Date: Thu Oct 13 19:50:44 2016

Fix flaky test ContentSerializedNavigationBuilderTest.ToNavigationEntry

The fix is to call RegisterExtendedInfoHandler only once in test.

BUG= 653294 

Review-Url: https://codereview.chromium.org/2384403005
Cr-Commit-Position: refs/heads/master@{#425131}

[modify] https://crrev.com/3cf12be57931ebc2a8a25af27059e799ecd10b0c/components/sessions/content/content_serialized_navigation_builder_unittest.cc
[modify] https://crrev.com/3cf12be57931ebc2a8a25af27059e799ecd10b0c/components/sessions/content/content_serialized_navigation_driver.h

Comment 5 by jianli@chromium.org, Oct 13 2016

Status: Fixed (was: Started)

Sign in to add a comment