Yi, did you get a chance to look at how the internal icon padding could be taken into account when calculating spacing? If not, no worries.

+Sebastien as FYI. Please take a look at the updated icon spacing in an upcoming canary and let us know your thoughts.

The implementation is close to perfect. 
One thing to fix, the first icon from the right (accessibility in the preview you sent me on Friday) is too much to the right by 2dp, shifting the entire row.

See image attached. top 2 status tray are my spec, bottom is your screenshot.

Deleted: comparison.png 51.5 KB

	comparison.png 51.5 KB View Download

When looking more into this, there seems to be something wrong with how we build the padding around the icons. As you can see in the example attached (spec top, implementation bottom) based on today's build, IME is too far (while accessibility was too close in #3), battery and Wifi are too far apart. It seems like not all icon are based on a 16*16 square, creating various spacing.

Deleted: spacing.png 337 KB

	spacing.png 337 KB View Download

Evan, mind taking a look into these spacing irregularities?

Another one, this time around the screen sharing icon. Top is implementation, bottom is what's specced.

Deleted: spacing.png 51.6 KB

	spacing.png 51.6 KB View Download

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2449770edb6a482bf442bcdb669cd15d5a2f2632

commit 2449770edb6a482bf442bcdb669cd15d5a2f2632
Author: estade <estade@chromium.org>
Date: Fri Oct 28 19:10:00 2016

Simplify layout of tray items and fix spacing for MD.

BUG= 653292 

Review-Url: https://codereview.chromium.org/2455183002
Cr-Commit-Position: refs/heads/master@{#428454}

[modify] https://crrev.com/2449770edb6a482bf442bcdb669cd15d5a2f2632/ash/common/system/chromeos/network/tray_network.cc
[modify] https://crrev.com/2449770edb6a482bf442bcdb669cd15d5a2f2632/ash/common/system/chromeos/power/tray_power.cc
[modify] https://crrev.com/2449770edb6a482bf442bcdb669cd15d5a2f2632/ash/common/system/date/date_view.cc
[modify] https://crrev.com/2449770edb6a482bf442bcdb669cd15d5a2f2632/ash/common/system/date/tray_date.h
[modify] https://crrev.com/2449770edb6a482bf442bcdb669cd15d5a2f2632/ash/common/system/tray/fixed_sized_image_view.cc
[modify] https://crrev.com/2449770edb6a482bf442bcdb669cd15d5a2f2632/ash/common/system/tray/system_tray.cc
[modify] https://crrev.com/2449770edb6a482bf442bcdb669cd15d5a2f2632/ash/common/system/tray/tray_image_item.cc
[modify] https://crrev.com/2449770edb6a482bf442bcdb669cd15d5a2f2632/ash/common/system/tray/tray_image_item.h
[modify] https://crrev.com/2449770edb6a482bf442bcdb669cd15d5a2f2632/ash/common/system/tray/tray_item_view.cc
[modify] https://crrev.com/2449770edb6a482bf442bcdb669cd15d5a2f2632/ash/common/system/tray/tray_item_view.h
[modify] https://crrev.com/2449770edb6a482bf442bcdb669cd15d5a2f2632/ash/common/system/tray/tray_utils.cc

I believe this is now to spec. Sebastien can confirm or deny when it hits canary.

On ToT I see extra padding to the left of the time and to the right of the profile picture (attached), which I think is from your above change. Can you please take a look?

Deleted: system-tray.png 4.4 KB

	system-tray.png 4.4 KB View Download

I'm not seeing the extra padding to the left of the time. I do see the extra space right of the user icon. Do you have any other changes on your tot?

Sorry, I think I must have had some local changes in that screenshot. Just tried again on ToT and am seeing the following (@1x and @2x attached). Seems like it's just the extra padding to the right.

Deleted: oct28-1x.png 28.0 KB

	oct28-1x.png 28.0 KB View Download

Deleted: oct28-2x.png 45.5 KB

	oct28-2x.png 45.5 KB View Download

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/78cffd731645283982ec8821a054b67317ee3b8a

commit 78cffd731645283982ec8821a054b67317ee3b8a
Author: estade <estade@chromium.org>
Date: Tue Nov 01 15:55:30 2016

MD cros - Fix padding in system tray

BUG= 653292 

Review-Url: https://codereview.chromium.org/2461693003
Cr-Commit-Position: refs/heads/master@{#429011}

[modify] https://crrev.com/78cffd731645283982ec8821a054b67317ee3b8a/ash/common/system/tray/system_tray.cc
[modify] https://crrev.com/78cffd731645283982ec8821a054b67317ee3b8a/ash/common/system/tray/tray_background_view.cc
[modify] https://crrev.com/78cffd731645283982ec8821a054b67317ee3b8a/ash/common/system/tray/tray_background_view.h
[modify] https://crrev.com/78cffd731645283982ec8821a054b67317ee3b8a/ash/common/system/user/tray_user.cc
[modify] https://crrev.com/78cffd731645283982ec8821a054b67317ee3b8a/ash/common/system/user/tray_user_separator.cc
[modify] https://crrev.com/78cffd731645283982ec8821a054b67317ee3b8a/ash/common/system/user/tray_user_separator.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4b338bc886f384d287b2e11fc913016301ed6761

commit 4b338bc886f384d287b2e11fc913016301ed6761
Author: estade <estade@chromium.org>
Date: Wed Nov 02 00:36:49 2016

Some more fixes to cros system tray icons (esp. screen tray items)

More things should use TrayItemView (and not override its layout manager)

BUG= 653292 

Review-Url: https://codereview.chromium.org/2465403002
Cr-Commit-Position: refs/heads/master@{#429163}

[modify] https://crrev.com/4b338bc886f384d287b2e11fc913016301ed6761/ash/common/system/cast/tray_cast.cc
[modify] https://crrev.com/4b338bc886f384d287b2e11fc913016301ed6761/ash/common/system/cast/tray_cast.h
[modify] https://crrev.com/4b338bc886f384d287b2e11fc913016301ed6761/ash/common/system/chromeos/media_security/multi_profile_media_tray_item.cc
[modify] https://crrev.com/4b338bc886f384d287b2e11fc913016301ed6761/ash/common/system/chromeos/screen_security/screen_capture_tray_item.cc
[modify] https://crrev.com/4b338bc886f384d287b2e11fc913016301ed6761/ash/common/system/chromeos/screen_security/screen_capture_tray_item.h
[modify] https://crrev.com/4b338bc886f384d287b2e11fc913016301ed6761/ash/common/system/chromeos/screen_security/screen_share_tray_item.cc
[modify] https://crrev.com/4b338bc886f384d287b2e11fc913016301ed6761/ash/common/system/chromeos/screen_security/screen_share_tray_item.h
[modify] https://crrev.com/4b338bc886f384d287b2e11fc913016301ed6761/ash/common/system/chromeos/screen_security/screen_tray_item.cc
[modify] https://crrev.com/4b338bc886f384d287b2e11fc913016301ed6761/ash/common/system/chromeos/screen_security/screen_tray_item.h
[modify] https://crrev.com/4b338bc886f384d287b2e11fc913016301ed6761/ash/common/system/tray/tray_item_view.cc
[modify] https://crrev.com/4b338bc886f384d287b2e11fc913016301ed6761/ash/common/system/tray/tray_item_view.h
[modify] https://crrev.com/4b338bc886f384d287b2e11fc913016301ed6761/ash/common/system/user/tray_user_separator.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d7dfdcd1b4543b5d372ac3663498aa6ab9d077c9

commit d7dfdcd1b4543b5d372ac3663498aa6ab9d077c9
Author: estade <estade@chromium.org>
Date: Thu Nov 10 01:07:50 2016

Minor adjustment to edge padding of cros tray.

Easiest to notice by looking to left of the clock.

BUG= 653292 

Review-Url: https://codereview.chromium.org/2485963003
Cr-Commit-Position: refs/heads/master@{#431125}

[modify] https://crrev.com/d7dfdcd1b4543b5d372ac3663498aa6ab9d077c9/ash/common/system/tray/system_tray.cc
[modify] https://crrev.com/d7dfdcd1b4543b5d372ac3663498aa6ab9d077c9/ash/common/system/tray/tray_constants.cc
[modify] https://crrev.com/d7dfdcd1b4543b5d372ac3663498aa6ab9d077c9/ash/common/system/tray/tray_constants.h

I believe this to be fixed.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1a3965df2a1b4c307f4c8024725a431933a8e946

commit 1a3965df2a1b4c307f4c8024725a431933a8e946
Author: estade <estade@chromium.org>
Date: Wed Nov 16 00:48:06 2016

CrOS - Twiddle with the padding in the system tray.

BUG= 653292 ,663016

Review-Url: https://codereview.chromium.org/2502693002
Cr-Commit-Position: refs/heads/master@{#432326}

[modify] https://crrev.com/1a3965df2a1b4c307f4c8024725a431933a8e946/ash/common/system/date/date_view.cc
[modify] https://crrev.com/1a3965df2a1b4c307f4c8024725a431933a8e946/ash/common/system/tray/tray_constants.cc