New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 653289 link

Starred by 1 user
Status: Verified
Owner:
jdufault@chromium.org
Closed: Oct 2016
Cc:
█ rookrishna@chromium.org
sdantul...@chromium.org
sammiequon@chromium.org
tbuck...@chromium.org
abod...@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

'Pin or password' should be PIN or Password

Project Member Reported by dhadd...@chromium.org, Oct 5 2016 
M55 | 8865.0.0 | Samus

Enable pin unlock
setup pin
lock the device 
observe the placeholder text

Comment 1 by jdufault@chromium.org, Oct 5 2016

Owner: tbuck...@chromium.org
Owner to tbuckley@ to confirm desired string.

Comment 2 by jdufault@chromium.org, Oct 5 2016

Cc: jdufault@chromium.org

Comment 3 by tbuckley@google.com, Oct 6 2016

Owner: sammiequon@chromium.org
Status: Assigned (was: Untriaged)
Yes, "PIN" should be used everywhere.

Comment 4 by jdufault@chromium.org, Oct 6 2016

Cc: -jdufault@chromium.org sammiequon@chromium.org
Owner: jdufault@chromium.org
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 6 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bcc633ec3c7f8225d718b0a09ce48b4cb4af3ba5

commit bcc633ec3c7f8225d718b0a09ce48b4cb4af3ba5
Author: jdufault <jdufault@chromium.org>
Date: Thu Oct 06 20:25:30 2016

cros: Use PIN instead of Pin in localization.

BUG= 653289 
TBR=grt

Review-Url: https://codereview.chromium.org/2394163003
Cr-Commit-Position: refs/heads/master@{#423653}

[modify] https://crrev.com/bcc633ec3c7f8225d718b0a09ce48b4cb4af3ba5/chrome/app/generated_resources.grd

Comment 6 by jdufault@chromium.org, Oct 6 2016

Status: Fixed (was: Assigned)

Comment 7 by dhadd...@chromium.org, Oct 18 2016

Status: Verified (was: Fixed)
Project Member

Comment 8 by bugdroid1@chromium.org, Oct 27 2016

Labels: merge-merged-2840
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bcc633ec3c7f8225d718b0a09ce48b4cb4af3ba5

commit bcc633ec3c7f8225d718b0a09ce48b4cb4af3ba5
Author: jdufault <jdufault@chromium.org>
Date: Thu Oct 06 20:25:30 2016

cros: Use PIN instead of Pin in localization.

BUG= 653289 
TBR=grt

Review-Url: https://codereview.chromium.org/2394163003
Cr-Commit-Position: refs/heads/master@{#423653}

[modify] https://crrev.com/bcc633ec3c7f8225d718b0a09ce48b4cb4af3ba5/chrome/app/generated_resources.grd

Comment 9 by dimu@google.com, Nov 4 2016

Labels: -merge-merged-2840
[Automated comment] removing mislabelled merge-merged-2840
►

Sign in to add a comment