Issue 653287 link

Starred by 1 user

Issue metadata

Status:	Fixed
Owner:	asvitk...@chromium.org
Closed:	Oct 2016
Cc:	skare@chromium.org isherman@chromium.org asvitk...@chromium.org █ rkaplow@chromium.org
Components:	Internals>Metrics
EstimatedDays:	----
NextAction:	----
OS:	All
Pri:	3
Type:	Bug

Clean up session crashed up bubble code

Project Member Reported by asvitk...@chromium.org, Oct 5 2016

Issue description

Seems like we still have:
  - A field trial control for it.
  - Enable/disable command line flags.
  - An about flags entry.

Let's clean it all up!

Project Member

Comment 1 by bugdroid1@chromium.org, Oct 7 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f9ec845ea149aae27ba281f5a4eee9ae57c5317d

commit f9ec845ea149aae27ba281f5a4eee9ae57c5317d
Author: asvitkine <asvitkine@chromium.org>
Date: Fri Oct 07 18:23:01 2016

Clean up session crashed bubble field trial & switches.

Also makes it use the API in metrics_reporting_state.cc to
check whether metrics is policy controlled, rather than using
the prefs directly.

BUG= 653287 

Review-Url: https://codereview.chromium.org/2405493002
Cr-Commit-Position: refs/heads/master@{#423913}

[modify] https://crrev.com/f9ec845ea149aae27ba281f5a4eee9ae57c5317d/chrome/app/generated_resources.grd
[modify] https://crrev.com/f9ec845ea149aae27ba281f5a4eee9ae57c5317d/chrome/browser/about_flags.cc
[modify] https://crrev.com/f9ec845ea149aae27ba281f5a4eee9ae57c5317d/chrome/browser/ui/views/session_crashed_bubble_view.cc
[modify] https://crrev.com/f9ec845ea149aae27ba281f5a4eee9ae57c5317d/chrome/common/chrome_switches.cc
[modify] https://crrev.com/f9ec845ea149aae27ba281f5a4eee9ae57c5317d/chrome/common/chrome_switches.h

Comment 2 by asvitk...@chromium.org, Oct 7 2016

Status: Fixed (was: Assigned)

►

Issue 653287 link

Issue metadata

Clean up session crashed up bubble code

Issue description

Comment 1 by bugdroid1@chromium.org, Oct 7 2016

Comment 1 Deleted

Comment 2 by asvitk...@chromium.org, Oct 7 2016

Comment 2 Deleted

Sign in to add a comment