New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 653284 link

Starred by 1 user

Issue metadata

Status: Verified
Owner: ----
Closed: Oct 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Implement gbm_bo_map/gbm_bo_unmap

Project Member Reported by gurcheta...@chromium.org, Oct 5 2016

Issue description

So we can convert tests to use driver-specific map functions.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 7 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/minigbm/+/5753c3129a21eb7c0c2f0bd8113cd6b01b8cf651

commit 5753c3129a21eb7c0c2f0bd8113cd6b01b8cf651
Author: Gurchetan Singh <gurchetansingh@chromium.org>
Date: Wed Oct 05 22:16:22 2016

minigbm: quick and dirty implementation of gbm_bo_map/gbm_bo_unmap

We want to add gbm_bo_map/gbm_bo_unmap entry points so certain tests
and Chrome can use driver specific map logic.  This is based on the
upstream entry points in Mesa, with the addition of a plane parameter.

Currently, we just map the entire buffer and don't attempt to do partial
mappings or use the map flags.  We should do this in the future...

BUG= chromium:653284 
TEST=minigbm builds

Change-Id: I0423c10c55bab8fac6d6d7c6a699ab71b43aa61b
Reviewed-on: https://chromium-review.googlesource.com/393927
Commit-Ready: Gurchetan Singh <gurchetansingh@chromium.org>
Tested-by: Gurchetan Singh <gurchetansingh@chromium.org>
Reviewed-by: Stéphane Marchesin <marcheu@chromium.org>

[modify] https://crrev.com/5753c3129a21eb7c0c2f0bd8113cd6b01b8cf651/gbm.c
[modify] https://crrev.com/5753c3129a21eb7c0c2f0bd8113cd6b01b8cf651/gbm.h

Project Member

Comment 2 by bugdroid1@chromium.org, Oct 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/minigbm/+/1a31e609770088ad0e5abb49678174e4c6393d34

commit 1a31e609770088ad0e5abb49678174e4c6393d34
Author: Gurchetan Singh <gurchetansingh@chromium.org>
Date: Thu Oct 06 17:58:00 2016

minigbm: More sophisticated gbm_bo_map/gbm_bo_unmap

We previously added the gbm_bo_map/gbm_bo_unmap (see CL:393927)
entry points since we wanted to do driver-specific detiling during
screenshot capture tests.  We ignored most the parameters and mapped
the entire buffer.  This CL adds the ability to:

1) Return the starting address within a byte given a specific x, y
   in the buffer.

2) Handle the case where there are more than one kernel buffers
   per buffer object.  Currently, only the Exynos driver would use
   this capability.

BUG= chromium:653284 
TEST=Ran cros_gralloc with modified code

CQ-DEPEND=CL:393927

Change-Id: I19d75d2f16489c0184e96305fb643f18477e1cdb
Reviewed-on: https://chromium-review.googlesource.com/395066
Commit-Ready: Gurchetan Singh <gurchetansingh@chromium.org>
Tested-by: Gurchetan Singh <gurchetansingh@chromium.org>
Reviewed-by: Stéphane Marchesin <marcheu@chromium.org>

[modify] https://crrev.com/1a31e609770088ad0e5abb49678174e4c6393d34/helpers.h
[modify] https://crrev.com/1a31e609770088ad0e5abb49678174e4c6393d34/rockchip.c
[modify] https://crrev.com/1a31e609770088ad0e5abb49678174e4c6393d34/helpers.c
[modify] https://crrev.com/1a31e609770088ad0e5abb49678174e4c6393d34/drv_priv.h
[modify] https://crrev.com/1a31e609770088ad0e5abb49678174e4c6393d34/tegra.c
[modify] https://crrev.com/1a31e609770088ad0e5abb49678174e4c6393d34/drv.h
[modify] https://crrev.com/1a31e609770088ad0e5abb49678174e4c6393d34/drv.c
[modify] https://crrev.com/1a31e609770088ad0e5abb49678174e4c6393d34/gbm.c
[modify] https://crrev.com/1a31e609770088ad0e5abb49678174e4c6393d34/mediatek.c
[modify] https://crrev.com/1a31e609770088ad0e5abb49678174e4c6393d34/i915.c

Status: Verified (was: Untriaged)

Sign in to add a comment