New issue
Advanced search Search tips

Issue 653271 link

Starred by 1 user
Status: Fixed
Owner:
thakis@chromium.org
Closed: Oct 2016
Cc:
tapted@chromium.org
dtapu...@chromium.org
ccameron@chromium.org
skobes@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug

Blocking:
issue 579255



Sign in to add a comment

Remove windowResizerRect code from blink

Project Member Reported by thakis@chromium.org, Oct 5 2016 
Blink has:

  // These functions are used to enable scrollbars to avoid window resizer controls that overlap the scroll view.
  // This happens only on Mac OS X 10.6.
  IntRect windowResizerRect() const;
  bool containsScrollbarsAvoidingResizer() const;
  void adjustScrollbarsAvoidingResizerCount(int overlapDelta);
  void windowResizerRectChanged();


We don't need that code anymore and should delete it.

Comment 1 by tapted@chromium.org, Oct 7 2016

Blocking: 579255
Cc: skobes@chromium.org dtapu...@chromium.org tapted@chromium.org ccameron@chromium.org
Components: Blink>Scroll
Status: Available (was: Untriaged)
[mac triage]

Comment 2 by thakis@chromium.org, Oct 7 2016

Owner: thakis@chromium.org
Status: Assigned (was: Available)
I'll give this a look.
Project Member

Comment 6 by bugdroid1@chromium.org, Oct 7 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4c77f96d88caa76e1200e5dab191215000fda7cb

commit 4c77f96d88caa76e1200e5dab191215000fda7cb
Author: thakis <thakis@chromium.org>
Date: Fri Oct 07 19:10:03 2016

Remove grow box rect support, browser part.

We added all this grow box rect plumbing for macOS, but 10.6 was the
last version with grow boxes, and we no longer suport that.  Views
never sets this to anything other than (0, 0, 0, 0), and on macOS
we use whatever [NSWindow _growBoxRect] returns -- on macOS versions
newer than 10.6, that's always (0, 0, 0, 0) also, even if "always show
scrollbars" is checked in System Preferences (but the method
_growBoxRect still exists as of 10.11)

BUG= 653271 
TBR=rsesek

Review-Url: https://codereview.chromium.org/2400243002
Cr-Commit-Position: refs/heads/master@{#423920}

[modify] https://crrev.com/4c77f96d88caa76e1200e5dab191215000fda7cb/blimp/engine/feature/engine_render_widget_feature_unittest.cc
[modify] https://crrev.com/4c77f96d88caa76e1200e5dab191215000fda7cb/chrome/browser/ui/browser.cc
[modify] https://crrev.com/4c77f96d88caa76e1200e5dab191215000fda7cb/chrome/browser/ui/browser.h
[modify] https://crrev.com/4c77f96d88caa76e1200e5dab191215000fda7cb/chrome/browser/ui/browser_window.h
[modify] https://crrev.com/4c77f96d88caa76e1200e5dab191215000fda7cb/chrome/browser/ui/cocoa/browser_window_cocoa.h
[modify] https://crrev.com/4c77f96d88caa76e1200e5dab191215000fda7cb/chrome/browser/ui/cocoa/browser_window_cocoa.mm
[modify] https://crrev.com/4c77f96d88caa76e1200e5dab191215000fda7cb/chrome/browser/ui/cocoa/browser_window_controller.h
[modify] https://crrev.com/4c77f96d88caa76e1200e5dab191215000fda7cb/chrome/browser/ui/cocoa/browser_window_controller.mm
[modify] https://crrev.com/4c77f96d88caa76e1200e5dab191215000fda7cb/chrome/browser/ui/views/frame/browser_view.cc
[modify] https://crrev.com/4c77f96d88caa76e1200e5dab191215000fda7cb/chrome/browser/ui/views/frame/browser_view.h
[modify] https://crrev.com/4c77f96d88caa76e1200e5dab191215000fda7cb/chrome/test/base/test_browser_window.cc
[modify] https://crrev.com/4c77f96d88caa76e1200e5dab191215000fda7cb/chrome/test/base/test_browser_window.h
[modify] https://crrev.com/4c77f96d88caa76e1200e5dab191215000fda7cb/content/browser/renderer_host/render_widget_host_delegate.cc
[modify] https://crrev.com/4c77f96d88caa76e1200e5dab191215000fda7cb/content/browser/renderer_host/render_widget_host_delegate.h
[modify] https://crrev.com/4c77f96d88caa76e1200e5dab191215000fda7cb/content/browser/renderer_host/render_widget_host_impl.cc
[modify] https://crrev.com/4c77f96d88caa76e1200e5dab191215000fda7cb/content/browser/renderer_host/render_widget_host_impl.h
[modify] https://crrev.com/4c77f96d88caa76e1200e5dab191215000fda7cb/content/browser/web_contents/web_contents_impl.cc
[modify] https://crrev.com/4c77f96d88caa76e1200e5dab191215000fda7cb/content/browser/web_contents/web_contents_impl.h
[modify] https://crrev.com/4c77f96d88caa76e1200e5dab191215000fda7cb/content/public/browser/render_widget_host.h
[modify] https://crrev.com/4c77f96d88caa76e1200e5dab191215000fda7cb/content/public/browser/web_contents_delegate.cc
[modify] https://crrev.com/4c77f96d88caa76e1200e5dab191215000fda7cb/content/public/browser/web_contents_delegate.h
[modify] https://crrev.com/4c77f96d88caa76e1200e5dab191215000fda7cb/services/navigation/public/cpp/view.cc
[modify] https://crrev.com/4c77f96d88caa76e1200e5dab191215000fda7cb/services/navigation/public/cpp/view.h
[modify] https://crrev.com/4c77f96d88caa76e1200e5dab191215000fda7cb/services/navigation/public/interfaces/view.mojom
[modify] https://crrev.com/4c77f96d88caa76e1200e5dab191215000fda7cb/services/navigation/view_impl.cc
[modify] https://crrev.com/4c77f96d88caa76e1200e5dab191215000fda7cb/services/navigation/view_impl.h

Comment 7 by thakis@chromium.org, Oct 7 2016

Status: Started (was: Assigned)
Project Member

Comment 8 by bugdroid1@chromium.org, Oct 10 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4d7eccaaf925ceeb938d79d57cea1b9067435317

commit 4d7eccaaf925ceeb938d79d57cea1b9067435317
Author: thakis <thakis@chromium.org>
Date: Mon Oct 10 14:09:15 2016

Remove grow box rect support, renderer part.

Depends on https://codereview.chromium.org/2400243002/

The grow box was always (0, 0, 0, 0) in practice, which means
all this code was a no-op.

BUG= 653271 

Review-Url: https://codereview.chromium.org/2395393003
Cr-Commit-Position: refs/heads/master@{#424145}

[modify] https://crrev.com/4d7eccaaf925ceeb938d79d57cea1b9067435317/components/printing/test/print_web_view_helper_browsertest.cc
[modify] https://crrev.com/4d7eccaaf925ceeb938d79d57cea1b9067435317/content/browser/screen_orientation/screen_orientation_browsertest.cc
[modify] https://crrev.com/4d7eccaaf925ceeb938d79d57cea1b9067435317/content/common/resize_params.h
[modify] https://crrev.com/4d7eccaaf925ceeb938d79d57cea1b9067435317/content/common/view_messages.h
[modify] https://crrev.com/4d7eccaaf925ceeb938d79d57cea1b9067435317/content/public/test/render_view_test.cc
[modify] https://crrev.com/4d7eccaaf925ceeb938d79d57cea1b9067435317/content/public/test/render_view_test.h
[modify] https://crrev.com/4d7eccaaf925ceeb938d79d57cea1b9067435317/content/renderer/render_frame_impl_browsertest.cc
[modify] https://crrev.com/4d7eccaaf925ceeb938d79d57cea1b9067435317/content/renderer/render_view_impl.cc
[modify] https://crrev.com/4d7eccaaf925ceeb938d79d57cea1b9067435317/content/renderer/render_widget.cc
[modify] https://crrev.com/4d7eccaaf925ceeb938d79d57cea1b9067435317/content/renderer/render_widget.h
[modify] https://crrev.com/4d7eccaaf925ceeb938d79d57cea1b9067435317/content/renderer/render_widget_browsertest.cc
[modify] https://crrev.com/4d7eccaaf925ceeb938d79d57cea1b9067435317/third_party/WebKit/Source/core/frame/FrameView.cpp
[modify] https://crrev.com/4d7eccaaf925ceeb938d79d57cea1b9067435317/third_party/WebKit/Source/core/frame/FrameView.h
[modify] https://crrev.com/4d7eccaaf925ceeb938d79d57cea1b9067435317/third_party/WebKit/Source/core/loader/EmptyClients.h
[modify] https://crrev.com/4d7eccaaf925ceeb938d79d57cea1b9067435317/third_party/WebKit/Source/core/page/ChromeClient.h
[modify] https://crrev.com/4d7eccaaf925ceeb938d79d57cea1b9067435317/third_party/WebKit/Source/platform/scroll/Scrollbar.cpp
[modify] https://crrev.com/4d7eccaaf925ceeb938d79d57cea1b9067435317/third_party/WebKit/Source/platform/scroll/Scrollbar.h
[modify] https://crrev.com/4d7eccaaf925ceeb938d79d57cea1b9067435317/third_party/WebKit/Source/web/ChromeClientImpl.cpp
[modify] https://crrev.com/4d7eccaaf925ceeb938d79d57cea1b9067435317/third_party/WebKit/Source/web/ChromeClientImpl.h
[modify] https://crrev.com/4d7eccaaf925ceeb938d79d57cea1b9067435317/third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp
[modify] https://crrev.com/4d7eccaaf925ceeb938d79d57cea1b9067435317/third_party/WebKit/Source/web/WebFrameWidgetImpl.h
[modify] https://crrev.com/4d7eccaaf925ceeb938d79d57cea1b9067435317/third_party/WebKit/Source/web/WebViewFrameWidget.cpp
[modify] https://crrev.com/4d7eccaaf925ceeb938d79d57cea1b9067435317/third_party/WebKit/Source/web/WebViewFrameWidget.h
[modify] https://crrev.com/4d7eccaaf925ceeb938d79d57cea1b9067435317/third_party/WebKit/Source/web/WebViewImpl.cpp
[modify] https://crrev.com/4d7eccaaf925ceeb938d79d57cea1b9067435317/third_party/WebKit/Source/web/WebViewImpl.h
[modify] https://crrev.com/4d7eccaaf925ceeb938d79d57cea1b9067435317/third_party/WebKit/public/web/WebView.h
[modify] https://crrev.com/4d7eccaaf925ceeb938d79d57cea1b9067435317/third_party/WebKit/public/web/WebWidget.h
[modify] https://crrev.com/4d7eccaaf925ceeb938d79d57cea1b9067435317/third_party/WebKit/public/web/WebWidgetClient.h

Comment 9 by thakis@chromium.org, Oct 10 2016

Status: Fixed (was: Started)
►

Sign in to add a comment