New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 653266 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug



Sign in to add a comment

If Chrome is hidden and a notification arrives, Chrome unhides completely

Project Member Reported by sdy@chromium.org, Oct 5 2016

Issue description

Version: 55.0.2881.0
OS: macOS

What steps will reproduce the problem?
(1) Schedule a notification (e.g. go to a site that has notification privileges, then run "setTimeout(() => { new Notification('your foo is ready'); }, 1000)" in the console).
(2) Hide Chrome (cmd+H)
(3) Wait for <1s.

What is the expected output?
The notification appears without all of Chrome's other windows becoming visible.

What do you see instead?
All Chrome windows become visible.
 
Cc: miguelg@chromium.org peter@chromium.org
I wonder if this is also the behavior for SW-initiated notifications.

+miguelg@ who is looking into moving to native notifications on OSX (though older versions will still have this issue even post migration)
+peter@ who knows web notifications best.

Comment 2 by peter@chromium.org, Oct 6 2016

This seems to be specific to <cmd>+<h> - the bug does not show when the window is minimised, or other windows are on top.

Should something special be done when creating a notification toast in that situation to prevent the rest from Chrome popping up?

Comment 3 by sdy@chromium.org, Oct 7 2016

Cc: shrike@chromium.org
Status: Started (was: Assigned)
Yes, but I wasn't sure what the special thing was — turned out it was a one-line change, so I just made a CL :).
https://codereview.chromium.org/2399993003
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 7 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a8cad7b0b4254bec43a95c58509f636236b262f2

commit a8cad7b0b4254bec43a95c58509f636236b262f2
Author: sdy <sdy@chromium.org>
Date: Fri Oct 07 14:39:29 2016

[Mac] Don't unhide Chrome when a notification is displayed.

Right now, if Chrome was hidden (cmd+h) and a notification comes in, the
whole app unhides.

Calling setHidden:YES on the notification window lets it be visible when
Chrome is hidden, and the -[NSWindow order*] methods respect it by not
unhiding the app.

BUG= 653266 

Review-Url: https://codereview.chromium.org/2399993003
Cr-Commit-Position: refs/heads/master@{#423856}

[modify] https://crrev.com/a8cad7b0b4254bec43a95c58509f636236b262f2/ui/message_center/cocoa/popup_controller.mm

Comment 5 by sdy@chromium.org, Oct 13 2016

Status: Fixed (was: Started)

Comment 6 by sdy@chromium.org, Dec 16 2016

Labels: -Proj-MacQualityOfLife Hotlist-MacQualityOfLife
 Issue 675733  has been merged into this issue.
Labels: -Hotlist-MacQualityOfLife Hotlist-PlatformExcellence
Migrating to more generic platform label, so that it can be applied to other platforms (i.e. I love the idea).

Sign in to add a comment