Cannot print to XPS Document Writer |
|||||||
Issue descriptionVersion: 54.x OS: Windows What steps will reproduce the problem? (1) Visit chrome://version/ (2) press ctrl + p, or ctrl + shift + p (3) print to XPS Document Writer (4) At the save file prompt, save to foo.xps or foo.oxps. What is the expected output? foo.xps / foo.oxps appears. What do you see instead? foo.xps / foo.oxps never appears. This broke in r414209, but at first I thought it was just my workstation being wonky, whereas a test laptop worked fine. Now I've tested on two more machines and they are both broken as well.
,
Oct 6 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1f8436ba96d348607317d2d34cb604a9243f0ff0 commit 1f8436ba96d348607317d2d34cb604a9243f0ff0 Author: thestig <thestig@chromium.org> Date: Thu Oct 06 01:09:25 2016 Fix printing with XPS printers on Windows. Check to see if a given printer is XPS. If so, revert back to non-GDI text printing path. BUG= 653257 Review-Url: https://codereview.chromium.org/2392343003 Cr-Commit-Position: refs/heads/master@{#423372} [modify] https://crrev.com/1f8436ba96d348607317d2d34cb604a9243f0ff0/chrome/browser/printing/print_view_manager_base.cc [modify] https://crrev.com/1f8436ba96d348607317d2d34cb604a9243f0ff0/printing/print_settings.cc [modify] https://crrev.com/1f8436ba96d348607317d2d34cb604a9243f0ff0/printing/print_settings.h [modify] https://crrev.com/1f8436ba96d348607317d2d34cb604a9243f0ff0/printing/print_settings_initializer_win.cc
,
Oct 6 2016
,
Oct 7 2016
2881 canary was broken, and 2883 canary works.
,
Oct 7 2016
[Automated comment] Less than 2 weeks to go before stable on M54, manual review required.
,
Oct 7 2016
Thanks for the fix, since this high priority, approving for M54
,
Oct 7 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ad85552ccdd70ce4945b602abb9caf3fc1b852b0 commit ad85552ccdd70ce4945b602abb9caf3fc1b852b0 Author: Lei Zhang <thestig@chromium.org> Date: Fri Oct 07 23:43:06 2016 M54: Fix printing with XPS printers on Windows. Check to see if a given printer is XPS. If so, revert back to non-GDI text printing path. BUG= 653257 Review-Url: https://codereview.chromium.org/2392343003 Cr-Commit-Position: refs/heads/master@{#423372} (cherry picked from commit 1f8436ba96d348607317d2d34cb604a9243f0ff0) Review URL: https://codereview.chromium.org/2395373003 . Cr-Commit-Position: refs/branch-heads/2840@{#690} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/ad85552ccdd70ce4945b602abb9caf3fc1b852b0/chrome/browser/printing/print_view_manager_base.cc [modify] https://crrev.com/ad85552ccdd70ce4945b602abb9caf3fc1b852b0/printing/print_settings.cc [modify] https://crrev.com/ad85552ccdd70ce4945b602abb9caf3fc1b852b0/printing/print_settings.h [modify] https://crrev.com/ad85552ccdd70ce4945b602abb9caf3fc1b852b0/printing/print_settings_initializer_win.cc
,
Oct 12 2016
Verified the issue on windows 10 using chrome beta version #54.0.2840.59 as per the steps mentioned in the comment #0. The steps followed to reproduce the issue are as follows: ----------- (1) Navigated to chrome://version/ (2) Pressed ctrl + p (3) Printed to XPS Document Writer. (4) At the save file prompt, saved to foo.xps (5) Repeated steps from 2 to 4 and saved to foo1.oxps. The foo.xps and foo1.oxps files appeared in the destination folder as expected. Hence, the fix is working as expected. Attaching screencast for reference Adding the verified labels.
,
Oct 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1f8436ba96d348607317d2d34cb604a9243f0ff0 commit 1f8436ba96d348607317d2d34cb604a9243f0ff0 Author: thestig <thestig@chromium.org> Date: Thu Oct 06 01:09:25 2016 Fix printing with XPS printers on Windows. Check to see if a given printer is XPS. If so, revert back to non-GDI text printing path. BUG= 653257 Review-Url: https://codereview.chromium.org/2392343003 Cr-Commit-Position: refs/heads/master@{#423372} [modify] https://crrev.com/1f8436ba96d348607317d2d34cb604a9243f0ff0/chrome/browser/printing/print_view_manager_base.cc [modify] https://crrev.com/1f8436ba96d348607317d2d34cb604a9243f0ff0/printing/print_settings.cc [modify] https://crrev.com/1f8436ba96d348607317d2d34cb604a9243f0ff0/printing/print_settings.h [modify] https://crrev.com/1f8436ba96d348607317d2d34cb604a9243f0ff0/printing/print_settings_initializer_win.cc
,
Oct 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ad85552ccdd70ce4945b602abb9caf3fc1b852b0 commit ad85552ccdd70ce4945b602abb9caf3fc1b852b0 Author: Lei Zhang <thestig@chromium.org> Date: Fri Oct 07 23:43:06 2016 M54: Fix printing with XPS printers on Windows. Check to see if a given printer is XPS. If so, revert back to non-GDI text printing path. BUG= 653257 Review-Url: https://codereview.chromium.org/2392343003 Cr-Commit-Position: refs/heads/master@{#423372} (cherry picked from commit 1f8436ba96d348607317d2d34cb604a9243f0ff0) Review URL: https://codereview.chromium.org/2395373003 . Cr-Commit-Position: refs/branch-heads/2840@{#690} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/ad85552ccdd70ce4945b602abb9caf3fc1b852b0/chrome/browser/printing/print_view_manager_base.cc [modify] https://crrev.com/ad85552ccdd70ce4945b602abb9caf3fc1b852b0/printing/print_settings.cc [modify] https://crrev.com/ad85552ccdd70ce4945b602abb9caf3fc1b852b0/printing/print_settings.h [modify] https://crrev.com/ad85552ccdd70ce4945b602abb9caf3fc1b852b0/printing/print_settings_initializer_win.cc |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by thestig@chromium.org
, Oct 5 2016