Clock is painted in black instead of white |
||||||||
Issue descriptionVersion: current TOT OS: Chrome OS What steps will reproduce the problem? (1) set ash-md to experimental (2) build OS What is the expected output? Show a visible clock with color white What do you see instead? Show a clock with color black which is not visible when shelf is opaque. Please use labels and text to provide additional information. Please refer to the picture for details.
,
Oct 5 2016
,
Oct 5 2016
Ben/Evan, could this be related to any of your recent font/theming related changes?
,
Oct 5 2016
is this a regression? looks like this should be using a native theme color (or colors): https://cs.chromium.org/chromium/src/ash/common/system/date/date_view.cc?rcl=1475680623&l=177 just removing that would do the trick if we don't care/don't need the slightly different hovered text color.
,
Oct 5 2016
> Is this a regression? Yes, I only noticed this when I synced ToT yesterday. The clock text used to be white before.
,
Oct 5 2016
hmm, I have a vague idea of what may have caused this...
,
Oct 5 2016
if you do a debug build, do you get a notreached?
,
Oct 6 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ec013bf782f54a4ef8f3897f390ca391c701bee2 commit ec013bf782f54a4ef8f3897f390ca391c701bee2 Author: estade <estade@chromium.org> Date: Thu Oct 06 16:22:20 2016 Fix label colors for dark native themes (incognito, shelf). Regressed in f02568a216b975130849079183cc0f7173d6b832 BUG= 653241 Review-Url: https://codereview.chromium.org/2394083002 Cr-Commit-Position: refs/heads/master@{#423556} [modify] https://crrev.com/ec013bf782f54a4ef8f3897f390ca391c701bee2/ui/native_theme/native_theme_dark_aura.cc
,
Oct 6 2016
,
Oct 11 2016
Issue 654482 has been merged into this issue.
,
Oct 19 2016
Verified on ChromeOS 8872.16.0, 55.0.2883.20
,
Oct 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ec013bf782f54a4ef8f3897f390ca391c701bee2 commit ec013bf782f54a4ef8f3897f390ca391c701bee2 Author: estade <estade@chromium.org> Date: Thu Oct 06 16:22:20 2016 Fix label colors for dark native themes (incognito, shelf). Regressed in f02568a216b975130849079183cc0f7173d6b832 BUG= 653241 Review-Url: https://codereview.chromium.org/2394083002 Cr-Commit-Position: refs/heads/master@{#423556} [modify] https://crrev.com/ec013bf782f54a4ef8f3897f390ca391c701bee2/ui/native_theme/native_theme_dark_aura.cc
,
Nov 4 2016
[Automated comment] removing mislabelled merge-merged-2840 |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by yiyix@chromium.org
, Oct 5 2016