New issue
Advanced search Search tips

Issue 653234 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Launch-OWP
Launch-Accessibility: ----
Launch-Exp-Leadership: ----
Launch-Leadership: ----
Launch-Legal: ----
Launch-M-Approved: 56-Dev
Launch-M-Target: ----
Launch-Privacy: ----
Launch-Security: ----
Launch-Test: ----
Launch-UI: ----
Rollout-Type: ----



Sign in to add a comment

ChannelSplitterNode has constant channelCount and mode

Project Member Reported by rtoy@chromium.org, Oct 5 2016

Issue description

Comment 1 by rtoy@chromium.org, Oct 10 2016

Owner: rtoy@chromium.org
Status: Started (was: Available)

Comment 2 by foolip@chromium.org, Oct 13 2016

Labels: -Type-Bug OWP-Type-ChangeAPI Type-Launch-OWP
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 18 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/efb11f5a890fd4a793dbf8383fb8b529ddf39898

commit efb11f5a890fd4a793dbf8383fb8b529ddf39898
Author: rtoy <rtoy@chromium.org>
Date: Tue Oct 18 17:47:18 2016

ChannelSplitterNode channelCount and mode are constant.

The channelCount for a ChannelSplitterNode is now set to the number of
outputs and cannot be changed.  The channelCountMode is also fixed to
"explicit".

Intent: https://groups.google.com/a/chromium.org/d/msg/blink-dev/wavuM3cciPc/1Df3Hrr-CAAJ
Feature: https://www.chromestatus.com/feature/4701085050601472

BUG= 653234 
TEST=constructor/channelsplitter.html updated

Review-Url: https://codereview.chromium.org/2394953002
Cr-Commit-Position: refs/heads/master@{#426006}

[modify] https://crrev.com/efb11f5a890fd4a793dbf8383fb8b529ddf39898/third_party/WebKit/LayoutTests/webaudio/constructor/channelsplitter.html
[modify] https://crrev.com/efb11f5a890fd4a793dbf8383fb8b529ddf39898/third_party/WebKit/Source/modules/webaudio/ChannelSplitterNode.cpp
[modify] https://crrev.com/efb11f5a890fd4a793dbf8383fb8b529ddf39898/third_party/WebKit/Source/modules/webaudio/ChannelSplitterNode.h

Comment 4 by rtoy@chromium.org, Nov 8 2016

Labels: Launch-M-Approved-56-Dev
Status: Fixed (was: Started)

Sign in to add a comment